You can't impose the code style rules on others, for their projects.
There are different valid options on where the place brackets, how to
indent, etc.. I'd set that aside.
However, code should be readable in any case. Jörg, can you be more
specific what you find and what you would expect in this regard?
I haven't looked myself yet.
> The code is also under GPL which is not compatible with Thunderbird.
Philippe, would you be willing to re-license under MIT or the MPL?
> There is more to production code than just working.
True. "It works" is a necessary requirement, but not a sufficient one.
On 10/04/2017 17:35, Philipp Kewisch wrote:
I'm not sure what this has to do with the add-on being featured though.Nothing really.
Jörg, are you suggesting that those requirements would be criteria for being featured?No.
Ok, thanks for the clarification. Given this thread is about featuring an add-on I think we should stay on topic. I agree that it would be great to have everyone working on core features, but finding ways to encourage this is something we should discuss separately (and also falls into the domain of a community manager, btw).
Do you have an opinion on how Thunderbird should determine
featured add-ons?
Philipp
Subject:Re: CardBook postulates to become a Thunderbird featured addon.
From:Philipp Kewisch <moz...@kewis.ch>
To:Jörg Knobloch; Tb-planning
Sent: Monday, 10/04/2017 17:58:23 17:58 GMT ST +0100 [Week 15]
Philippe
I just have one small question:
When you mean 'featured addon', is that a special designation of an addon so that it is offered prominently in the "get addons" pane of the TB integrated Addon manager?
Or do you actually propose CardBook be shipped together with TB as an internal/system addon and be enabled by default, similar to the status of Lightning (calendar)? For this part the licence may need to be compatible. I'm also not sure if this would mean the code would be stored in the comm-central tree on our servers (similar to Lightning).
aceman
______________________________________________________________
> Od: Philippe VIGNEAU <cardbook.t...@gmail.com>
> Komu: tb-pl...@mozilla.org
> Dátum: 11.04.2017 10:56
> Predmet: Re: CardBook postulates to become a Thunderbird featured addon.
>
>Hi all
>
>
>Sure, it's a free world, it's open-source, everyone can do what they want, but a coordinated effort to achieve a better overall product,
>would be preferable.
>
>--> I totally agree but I can say it's hard to be accepted ;O)
>
>
>For me this sounds like a offer to integrate CardBook.
>
>--> no offer at all , if you believe it's valuable for Thunderbird : no
>problem for me... if you don't, also no problem...
>
>
>Cardbook is not a demo of Thunderbird++ technologies, but a proposal for an alternate address book with the current version of Thunderbird. Let's
>make sure we keep those issues separate.
>
>--> right, but when the new technologies will arrive, I'll migrate
>CardBook to them. Cardbook is not a Proof Of Concept, I hope to maintain
>it on the long term (as I'm not a very skilled developper, and I hope to
>be driven|helped for this migration ;O)
>
>
>In any case, I am happy to hear that Philippe is interested in helping us with the future of Thunderbird!
>
>--> yes very
>
>
>That being said, we (Caspia) would love to figure out a way to work with you.
>
>--> I would also love to quit my "Alone" project to work with others :O)...
>
>
>Philippe, would you be willing to re-license under MIT or the MPL?
>
>--> The best for the end : CardBook is now licenced on MPL 2.0 (I don't
>know the implications but let's try :O)
CardBook may be shipped or not depending on what you think about it
(imho there is still some work to be eligible to a shipment)
my idea with CardBook is to become the twin of Lightning for the address
book...
Philippe
--> The best for the end : :rkent, would you be willing to re-license all your add-ons under MIT or the MPL too?
Would that be a requirement for any prospective addons for Thunderbird++ (or even future Thunderbird desktop addons)?
What implications would this have on monetisation? most of my addons are GPL3 except for QuickFolders which I had to make "(CC BY-ND 4.0) Attribution-NoDerivatives 4.0" because I had to protect the licensing schema on it. It is 100% open source (except for the license encryption key) and I don't mind people using parts of it but want to avoid complete clones being released as it would devalue the investment of anyone who bought a license (pro version only, 98% of the functionality is in the free version).
I had thought long and hard about that license choice, but maybe I am missing something here.
Axel
Subject:Re: CardBook postulates to become a Thunderbird featured addon.
From:Óvári <ova...@gmail.com>
To:Philippe Vigneau; Tb-planning
Sent: Tuesday, 11/04/2017 11:23:51 11:23 GMT ST +0100 [Week 15]
.