Help with cleaning up trunk

0 views
Skip to first unread message

Mark Banner

unread,
Jun 10, 2010, 8:42:07 AM6/10/10
to tb-pl...@mozilla.org
As I mentioned briefly in this week's status meeting, the aim for trunk for the next couple of weeks is to get it in a position where we are able to ship it as an alpha release.

Generally, I believe the trunk builds to be in a reasonable state. The tree is reasonably green at the moment which certainly helps, especially as that means the areas which our tests cover should still be working fine.

However I have two requests for help:
  1. Testing of nightly builds.
    • There hasn't been significant diverge in the code base yet (apart from the backend) so this should be fine testing with existing profiles, though you may want to back up first!
    • Please can folks spend a little bit of time testing trunk builds - here we're generally looking at the question of is everything still working and looking reasonable in trunk i.e. are there any dogfood bugs or big regressions from 3.1 that we need to fix?
    • See below for some bugs we know about. If you file new ones, please let me know.
  2. Help with fixing bugs
    • We've a few issues that we know about that we need to fix, some haven't hit us yet. See the list below, if people can help us fix them up, then it will help us move forward quicker.
    • We've got a bug on file for getting blocking and status flags set up for the trunk builds. Hopefully that should happen in the next few days, then we can start flagging some of these in those queries.
Significant bugs I know about:
  • Bug 565294 Add-on manager doesn't work.
    • Help with debugging would be very useful.
  • Bug 563764 / Bug 563766 Jit has been disabled in chrome because it was broken - the quick search filter bar wasn't working correctly and mozmill tests were failing.
    • All we know here is the functionality we use regressed at some stage between 1.9.2 and 1.9.3, but afaik there's no easy way to do a regression test for it. I'm hoping Andrew can take a look at it in the next few days.
  • Bug 553993 The network error page doesn't work
    • I have a patch awaiting review for this.
  • Bug 565027 The tests in toolkit/mozapps/extensions/test/ frequently time out - probably Mac only.
    • Admittedly this wouldn't even be an alpha blocker, but we're seeing frequent orange from it.
    • There's a bit of information on the bug it would be useful to know if it (easily) happens on non-Mac platforms.
    • If anyone has time to spend trying to reproduce and/or debug, that would be useful.
Any other significant bugs that are regressions from 3.1?

If anyone can spend a little bit of time debugging/fixing please assign the bug to yourself or let us know here so that we don't duplicate effort.

Thanks
Mark.

Mark Banner

unread,
Jun 15, 2010, 10:48:40 AM6/15/10
to tb-pl...@mozilla.org
How's trunk looking on non-Mac platforms, anyone tried it out yet?

On 10/06/2010 13:42, Mark Banner wrote:
Significant bugs I know about:
  • Bug 565294 Add-on manager doesn't work.
    • Help with debugging would be very useful.
This is now fixed, and we now have bug 571759 for reworking add-on manager to be in a content tab. Help wanted here. Should be quite easy to do ;-)


  • Bug 563764 / Bug 563766 Jit has been disabled in chrome because it was broken - the quick search filter bar wasn't working correctly and mozmill tests were failing.
    • All we know here is the functionality we use regressed at some stage between 1.9.2 and 1.9.3, but afaik there's no easy way to do a regression test for it. I'm hoping Andrew can take a look at it in the next few days.
That's still the right status.

Fixed

  • Bug 565027 The tests in toolkit/mozapps/extensions/test/ frequently time out - probably Mac only.
    • Admittedly this wouldn't even be an alpha blocker, but we're seeing frequent orange from it.
    • There's a bit of information on the bug it would be useful to know if it (easily) happens on non-Mac platforms.
    • If anyone has time to spend trying to reproduce and/or debug, that would be useful.
Still help wanted as I haven't got round to this yet.

Also added to the list:

Bug 572086 Attachment functions broken - open/save/detach don't work.

Mark.

neandr

unread,
Jun 15, 2010, 12:12:31 PM6/15/10
to tb-pl...@mozilla.org
Hi Mark,

could do it for Ubuntu 10.4 .. just updated and installed TB3.1rc2.

I was using TB3.1rc1 and 2 on WINxp SP3 with no problems, just started with U10.4 using the same profile as with WINxp.
Using POP3, IMAP and Newsgroup. But also made a cold, initial account setup with POP3.
No problem at all.

What's about time horizon  ... and which test environment you prefer?
  Günter
_______________________________________________ tb-planning mailing list tb-pl...@mozilla.org https://mail.mozilla.org/listinfo/tb-planning

-- 
Note:  Please use "Reply to All" to share this discussion with others on the list. Thanks

Mark Banner

unread,
Jun 15, 2010, 2:07:56 PM6/15/10
to tb-pl...@mozilla.org
On 15/06/2010 17:12, neandr wrote:
could do it for Ubuntu 10.4 .. just updated and installed TB3.1rc2.
Thanks for being willing to test, unfortunately this isn't what I meant by trunk builds. The trunk builds are the 3.2a1pre builds available from here:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-central-trunk/

They are the real cutting edge source code builds, built from the latest comm-central and mozilla-central code. These are what will be feeding into the next major version of Thunderbird post 3.1.

Mark.

Bryan Clark

unread,
Jun 15, 2010, 2:28:01 PM6/15/10
to Mark Banner, tb-pl...@mozilla.org
I've been using it on windows a bit and things seem fine so far, quick notes inline below.


On 15/06/10 7:48 AM, Mark Banner wrote:
How's trunk looking on non-Mac platforms, anyone tried it out yet?

On 10/06/2010 13:42, Mark Banner wrote:
Significant bugs I know about:
  • Bug 565294 Add-on manager doesn't work.
    • Help with debugging would be very useful.
This is now fixed, and we now have bug 571759 for reworking add-on manager to be in a content tab. Help wanted here. Should be quite easy to do ;-)
Right now it opens in a new window and doesn't seem to be working.


  • Bug 563764 / Bug 563766 Jit has been disabled in chrome because it was broken - the quick search filter bar wasn't working correctly and mozmill tests were failing.
    • All we know here is the functionality we use regressed at some stage between 1.9.2 and 1.9.3, but afaik there's no easy way to do a regression test for it. I'm hoping Andrew can take a look at it in the next few days.
That's still the right status.
Quick Search currently works as expected, I know that previously it wasn't on trunk with the jit running in chrome.

Fixed
Haven't seen this yet.

  • Bug 565027 The tests in toolkit/mozapps/extensions/test/ frequently time out - probably Mac only.
    • Admittedly this wouldn't even be an alpha blocker, but we're seeing frequent orange from it.
    • There's a bit of information on the bug it would be useful to know if it (easily) happens on non-Mac platforms.
    • If anyone has time to spend trying to reproduce and/or debug, that would be useful.
Still help wanted as I haven't got round to this yet.

Also added to the list:

Bug 572086 Attachment functions broken - open/save/detach don't work.
I am seeing this.  Save As appears to work but then nothing happens.

Wayne Mery (vn)

unread,
Jun 15, 2010, 4:21:38 PM6/15/10
to tb-pl...@mozilla.org
(unless it was mentioned in a message I deleted)

dogfood item for me - so I'm back on 3.1

Bug 572065 - Attachment functions broken - open/save/detach don't work

neandr

unread,
Jun 15, 2010, 6:11:52 PM6/15/10
to tb-pl...@mozilla.org
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a6pre) Gecko/20100615 Shredder/3.2a1pre



 [15.06.2010 16:48]    »Mark Banner« wrote:


Bug 572086 Attachment functions broken - open/save/detach don't work.
D&D fails silently, no attachment is added to the compose  "Attachments:" box. Also file can not be D&D to compose main window.

Adding with menu "Attach" works, also clicking into "Attachments:" box (after it's opened from previous add) works with "Attach File(s)" .
Sending/receiving and opening message/attachment is OK (POP account).

Detaching works.
Deleting an attachment works, a placeholder for the deleted attachment is shown without any info about the attachment.

Günter




1400x1050_20100613.dsv

Ben Bucksch

unread,
Jun 15, 2010, 6:55:04 PM6/15/10
to tb-pl...@mozilla.org
On 15.06.2010 16:48, Mark Banner wrote:
> How's trunk looking on non-Mac platforms, anyone tried it out yet?

I used to use trunk on Linux, but stopped about a month ago when the
"freeze UI for 10 seconds, every 60 seconds or so, esp. when anything
happens with the (IMAP-)folders"-bug wouldn't go away and dmose urged me
to use 3.1.

That freeze bug for me is a blocker, it makes the app totally unusable.
Is there a sign of it being fixed now? I could try trunk again in that
case, but not before.

JoeS

unread,
Jun 15, 2010, 7:56:38 PM6/15/10
to tb-pl...@mozilla.org


On 6/15/2010 10:48 AM, Mark Banner wrote:
Significant bugs I know about:
  • Bug 565294 Add-on manager doesn't work.
    • Help with debugging would be very useful.
This is now fixed, and we now have bug 571759 for reworking add-on manager to be in a content tab. Help wanted here. Should be quite easy to do ;-)
Bug 567127 should help in adding back the install button.
(Sorry for the personal email spam Mark, can't get used to this Reply>>List format)

JoeS

Mark Banner

unread,
Jun 16, 2010, 6:29:00 AM6/16/10
to tb-pl...@mozilla.org
On 15/06/2010 23:11, neandr wrote:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a6pre) Gecko/20100615 Shredder/3.2a1pre


 [15.06.2010 16:48]    »Mark Banner« wrote:


Bug 572086 Attachment functions broken - open/save/detach don't work.
D&D fails silently, no attachment is added to the compose  "Attachments:" box. Also file can not be D&D to compose main window.
Hmm, could that be a Linux specific bug? It is working fine here.


Adding with menu "Attach" works, also clicking into "Attachments:" box (after it's opened from previous add) works with "Attach File(s)" .
Sending/receiving and opening message/attachment is OK (POP account).

Yeah, thanks for testing, POP/Local folders are fine, IMAP isn't (as we subsequently found out) - see the bug infos. We're investigating the issue at the moment.

Mark.

Mark Banner

unread,
Jun 16, 2010, 6:31:37 AM6/16/10
to tb-pl...@mozilla.org
On 15/06/2010 23:55, Ben Bucksch wrote:
> On 15.06.2010 16:48, Mark Banner wrote:
>> How's trunk looking on non-Mac platforms, anyone tried it out yet?
>
> I used to use trunk on Linux, but stopped about a month ago when the
> "freeze UI for 10 seconds, every 60 seconds or so, esp. when anything
> happens with the (IMAP-)folders"-bug wouldn't go away and dmose urged
> me to use 3.1.
Certainly at the time, the better option was to use 3.1, as that's what
we were trying to get shipped.

As to the actual trunk issue, I don't think I heard anything about that.
Is there a bug on it?

> That freeze bug for me is a blocker, it makes the app totally
> unusable. Is there a sign of it being fixed now? I could try trunk
> again in that case, but not before.

Can you give the trunk a quick go again and just see if it is fixed? It
would be useful to know if we've got something like that going on.

Thanks
Mark.

Ben Bucksch

unread,
Jun 16, 2010, 7:50:46 AM6/16/10
to tb-pl...@mozilla.org
On 16.06.2010 01:56, JoeS wrote:
> (Sorry for the personal email spam Mark, can't get used to this
> Reply>>List format)

Same for me, I've hit the wrong button several times in the last days
(in fact again with this mail), and you do, and Wayne also did.

We should rename "reply" to "reply to author"
<https://bugzilla.mozilla.org/show_bug.cgi?id=533077>

Justin Wood (Callek)

unread,
Jun 16, 2010, 5:34:53 PM6/16/10
to tb-pl...@mozilla.org
On 6/16/2010 6:31 AM, Mark Banner wrote:
> On 15/06/2010 23:55, Ben Bucksch wrote:
>> On 15.06.2010 16:48, Mark Banner wrote:
>>> How's trunk looking on non-Mac platforms, anyone tried it out yet?
>>
>> I used to use trunk on Linux, but stopped about a month ago when the
>> "freeze UI for 10 seconds, every 60 seconds or so, esp. when anything
>> happens with the (IMAP-)folders"-bug wouldn't go away and dmose urged
>> me to use 3.1.
> Certainly at the time, the better option was to use 3.1, as that's
> what we were trying to get shipped.
>
> As to the actual trunk issue, I don't think I heard anything about
> that. Is there a bug on it?
>
If it is due to what I think, there is a bug on it; and it is related to
GC firings. from the JavaScript engine, I believe I CC-ed myself on the
bug, so will check in a few hours and point it out if so.

--
~Justin Wood (Callek)

Wayne Mery (vn)

unread,
Jun 16, 2010, 10:34:29 PM6/16/10
to tb-pl...@mozilla.org
On 6/16/2010 5:34 PM, Justin Wood (Callek) wrote:
> On 6/16/2010 6:31 AM, Mark Banner wrote:
>> On 15/06/2010 23:55, Ben Bucksch wrote:
>>> On 15.06.2010 16:48, Mark Banner wrote:
>>>> How's trunk looking on non-Mac platforms, anyone tried it out yet?
>>>
>>> I used to use trunk on Linux, but stopped about a month ago when the
>>> "freeze UI for 10 seconds, every 60 seconds or so, esp. when anything
>>> happens with the (IMAP-)folders"-bug wouldn't go away and dmose urged
>>> me to use 3.1.
>> Certainly at the time, the better option was to use 3.1, as that's
>> what we were trying to get shipped.
>>
>> As to the actual trunk issue, I don't think I heard anything about
>> that. Is there a bug on it?
>>
> If it is due to what I think, there is a bug on it; and it is related to
> GC firings. from the JavaScript engine, I believe I CC-ed myself on the
> bug, so will check in a few hours and point it out if so.

perhaps in the category of [Bug 565217] make cycle collector
interruptible [meta]

Is gc primarily timer driven or event driven? (would think the later)

Justin Wood (Callek)

unread,
Jun 16, 2010, 10:38:50 PM6/16/10
to tb-pl...@mozilla.org
On 6/16/2010 5:34 PM, Justin Wood (Callek) wrote:
> On 6/16/2010 6:31 AM, Mark Banner wrote:
>> On 15/06/2010 23:55, Ben Bucksch wrote:
>>> On 15.06.2010 16:48, Mark Banner wrote:
>>>> How's trunk looking on non-Mac platforms, anyone tried it out yet?
>>>
>>> I used to use trunk on Linux, but stopped about a month ago when the
>>> "freeze UI for 10 seconds, every 60 seconds or so, esp. when
>>> anything happens with the (IMAP-)folders"-bug wouldn't go away and
>>> dmose urged me to use 3.1.
>> Certainly at the time, the better option was to use 3.1, as that's
>> what we were trying to get shipped.
>>
>> As to the actual trunk issue, I don't think I heard anything about
>> that. Is there a bug on it?
>>
> If it is due to what I think, there is a bug on it; and it is related
> to GC firings. from the JavaScript engine, I believe I CC-ed myself on
> the bug, so will check in a few hours and point it out if so.
>
Bug 570435

Ben Bucksch

unread,
Jun 18, 2010, 8:37:39 PM6/18/10
to tb-pl...@mozilla.org
On 16.06.2010 00:55, Ben Bucksch wrote:
> I used to use trunk on Linux, but stopped about a month ago when the
> "freeze UI for 10 seconds, every 60 seconds or so, esp. when anything
> happens with the (IMAP-)folders"-bug wouldn't go away and dmose urged
> me to use 3.1.
>
> That freeze bug for me is a blocker, it makes the app totally unusable.

FYI, I've been running trunk in the last 2 days or so, and I didn't
notice the bug, so it seems fine now.

Thanks for the pointers to GC, I could not imagine that GC could run for
more than a few ms.

Reply all
Reply to author
Forward
0 new messages