code review 7086058: taowm: focus the frame under the mouse, when flipping t... (issue 7086058)

2 views
Skip to first unread message

nige...@golang.org

unread,
Jan 19, 2013, 9:35:20 PM1/19/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: nigeltao,

Message:
Hello nige...@golang.org (cc: ta...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/taowm/


Description:
taowm: focus the frame under the mouse, when flipping the full screen
bit.

Please review this at https://codereview.appspot.com/7086058/

Affected files:
taowm/actions.go


Index: taowm/actions.go
===================================================================
--- a/taowm/actions.go
+++ b/taowm/actions.go
@@ -388,6 +388,11 @@

func doFullscreen(k *workspace, _ interface{}) bool {
k.fullscreen = !k.fullscreen
+ if p, err := xp.QueryPointer(xConn, rootXWin).Reply(); err != nil {
+ log.Println(err)
+ } else {
+ k.focusFrame(k.frameContaining(p.RootX, p.RootY))
+ }
k.configure()
k.screen.repaint()
return false


nige...@golang.org

unread,
Jan 19, 2013, 9:38:26 PM1/19/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
*** Submitted as
https://code.google.com/p/taowm/source/detail?r=01ef0e2eac9f ***

taowm: focus the frame under the mouse, when flipping the full screen
bit.

R=nigeltao
CC=taowm
https://codereview.appspot.com/7086058


https://codereview.appspot.com/7086058/
Reply all
Reply to author
Forward
0 new messages