code review 7098061: taowm: remove unused window.workspace field. (issue 7098061)

0 views
Skip to first unread message

nige...@golang.org

unread,
Jan 15, 2013, 4:42:17 AM1/15/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: nigeltao,

Message:
Hello nige...@golang.org (cc: ta...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/taowm/


Description:
taowm: remove unused window.workspace field.

Please review this at https://codereview.appspot.com/7098061/

Affected files:
M taowm/geom.go
M taowm/input.go
M taowm/main.go


Index: taowm/geom.go
===================================================================
--- a/taowm/geom.go
+++ b/taowm/geom.go
@@ -97,7 +97,6 @@
}

type window struct {
- workspace *workspace
frame *frame
link [2]*window
transientFor *window
Index: taowm/input.go
===================================================================
--- a/taowm/input.go
+++ b/taowm/input.go
@@ -73,10 +73,10 @@

func handleEnterNotify(e xp.EnterNotifyEvent) {
w := findWindow(func(w *window) bool { return w.xWin == e.Event })
- if w == nil {
+ if w == nil || w.frame == nil {
return
}
- k := w.workspace
+ k := w.frame.workspace
f0 := k.focusedFrame
k.focusFrame(w.frame)
if k.listing == listWindows && k.focusedFrame != f0 {
Index: taowm/main.go
===================================================================
--- a/taowm/main.go
+++ b/taowm/main.go
@@ -136,7 +136,6 @@
k = screenContaining(p.RootX, p.RootY).workspace
}
w = &window{
- workspace: k,
transientFor: transientFor,
xWin: xWin,
rect: xp.Rectangle{


nige...@golang.org

unread,
Jan 15, 2013, 4:42:57 AM1/15/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reply all
Reply to author
Forward
0 new messages