code review 154360043: taowm: fix crasher when unmanaging a full-screen window... (issue 154360043 by nigeltao@golang.org)

1 view
Skip to first unread message

nige...@golang.org

unread,
Oct 15, 2014, 6:37:01 AM10/15/14
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: nigeltao,

Message:
Hello nige...@golang.org (cc: ta...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/taowm/


Description:
taowm: fix crasher when unmanaging a full-screen window on an
off-screen workspace.

Please review this at https://codereview.appspot.com/154360043/

Affected files (+3, -1 lines):
M taowm/actions.go


Index: taowm/actions.go
===================================================================
--- a/taowm/actions.go
+++ b/taowm/actions.go
@@ -404,7 +404,9 @@
k.focusFrame(k.frameContaining(p.RootX, p.RootY))
}
k.configure()
- k.screen.repaint()
+ if k.screen != nil {
+ k.screen.repaint()
+ }
return true
}



nige...@golang.org

unread,
Oct 15, 2014, 6:37:48 AM10/15/14
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
*** Submitted as
https://code.google.com/p/taowm/source/detail?r=0c7cc1e7e985 ***

taowm: fix crasher when unmanaging a full-screen window on an
off-screen workspace.

TBR=nigeltao
R=nigeltao
CC=taowm
https://codereview.appspot.com/154360043


https://codereview.appspot.com/154360043/
Reply all
Reply to author
Forward
0 new messages