code review 7092049: taowm: change window close from CL-Escape to CL-Backspace. (issue 7092049)

1 view
Skip to first unread message

nige...@golang.org

unread,
Jan 12, 2013, 6:47:38 PM1/12/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: nigeltao,

Message:
Hello nige...@golang.org (cc: ta...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/taowm/


Description:
taowm: change window close from CL-Escape to CL-Backspace.

Please review this at https://codereview.appspot.com/7092049/

Affected files:
M taowm/config.go
M taowm/doc.go


Index: taowm/config.go
===================================================================
--- a/taowm/config.go
+++ b/taowm/config.go
@@ -74,8 +74,8 @@
^xkReturn: {doExec,
[]string{"dmenu_run", "-nb", "#0f0f0f", "-nf", "#3f7f3f",
"-sb", "#0f0f0f", "-sf", "#7fff7f", "-l", "10"}},

- +xkEscape: {doWindowDelete, nil},
- ^xkEscape: {doQuit, nil},
+ +xkBackspace: {doWindowDelete, nil},
+ ^xkEscape: {doQuit, nil},

+'`': {doScreen, next},
^'~': {doScreen, prev},
Index: taowm/doc.go
===================================================================
--- a/taowm/doc.go
+++ b/taowm/doc.go
@@ -44,9 +44,9 @@

Caps Lock and the Space key will open a new web browser window. Caps Lock
and
the Enter key will open a new terminal emulator window. Caps Lock and
the '\'
-backslash key will lock the screen. Caps Lock and the Escape key will
close the
-window in the focused frame. Caps Lock and the Tab key will cycle through
the
-frames.
+backslash key will lock the screen. Caps Lock and the Backspace key will
close
+the window in the focused frame. Caps Lock and the Tab key will cycle
through
+the frames.

To quit taowm and return to the log in screen, hold down Caps Lock and the
Shift key and hit the Escape key three times in quick succession. Normally,


nige...@golang.org

unread,
Jan 12, 2013, 6:48:28 PM1/12/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
*** Submitted as
https://code.google.com/p/taowm/source/detail?r=1b86c9f2c6bd ***

taowm: change window close from CL-Escape to CL-Backspace.

R=nigeltao
CC=taowm
https://codereview.appspot.com/7092049


https://codereview.appspot.com/7092049/
Reply all
Reply to author
Forward
0 new messages