code review 7382043: taowm: when a window closes, the currently fullscreen w... (issue 7382043)

[nige...@golang.org]

Reviewers: nigeltao,

Message:
Hello nige...@golang.org (cc: ta...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/taowm/


Description:
taowm: when a window closes, the currently fullscreen window is not an
eligible replacement.

Please review this at https://codereview.appspot.com/7382043/

Affected files:
M taowm/main.go


Index: taowm/main.go
===================================================================
--- a/taowm/main.go
+++ b/taowm/main.go
@@ -216,9 +216,17 @@
} else {
bestOffscreenSeqNum := uint32(0)
for w1 := w.link[next]; w1 != w; w1 = w1.link[next] {
- if w1.offscreenSeqNum > bestOffscreenSeqNum && (k.fullscreen ||
w1.frame == nil) {
- replacement, bestOffscreenSeqNum = w1, w1.offscreenSeqNum
+ if w1.offscreenSeqNum <= bestOffscreenSeqNum {
+ continue
}
+ if k.fullscreen {
+ if w1.frame == k.focusedFrame {
+ continue
+ }
+ } else if w1.frame != nil {
+ continue
+ }
+ replacement, bestOffscreenSeqNum = w1, w1.offscreenSeqNum
}
}
if replacement != nil {

[nige...@golang.org]

*** Submitted as
https://code.google.com/p/taowm/source/detail?r=3297d6885ebf ***

taowm: when a window closes, the currently fullscreen window is not an
eligible replacement.

R=nigeltao
CC=taowm
https://codereview.appspot.com/7382043


https://codereview.appspot.com/7382043/