code review 7093053: taowm: unbreak doWorkspaceNew; it created two workspace... (issue 7093053)

1 view
Skip to first unread message

nige...@golang.org

unread,
Jan 13, 2013, 6:16:20 AM1/13/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: nigeltao,

Message:
Hello nige...@golang.org (cc: ta...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/taowm/


Description:
taowm: unbreak doWorkspaceNew; it created two workspaces for the same
screen. Refactor clickX to use changeX, for X in {Window,Workspace}.
Fix workspace.frameContaining to consider fullscreen-ness.

Please review this at https://codereview.appspot.com/7093053/

Affected files:
M taowm/actions.go
M taowm/geom.go
M taowm/input.go
M taowm/xinit.go


nige...@golang.org

unread,
Jan 13, 2013, 6:17:12 AM1/13/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
*** Submitted as
https://code.google.com/p/taowm/source/detail?r=d745f583433a ***

taowm: unbreak doWorkspaceNew; it created two workspaces for the same
screen. Refactor clickX to use changeX, for X in {Window,Workspace}.
Fix workspace.frameContaining to consider fullscreen-ness.

R=nigeltao
CC=taowm
https://codereview.appspot.com/7093053


https://codereview.appspot.com/7093053/
Reply all
Reply to author
Forward
0 new messages