code review 7128052: taowm: add a keysymString case for xkMenu. (issue 7128052)

1 view
Skip to first unread message

nige...@golang.org

unread,
Jan 17, 2013, 7:23:47 PM1/17/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: nigeltao,

Message:
Hello nige...@golang.org (cc: ta...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/taowm


Description:
taowm: add a keysymString case for xkMenu.

Please review this at https://codereview.appspot.com/7128052/

Affected files:
M taowm/keysym.go


Index: taowm/keysym.go
===================================================================
--- a/taowm/keysym.go
+++ b/taowm/keysym.go
@@ -52,6 +52,8 @@

func keysymString(keysym xp.Keysym) string {
switch keysym {
+ case xkMenu:
+ return "Menu"
case xkShiftL:
return "ShiftL"
case xkShiftR:


Brad Fitzpatrick

unread,
Jan 17, 2013, 7:24:25 PM1/17/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM




--



nige...@golang.org

unread,
Jan 17, 2013, 7:24:46 PM1/17/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reply all
Reply to author
Forward
0 new messages