code review 7086044: taowm: fix shadowed variable for doExec log message. (issue 7086044)

4 views
Skip to first unread message

nige...@golang.org

unread,
Jan 11, 2013, 12:04:30 AM1/11/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: nigeltao,

Message:
Hello nige...@golang.org (cc: ta...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/taowm


Description:
taowm: fix shadowed variable for doExec log message.

Please review this at https://codereview.appspot.com/7086044/

Affected files:
M taowm/actions.go


Index: taowm/actions.go
===================================================================
--- a/taowm/actions.go
+++ b/taowm/actions.go
@@ -19,12 +19,12 @@
return false
}
go func() {
- cmd := exec.Command(cmd[0], cmd[1:]...)
- if err := cmd.Start(); err != nil {
+ c := exec.Command(cmd[0], cmd[1:]...)
+ if err := c.Start(); err != nil {
log.Printf("could not start command %q: %v", cmd, err)
}
// Ignore any error from the program itself.
- cmd.Wait()
+ c.Wait()
}()
return false
}


nige...@golang.org

unread,
Jan 11, 2013, 12:08:17 AM1/11/13
to nige...@golang.org, ta...@googlegroups.com, re...@codereview-hr.appspotmail.com
*** Submitted as
https://code.google.com/p/taowm/source/detail?r=7f7fddd7c41d ***

taowm: fix shadowed variable for doExec log message.

R=nigeltao
CC=taowm
https://codereview.appspot.com/7086044


https://codereview.appspot.com/7086044/
Reply all
Reply to author
Forward
0 new messages