Thoughts on replacing inheritance of TrSessionImpl with composition/delegation

5 views
Skip to first unread message

Jack Singleton

unread,
Nov 3, 2013, 4:37:58 PM11/3/13
to tahrir-de...@googlegroups.com
I've done a spike for TopologyMaintenanceSessionImpl, switching from
inheritance to composition.

This simplified some of the unit test code, because we can mock methods on
TrSession instead of each of the methods that TrSession calls.

I think this will mean we can start changing how
TopologyMaintenanceSessionImpl manages dependencies without changing how
all session implementations work.

Thoughts?

https://github.com/sanity/tahrir/compare/topology-maintenance-session-refactor

Jack
Reply all
Reply to author
Forward
0 new messages