Qt5 / Dev Studio Supporot

[Michael Rosen]

I've been lurking here for several years and cloned the repository yesterday.  After a little hacking around, I can build the qt5 branch but it fails at runtime while initializing the database.  

I think I read somewhere that the project targets the Mingw toolchain.  What's known about support under the MS compiler.

[Alexandre Courbot]

Hi,

I do all development under Linux and cross-compile the Windows
binaries, so I know very little about working on a native windows
environment (excepted that it should mostly work, both Qt and CMake
being cross-platform). I don't see why the DB init would fail though -
could you pinpoint the exact point in failure in the code?

> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Tagaini Jisho" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to tagaini-jish...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Michael Rosen]

Thanks for this.  I've made a lot of progress on this.  I can't recall what the DB init failure was but I've got it building with VS and Qt5.4 .... well, it was building. I was planning a pull-request on the qt5 branch (seems more updated than qt5-dev).

msr

[Alexandre Courbot]

Thanks - I will gladly pull your request if it improves building on
Windows. That's an area that is clearly neglected.

Sorry about the confusion with the qt5 and qt5-dev branch. As you
guessed the later is obsolete and I have removed it.

[Michael Rosen]

I'm new to github and am having trouble creating the pull-request.  Attached find the diff.

 - uses MS's resource compiler which has a different CL interface.

 - changes "or" and "and" to "||" and "&&".  (note:  I'm surprised that the former compiles)

 - #warning --> #pragma warning

 - omit gcc-specific link flags.

 - use CMake 2.8.11 and associated Policy cmp0020 for Qt's 'main' entry point.

Your recent check-in for the sqlite fixed the crasher I mentioned earlier.

Thanks for considering this.

msr

[Alexandre Courbot]

Hi, sorry for the delayed reply.

I could apply your patch and type in the commit message, but I'd
really rather help you doing pull requests for efficiency (easy patch
reviews) and credit reasons, especially if you are to make
contributions on a regular basis. What issue are you having exactly?

[Michael Rosen]

mostly distraction and laziness.  ;-).  

I guess I need to (a) make a branch (b) make, test and commit my changes to that branch and then (c) make the pull request.

If you just point me to getting started with (a), I'll do it.

Thanks.

msr

[Alexandre Courbot]

To make a branch, just clone my repository to your Github account
(just click on the "fork" button when looking at my repo). Then clone
your own copy to your computer.

The rest is just typical git workflow: create a local branch, add your
changes to it, push it to your Github copy. Then from Github, you
should be able to create a pull request for your branch.

[Michael Rosen]

Getting there ... but seems to be a permissions problem:

C:\dev\tagainijisho [qt5-windows +7 ~44 -1 !]> git push origin qt5-windows

remote: Permission to Gnurou/tagainijisho.git denied to michae...@gmail.com.

fatal: unable to access 'https://github.com/Gnurou/tagainijisho.git/': The requested URL returned error: 403

C:\dev\tagainijisho [qt5-windows +7 ~44 -1 !]>

[Tracy Poff]

You need to fork, then pull from and push to your own repo. That is:

1. Visit https://github.com/Gnurou/tagainijisho/ (while logged in)
2. Click the 'Fork' button in the upper right to get your own copy of the repo.
3. It should redirect you to your repo at
https://github.com/YOURNAME/tagainijisho
4. Clone your repo with "git clone g...@github.com:YOURNAME/tagainijisho.git"
5. Make your changes.
6. Push your changes.
7. Create a pull request on github (use the "Pull Request" link on the
repo page).

The problem you seem to be having is that in step 4 you pulled from
Alexandre (Gnurou)'s repo, rather than your own.

I hope this helps. I'm no git wizard myself, so any difficulty you
have with these instructions may be my fault. Ask again if you need
more help.

--
Tracy Poff

[Michael Rosen]

Here's the pull request for Qt5 branch's Dev Studio support.

https://github.com/Gnurou/tagainijisho/pull/143

msr

[Alexandre Courbot]

Hi! Apologies for the lack of reaction reply. This looks good globally
- I will try to test and merge it today.

Will probably have a few comments for your future submissions, like
having non-related changes (e.g. the fixes of "or" to "||") into
different patches, but otherwise this seems to be good stuff!

Thanks!

[Michael Rosen]

Understand.  I'm all for getting along.  Thanks for considering this.

msr

[Alexandre Courbot]

Michael, I am so sorry for having taken so long to merge your patch.
It is finally in. I have made a few comments on
https://github.com/mrosen/tagainijisho/commit/996e17cb0baaf294f29090b2b1d3a2058a83685e
which you may want to read for your future submissions. But all in all
this is all good. Thanks for taking the time to submit this, it will
definitely be useful to other people using VS!