bug report - pagination

5 views
Skip to first unread message

Paul Traina

unread,
Apr 8, 2011, 2:53:04 PM4/8/11
to tabl...@googlegroups.com
Andrew,
Just a quick heads up... I've got the following snippet of code to add classes to some of my headers:

        "headers" => array(
            "Date" => array(
                "class" => "calldate",
            ),
            "Call ID" => array(
                "class" => "uniqueid",
            ),
        ),


Everything works fine, but when pagination is enabled and there are more table entries than fit on a single page, the sortable column headers must become links (because the data is on multiple pages), but  you also don't send out any of the additional class tags....

Example:

<table id="tgTable">
<thead>
<tr>
<th colspan="16" class="title">Call report generated Fri Apr 8 11:25:34 2011</th>
</tr>
<tr>
<th class="sortable date calldate">
<span>Date</span>
<span class="carat"></span>
</th>
<th class="sortable date">
<span>Length</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Line</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Codename</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Exchange</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Stated Location</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Volunteer</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Summary</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Question Types</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Details</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Reference</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Previous Calls</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Blocked</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Blocked Reason</span>
<span class="carat"></span>
</th>
<th class="sortable">
<span>Blocked Approval</span>
<span class="carat"></span>
</th>
<th class="sortable uniqueid">
<span>Call ID</span>
<span class="carat"></span>
</th>
</tr>
</thead>
becomes

<table id="tgTable">
<thead>
<tr>
<th colspan="16" class="title">Call report generated Fri Apr 8 11:51:58 2011</th>
</tr>
<tr>
<th>
<a href="/r2?sort=Date&amp;desc=">
<span>Date</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Length&amp;desc=">
<span>Length</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Line&amp;desc=">
<span>Line</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Codename&amp;desc=">
<span>Codename</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Exchange&amp;desc=">
<span>Exchange</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Stated Location&amp;desc=">
<span>Stated Location</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Volunteer&amp;desc=">
<span>Volunteer</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Summary&amp;desc=">
<span>Summary</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Question Types&amp;desc=">
<span>Question Types</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Details&amp;desc=">
<span>Details</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Reference&amp;desc=">
<span>Reference</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Previous Calls&amp;desc=">
<span>Previous Calls</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Blocked&amp;desc=">
<span>Blocked</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Blocked Reason&amp;desc=">
<span>Blocked Reason</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Blocked Approval&amp;desc=">
<span>Blocked Approval</span>
<span class="carat"></span>
</a>
</th>
<th>
<a href="/r2?sort=Call ID&amp;desc=">
<span>Call ID</span>
<span class="carat"></span>
</a>
</th>
</tr>
</thead>
 
 


Paul Traina

unread,
Apr 8, 2011, 4:49:42 PM4/8/11
to tabl...@googlegroups.com
This fixes the problem, but I have no idea if/why you deliberately omitted the th class attributes when pagination is enabled.
patch

Andrew

unread,
Apr 14, 2011, 8:25:55 AM4/14/11
to TableGear
Wasn't deliberate... just a bug :)
I've fixed it in 1.6.2...
http://andrewplummer.com/code/tablegear/

Thanks for the help!

Andrew

On Apr 9, 5:49 am, Paul Traina <paul.tra...@gmail.com> wrote:
> This fixes the problem, but I have no idea if/why you deliberately omitted
> the th class attributes when pagination is enabled.
>
>  patch
> < 1KViewDownload

Paul Traina

unread,
Apr 14, 2011, 12:33:36 PM4/14/11
to TableGear
Confirmed, fixed in 1.6.2, thank you!
Reply all
Reply to author
Forward
0 new messages