Help testing out 0.9.10

[PikachuEXE]

Only bug fixes for FF20
And internal changes

I am not sure if those changes would introduce new bugs so I want them tested before release

Link: http://www.mediafire.com/?as0tadg781eagpu

Thanks in advance :P




I only got some free time this month (May)
Next month I will be in a new job (not sure what is it yet)
Assumed to be busy again

[Larry Simms]

Installed.  Open favorite in new tab working fine.  No glitches yet; will advise.  Thanks!

--
You received this message because you are subscribed to the Google Groups "TabKit 2nd Edition" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tabkit-2nd-edit...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Lio]

For me, open favorite in new tab works only until a new windows is opened.
After that, favorites are opened in the current tab even if the new window is closed.

To unsubscribe from this group and stop receiving emails from it, send an email to tabkit-2nd-edition+unsub...@googlegroups.com.

[PikachuEXE]

Thanks for reporting
TabKit2 was overriding the method for each window, and the module seems to be shared acrossed windows

I have fixed it. Please try:
http://www.mediafire.com/?nunzv3eo5lag5zd

[Larry Simms]

Works—thanks!

--

You received this message because you are subscribed to the Google Groups "TabKit 2nd Edition" group.

To unsubscribe from this group and stop receiving emails from it, send an email to tabkit-2nd-edit...@googlegroups.com.

[Lio]

In my 30 minute test I have found only a small bug.
If the current tab is about:blank, favorites do not open at all.

I found this bug, accidentally because when I open a new window, randomly it opens with an about:blank, instead of about:home (I haven't found the cause of this random behavior).

[James]

I seem to have issues with multi row tabs, using Waterfox 18.0 and Tabkit 0.9.10 which is based on the FF 18 kernel, just large address aware.

[PikachuEXE]

I am not sure I still got time to support multi-row any more QAQ

James於 2013年5月2日星期四UTC+8上午3時02分43秒寫道：

[Lio]

If the current tab is about:home or about:blank (for example when a new window is opened), I think that the tab should be overwritten (do not open a new tab) when a favorite is opened.

This can be set as the default behavior or if someone do not agree with my suggestion should be added as an option:
TK2 Options -> Advanced -> Open New Tabs By Default From -> [X] Even if the current tab is about:home or about:blank

[PikachuEXE]

I just fix the about blank problem and load it in new tab anyway
I don't want to complicate things with too many options
http://www.mediafire.com/?zv379tcsz5cyl5q

[Lio]

I'm not a javascript developer nor a Firefox expert but comparing you changes I found the involved method: "returnWhereWhenOpenPlaces".

It seems there is also another bug: when a favorite is opened in a new windows it is instead opened in a new tab.

So I changed the method as follows:

  this.returnWhereWhenOpenPlaces = function returnWhereWhenOpenPlaces(aWhere, aNode) {
    if (!gPrefService.getBoolPref("extensions.tabkit.openTabsFrom.places")
       || (aNode.uri.indexOf('javascript:') == 0) /* bookmarklets*/
       ) {
      return aWhere;
    }

    // var w = getTopWin();
    var w = Components.classes["@mozilla.org/browser/browserglue;1"].getService(Components.interfaces.nsIBrowserGlue).getMostRecentBrowserWindow();
    var browser = w ? w.getBrowser().tabContainer.selectedItem.linkedBrowser : w;
    // tk.debug(browser.contentTitle);
    // tk.debug(browser.webNavigation.currentURI.spec);

    // Default behavior when currentURI is one of the following:
    if ( browser
       && (  (browser.webNavigation.currentURI.spec == "about:blank")
          || (browser.webNavigation.currentURI.spec == "about:home" ))
       ) {
      // tk.debug("return unchanged");
      return aWhere;
    }

    // Invert the behavior
    // This allow to open places in the current tab
    // using the "Open in a New Tab" command
    if ((aWhere == "tab") || (aWhere == "tabshifted")) {
      // tk.debug("return current");
      return "current";
    }

    if (aWhere == "current") {
      // tk.debug("return tab");
      return "tab";
    }

    // Fallback (for window and othe values)
    return aWhere;
  };

Some additional notes:

1. bookmarklets are excluded from this TK2 option, so I moved the condition in the first IF, even if during my tests with bookmarklets the method is not invoked (the condition on bookmarklets could be superflous)
2. I retained the default behavior when currentURI is "about:blank" or "about:home"
   This should be documented (for example in the TK2 option dialog) to avoid confusion
   If you do not agree with this decision remove the related block of code
3. When the context-menu command "Open in a New Tab" is invoked on a favorite, it is opened in the current tab
   I suppose the method do this to allow a way to open favorites in the current tab, but  the context-menu command is counter-intuitive.
   The best solution should be to replace the context-menu text with "Open in teh Current Tab" only when the option in TK2 is selected
   but I suppose this isn't a trivial change.
4. I removed the condition "browser.webProgress.isLoadingDocument"
   Why behavior should be different when page is loading?
5. I changed the fallback to "return aWhere;" to fix the opened in a new windows bug
   

I hope you appreciate my try to help you.

[PikachuEXE]

Thanks for your contribution!
I think you pretty much fix all the bugs.
I removed the code about "about:blank" and "about:home", Don't want to make it an exception and confuse user
"isLoadingDocument"? It is not written by me :P

http://www.mediafire.com/?k2g95p0za8ko9p6

[PikachuEXE]

Will release 0.9.10 this weekend if no one discover any bug
Then will work on removing features extracted into different addons

PikachuEXE於 2013年5月3日星期五UTC+8下午10時42分49秒寫道：