Fwd: RFS: imv/4.5.0-1 [Team] -- X11/Wayland image viewer intended for use with tiling window managers

[xiao shen wen（肖盛文）]

向大家转发我昨天给 Debian 软件包 imv 命令行看图程序进行版本升级，软件包评估及反馈情况。

涉及上游代码导入、更新日志格式、CI 持续构建配置、git 提交方式几个方面。

整体感觉是 Debian 的软件包评估是比较严谨的。


公开的邮件列表存档链接：
https://alioth-lists.debian.net/pipermail/pkg-phototools-devel/2024-June/016940.htm

-------- 转发的消息 --------

主题:	Re: RFS: imv/4.5.0-1 [Team] -- X11/Wayland image viewer intended for use with tiling window managers
日期:	Fri, 14 Jun 2024 19:02:32 +0800
From:	xiao sheng wen(肖盛文) <atzl...@sina.com>
组织:	https://www.atzlinux.com
收件人:	Paride Legovini <par...@debian.org>, Debian PhotoTools Maintainers <pkg-photot...@lists.alioth.debian.org>

Hi,

    Thanks for your review.

在 2024/6/14 16:25, Paride Legovini 写道:

Hello,

I can review and sponsor imv 4.5.0-1, but I prefer to work on salsa
rather than on mentors. Some comments on the changes you pushed to
debian/latest:

(1) Past upstream imports were done via `gbp import-ref`, i.e. by adding
an upstream remote and importing the upstream tag. This has the
advantage of having the full upstream commit history in the packaging
repo, and this is why d/gbp.conf had `upstream-branch =`, which you
dropped in d8e53ea1.

Now the import of 4.5.0 is done and I'm not going to ask you to revert
an re-import via import-ref, however please revert d8e53ea1 to allow the
next imports to be done from a tag via import-ref.

I do a test on my local, I check out to old version debian/4.4.0-1 to restart import,
even after drop `upstream-branch =` in d/gbp.conf, we still can use gbp import-ref -u4.5.0 to get the full upstream commit history in the debian/latest branch. I had push my test to: https://salsa.debian.org/atzlinux-guest/imv/-/commits/debian/latest-has-upstream-commit-history/?ref_type=heads My test setting is: git remote -v atzlinux g...@salsa.debian.org:atzlinux-guest/imv.git (fetch) atzlinux g...@salsa.debian.org:atzlinux-guest/imv.git (push) upstream-imv https://git.sr.ht/~exec64/imv (fetch) upstream-imv https://git.sr.ht/~exec64/imv (push) There is a new version tag in remote upstream repo upstream-imv: commit 8f36d35ff6a844de7d338a4e9b34bc98f114014b (tag: v4.5.0, upstream-imv/master) run "gbp import-ref -u4.5.0" will automate find this tag and import commit history. so, revert d8e53ea1 is not necessary. The gbp default upstream-branch is upstream, this don't to interference use gbp import-ref.
 

(2) The d/changelog style is not not very homogeneous. For example some
entries have the "d/somefile: " prefix, others do not. E.g.:

* d/u/metadata: remove obsolete fields: Contact, Name.
  Already present in machine-readable debian/copyright.
* d/salsa-ci.yml: add salsa-ci file with the salsa pipeline
* d/control: bump Standards-Version: 4.7.0, no changes needed
                                            ^^^^^^^^^^^^^^^^^ note this
[...]

By all means: use the wording you prefer! Let's just try to keep things
homogeneous.

I use routine-update package to help this new upstream version packaging.
Some of these changelog style is generated by routine-update.
I had updated the changelog in my repo.

(3) You added d/salsa-ci.yml, but it didn't trigger as that's not the
default location for CI files. I now configured the project to look for
the file in that location, so it *should* trigger with the next push.

Good!
I'm only the Developer role in debian-phototools-team salsa group,
I has not right to setting CI.
BTW:  d/salsa-ci.yml is automate create by routine-update, I don't modify.

I didn't try to build imv, I'll wait for a CI run first. We may have to
adjust something to fix some jobs, or we may want to disable some.

(4) In the future please submit your changes for review in a salsa MR,
or at least in a separate branch, so to keep the debian/latest history
cleaner. This is also valid for the changes I suggested above: ideally
they should come in a MR, especially now that we're going to have CI.
I may configure the project to restrict direct pushes to debian/latest.

Ok, I'll use MR next.

Please help view:
https://salsa.debian.org/debian-phototools-team/imv/-/merge_requests/5/

Thanks for working at imv!

Paride

On 2024-06-14 05:46, xiao sheng wen(肖盛文) wrote:

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "imv":

* Package name : imv
Version : 4.5.0-1
Upstream contact : Harry Jeffery <ha...@exec64.co.uk>
* URL : https://sr.ht/~exec64/imv
* License : Expat
* Vcs : https://salsa.debian.org/debian-phototools-team/imv
Section : graphics

The source builds the following binary packages:

imv - X11/Wayland image viewer intended for use with tiling window managers

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/imv/

Alternatively, you can download the package with 'dget' using this command:

dget -x https://mentors.debian.net/debian/pool/main/i/imv/imv_4.5.0-1.dsc

Changes since the last upload:

imv (4.5.0-1) unstable; urgency=medium
.
* Team upload.
* New upstream version
* Add salsa-ci file (routine-update)
* Remove obsolete fields Contact, Name from debian/upstream/metadata
(already
present in machine-readable debian/copyright).
* Bump Standards-Version: 4.7.0
* d/copyright: update year info to 2024
* d/control:
- Build-Depends add libturbojpeg0-dev
- Build-Depends add libjxl-dev, enable libjxl Backends
* d/gbp.conf: update to use default upstream-branch

Regards,

Regards,

-- 
肖盛文 xiao sheng wen
https://www.atzlinux.com 《铜豌豆 Linux》基于 Debian 的 Linux 中文 桌面 操作系统
Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com
Debian salsa: https://salsa.debian.org/atzlinux-guest
GnuPG Public Key: 0x00186602339240CB