[google/syzkaller] 858940: pkg/vcs: return multiple base commit candidates

0 views
Skip to first unread message

Aleksandr Nogikh

unread,
9:18 AM (5 hours ago) 9:18 AM
to syzk...@googlegroups.com
Branch: refs/heads/gh-readonly-queue/master/pr-6585-ce94b10583a205d365175b0f18ed2c9d0765559c
Home: https://github.com/google/syzkaller
Commit: 85894026b1b003844e8fda94056d80d88294b0be
https://github.com/google/syzkaller/commit/85894026b1b003844e8fda94056d80d88294b0be
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-01-13 (Tue, 13 Jan 2026)

Changed paths:
M pkg/vcs/git.go
M pkg/vcs/git_test.go
M syz-cluster/pkg/triage/git.go

Log Message:
-----------
pkg/vcs: return multiple base commit candidates

Return the commits that represent unique sets of branches.
Sort the list topologically, breaking ties by commit date.


Commit: 393201ac23707dff38037f4961f955db7e413b67
https://github.com/google/syzkaller/commit/393201ac23707dff38037f4961f955db7e413b67
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-01-13 (Tue, 13 Jan 2026)

Changed paths:
M syz-cluster/pkg/triage/commit.go
M syz-cluster/pkg/triage/commit_test.go
M syz-cluster/pkg/triage/git.go
M syz-cluster/pkg/triage/tree.go
M syz-cluster/pkg/triage/tree_test.go
M syz-cluster/workflow/triage-step/main.go

Log Message:
-----------
syz-cluster: prioritize blob-based base commits

Consider Cc'd mailing lists when selecting the exact base commit.

Among the base commits determined based on blob sha value from the git
patch, first select the ones that match both the trees of the Cc'd
subsystems and their primary branches.

If it gives no exact match, select a base commit that comes from a tree
of a Cc'd subsystem. As fallback, take any subsystem tree.

This should prevent valid, but suprising patch series triage results.


Compare: https://github.com/google/syzkaller/compare/85894026b1b0%5E...393201ac2370

To unsubscribe from these emails, change your notification settings at https://github.com/google/syzkaller/settings/notifications

Aleksandr Nogikh

unread,
9:33 AM (4 hours ago) 9:33 AM
to syzk...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages