[google/syzkaller] 73a527: tools/syz-linter: enforce one-field-per-line for m...

1 view
Skip to first unread message

Aleksandr Nogikh

unread,
May 18, 2026, 10:29:21 AM (2 days ago) May 18
to syzk...@googlegroups.com
Branch: refs/heads/gh-readonly-queue/master/pr-7298-d77e94325d4257b6d46f84ec600c478b4f1b6a3d
Home: https://github.com/google/syzkaller
Commit: 73a5278fc47101786fcce29507164fb59ac8afe3
https://github.com/google/syzkaller/commit/73a5278fc47101786fcce29507164fb59ac8afe3
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-05-18 (Mon, 18 May 2026)

Changed paths:
M dashboard/app/ai.go
M dashboard/app/ai_report_test.go
M dashboard/app/jobs.go
M dashboard/app/reporting_email.go
M pkg/codesearch/codesearch.go
M pkg/compiler/meta.go
M pkg/csource/options_test.go
M pkg/dungeon/dungeon.go
M prog/collide_test.go
M prog/minimization_test.go
M prog/rand.go
M syz-ci/jobs.go
M syz-ci/jobs_test.go
M syz-ci/manager.go
M tools/syz-check/check.go
M tools/syz-linter/linter.go
M tools/syz-linter/testdata/src/lintertest/lintertest.go

Log Message:
-----------
tools/syz-linter: enforce one-field-per-line for multi-line struct layout

When generating AI code, coding agents frequently mess up struct
initialization layout by creating multi-line struct definitions where
some fields share a line and others don't. This mixed layout is annoying
to read and maintain, and gofmt doesn't fix it automatically.

Extend the custom syz-linter to check *ast.CompositeLit nodes for structs.
If a struct initialization is spread across multiple lines, the linter now
enforces that every single field must be placed on its own line. Single-line
initializations are still perfectly valid.

Additionally, this commit fixes the 17 existing violations found across
the codebase (mostly in dashboard/app/, pkg/csource/ and syz-ci/) to
comply with the new rule.



To unsubscribe from these emails, change your notification settings at https://github.com/google/syzkaller/settings/notifications

Aleksandr Nogikh

unread,
May 18, 2026, 10:42:05 AM (2 days ago) May 18
to syzk...@googlegroups.com
Branch: refs/heads/master
Reply all
Reply to author
Forward
0 new messages