[google/syzkaller] 670ad3: pkg/osutil: add process group cleanup on CommandCo...

[Aleksandr Nogikh]

Branch: refs/heads/gh-readonly-queue/master/pr-7123-9c2d0995bb06e7518555bd3b755e327c89b59823
Home: https://github.com/google/syzkaller
Commit: 670ad3a213906ddf40dcaf93b289e3c0f67375ce
https://github.com/google/syzkaller/commit/670ad3a213906ddf40dcaf93b289e3c0f67375ce
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-04-27 (Mon, 27 Apr 2026)

Changed paths:
M pkg/osutil/osutil.go

Log Message:
-----------
pkg/osutil: add process group cleanup on CommandContext cancel

When CommandContext is cancelled, the default behavior is to only kill
the main process. If the process spawned background children, they are
left running and can become zombies if PID 1 does not reap them.

Override cmd.Cancel to use killPgroup so that the entire process group
is terminated when the context expires or is cancelled.


Commit: 567791334ee51343fd8ecfc1ea9990287c28d0a7
https://github.com/google/syzkaller/commit/567791334ee51343fd8ecfc1ea9990287c28d0a7
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-04-27 (Mon, 27 Apr 2026)

Changed paths:
M pkg/vcs/git.go
M pkg/vcs/git_test.go

Log Message:
-----------
pkg/vcs: prevent leaking background git processes

Git periodically forks background maintenance tasks like git gc --auto
during operations that create objects (e.g., merge, commit). Go's
cmd.Wait() only waits for the main foreground process to exit. When
tests finish, the background git processes are orphaned.

Switch from exec.Command to osutil.CommandContext and osutil.RunCmd.
This places git commands in their own process groups and guarantees
that all child processes are killed when the context is cancelled
or the timeout expires, preventing process leaks.


Compare: https://github.com/google/syzkaller/compare/670ad3a21390%5E...567791334ee5

To unsubscribe from these emails, change your notification settings at https://github.com/google/syzkaller/settings/notifications

[Aleksandr Nogikh]

Branch: refs/heads/master

Compare: https://github.com/google/syzkaller/compare/9c2d0995bb06...567791334ee5