[google/syzkaller] 2ab1aa: pkg/vcs: export ContainsIn

[Aleksandr Nogikh]

Branch: refs/heads/gh-readonly-queue/master/pr-7228-b09ea9df3d95c21ecaf04e8423f52421c8094283
Home: https://github.com/google/syzkaller
Commit: 2ab1aacfd182bd1fbb0a1f94db554c8afddb1273
https://github.com/google/syzkaller/commit/2ab1aacfd182bd1fbb0a1f94db554c8afddb1273
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-05-08 (Fri, 08 May 2026)

Changed paths:
M pkg/vcs/git.go

Log Message:
-----------
pkg/vcs: export ContainsIn

This will let other packages use a more lightweight vcs.Git struct.


Commit: eda2fdad3dc33aa053bc00b85036972d54128b90
https://github.com/google/syzkaller/commit/eda2fdad3dc33aa053bc00b85036972d54128b90
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-05-08 (Fri, 08 May 2026)

Changed paths:
M pkg/aflow/flow/patching/patching.go
M pkg/aflow/test_tool.go
M pkg/aflow/tool/gitlog/gitlog.go
M pkg/aflow/tool/gitlog/gitlog_test.go

Log Message:
-----------
pkg/aflow: fix gitlog tools on shallow checkout and simplify validation

The gitlog tools (git-log, git-show, git-blame) previously failed because
they queried the shallow KernelSrc checkout, which lacks full git history.

Fix this by switching the tools to use kernel.UseLinuxRepo, which accesses
the full kernel repository cache. The KernelSrc property is removed from
gitlog state and fixesFinderState.

To prevent the tools from accessing the network while preserving
the user isolation matching the repository ownership, the git commands
are explicitly wrapped in osutil.Sandbox(cmd, true, true) instead of
using osutil.RunCmd.

To support testing UseLinuxRepo, aflow.TestTool now accepts a new
aflow.TestWorkdir option to inject the test's temporary directory.

Also, simplify validateFixesHashes by using the newly exported
vcs.Git.ContainedIn instead of switching commits.


Commit: aebba483bb0538eb655ef62561c504c89d39ef8c
https://github.com/google/syzkaller/commit/aebba483bb0538eb655ef62561c504c89d39ef8c
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-05-08 (Fri, 08 May 2026)

Changed paths:
M pkg/aflow/tool/gitlog/gitlog.go
M pkg/osutil/osutil.go

Log Message:
-----------
pkg/aflow: handle timeout errors in gitlog gracefully

Export osutil.ErrTimeout and explicitly return it from osutil.Run on timeout.

Catch osutil.ErrTimeout in gitlog.go and return a detailed aflow.BadCallError,
providing the LLM agent with actionable advice instead of aborting the workflow.

Also, increase the timeout for git log to 10 minutes and provide custom
timeout advice strings for git log, git show, and git blame.


Commit: 3c3c38add0251b4319dd9a2dbf2c8a570c14a118
https://github.com/google/syzkaller/commit/3c3c38add0251b4319dd9a2dbf2c8a570c14a118
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2026-05-08 (Fri, 08 May 2026)

Changed paths:
M pkg/aflow/tool/gitlog/gitlog.go
M pkg/aflow/tool/gitlog/gitlog_test.go

Log Message:
-----------
pkg/aflow: fix git-log crash when both SymbolName and PathPrefix are provided

Git's log command forbids using the line-log option (-L, triggered by SymbolName)
and a pathspec (triggered by PathPrefix) simultaneously. If both are passed,
it fails immediately with a fatal "cannot be used with pathspec" error.

Catch this case early and return a detailed aflow.BadCallError, instructing the
agent that SymbolName and PathPrefix cannot be used together.

Also, add a test case to prevent this issue from regressing.


Compare: https://github.com/google/syzkaller/compare/2ab1aacfd182%5E...3c3c38add025

To unsubscribe from these emails, change your notification settings at https://github.com/google/syzkaller/settings/notifications

[Aleksandr Nogikh]

Branch: refs/heads/master

Compare: https://github.com/google/syzkaller/compare/b09ea9df3d95...3c3c38add025