[google/syzkaller] dee569: pkg/bisect/minimize: introduce SliceWithFixed

0 views
Skip to first unread message

Aleksandr Nogikh

unread,
Aug 27, 2024, 10:16:12 AM8/27/24
to syzk...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/google/syzkaller
Commit: dee56964d94d28f3f609bc4f62042dd6d1e153ae
https://github.com/google/syzkaller/commit/dee56964d94d28f3f609bc4f62042dd6d1e153ae
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)

Changed paths:
M pkg/bisect/minimize/slice.go
M pkg/bisect/minimize/slice_test.go

Log Message:
-----------
pkg/bisect/minimize: introduce SliceWithFixed

The function is similar to minimize.Slice(), but it allows to designate
a subset of slice elements that must always remain.


Commit: 36293874a6c15ab8f79533163a6200aa6277757d
https://github.com/google/syzkaller/commit/36293874a6c15ab8f79533163a6200aa6277757d
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)

Changed paths:
M pkg/repro/repro.go

Log Message:
-----------
pkg/repro: consider the executor info from the crash report

1) If we know the tentative reproducer, try only it before the
bisection. It's the best single candidate program.
2) During bisection, never drop the program.


Commit: d7ca24bcef5a225f0b4bd0ee404b5650f871e61b
https://github.com/google/syzkaller/commit/d7ca24bcef5a225f0b4bd0ee404b5650f871e61b
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)

Changed paths:
M pkg/repro/repro.go

Log Message:
-----------
pkg/repro: increase the minimum testing timeouts

15 seconds is an unreasonably small timeout. Let's do at least 30
seconds first, then at least 100 seconds.


Commit: 77187656728a5d9458f5a7ba82fc4b9b2704e37f
https://github.com/google/syzkaller/commit/77187656728a5d9458f5a7ba82fc4b9b2704e37f
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)

Changed paths:
M pkg/instance/execprog.go
M pkg/repro/repro.go

Log Message:
-----------
pkg/repro: don't exaggerate timeouts

Our largest timeout is 6 minutes, so anything between 1.5 minutes and 6
ended up having a 9 minute timeout. That's too much.

Consider the time it actually took to crash the kernel.


Commit: 9085be7e30d32bb8b2464e04100f8974c04aaae3
https://github.com/google/syzkaller/commit/9085be7e30d32bb8b2464e04100f8974c04aaae3
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)

Changed paths:
M pkg/repro/repro.go

Log Message:
-----------
pkg/repro: be strict about titles during opt simplifications

Ideally, we should be mindful of that during the whole repro process,
but there's always a chance that different titles are the manifestations
of the same problem.

So let's stay tolerant to different titles during prog extraction and
minimization, but carefully check them during opt simplifications and C
repro extraction.


Compare: https://github.com/google/syzkaller/compare/a1a7b2f0375c...9085be7e30d3

To unsubscribe from these emails, change your notification settings at https://github.com/google/syzkaller/settings/notifications
Reply all
Reply to author
Forward
0 new messages