Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: use-after-free Read in ntfs_attr_find
loop0: detected capacity change from 0 to 4096
==================================================================
BUG: KASAN: use-after-free in ntfs_attr_find+0x92c/0xd10 fs/ntfs/attrib.c:601
Read of size 4 at addr ffff8880650dc14c by task syz-executor.0/5458
CPU: 0 PID: 5458 Comm: syz-executor.0 Not tainted 6.5.0-rc6-syzkaller-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
print_address_description mm/kasan/report.c:364 [inline]
print_report+0x163/0x540 mm/kasan/report.c:475
kasan_report+0x175/0x1b0 mm/kasan/report.c:588
ntfs_attr_find+0x92c/0xd10 fs/ntfs/attrib.c:601
ntfs_attr_lookup+0x4e4/0x2390
ntfs_read_locked_attr_inode fs/ntfs/inode.c:1239 [inline]
ntfs_attr_iget+0x50a/0x2360 fs/ntfs/inode.c:238
load_system_files+0x1333/0x4840 fs/ntfs/super.c:1808
ntfs_fill_super+0x19b3/0x2bd0 fs/ntfs/super.c:2900
mount_bdev+0x276/0x3b0 fs/super.c:1391
legacy_get_tree+0xef/0x190 fs/fs_context.c:611
vfs_get_tree+0x8c/0x270 fs/super.c:1519
do_new_mount+0x28f/0xae0 fs/namespace.c:3335
do_mount fs/namespace.c:3675 [inline]
__do_sys_mount fs/namespace.c:3884 [inline]
__se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3861
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f83fda7e1ea
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f83fe78fee8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f83fe78ff80 RCX: 00007f83fda7e1ea
RDX: 000000002001f6c0 RSI: 000000002001f640 RDI: 00007f83fe78ff40
RBP: 000000002001f6c0 R08: 00007f83fe78ff80 R09: 0000000000008703
R10: 0000000000008703 R11: 0000000000000246 R12: 000000002001f640
R13: 00007f83fe78ff40 R14: 000000000001f621 R15: 000000002001f700
</TASK>
The buggy address belongs to the physical page:
page:ffffea0001943700 refcount:0 mapcount:0 mapping:0000000000000000 index:0x1 pfn:0x650dc
flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
page_type: 0xffffffff()
raw: 00fff00000000000 ffffea0001943788 ffffea0001c13248 0000000000000000
raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as freed
page last allocated via order 0, migratetype Movable, gfp_mask 0x140dca(GFP_HIGHUSER_MOVABLE|__GFP_COMP|__GFP_ZERO), pid 5436, tgid 5436 (dhcpcd-run-hook), ts 81549224797, free_ts 81897816074
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook+0x1e6/0x210 mm/page_alloc.c:1570
prep_new_page mm/page_alloc.c:1577 [inline]
get_page_from_freelist+0x31e8/0x3370 mm/page_alloc.c:3221
__alloc_pages+0x255/0x670 mm/page_alloc.c:4477
__folio_alloc+0x13/0x30 mm/page_alloc.c:4509
vma_alloc_folio+0x48a/0x9a0 mm/mempolicy.c:2253
do_anonymous_page mm/memory.c:4104 [inline]
do_pte_missing mm/memory.c:3662 [inline]
handle_pte_fault mm/memory.c:4939 [inline]
__handle_mm_fault mm/memory.c:5079 [inline]
handle_mm_fault+0x20c7/0x5410 mm/memory.c:5233
do_user_addr_fault arch/x86/mm/fault.c:1343 [inline]
handle_page_fault arch/x86/mm/fault.c:1486 [inline]
exc_page_fault+0x3cf/0x7c0 arch/x86/mm/fault.c:1542
asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1161 [inline]
free_unref_page_prepare+0x903/0xa30 mm/page_alloc.c:2348
free_unref_page_list+0x596/0x830 mm/page_alloc.c:2489
release_pages+0x2193/0x2470 mm/swap.c:1042
tlb_batch_pages_flush mm/mmu_gather.c:97 [inline]
tlb_flush_mmu_free mm/mmu_gather.c:292 [inline]
tlb_flush_mmu+0x100/0x210 mm/mmu_gather.c:299
tlb_finish_mmu+0xd4/0x1f0 mm/mmu_gather.c:391
exit_mmap+0x3e2/0xad0 mm/mmap.c:3215
__mmput+0x115/0x3c0 kernel/fork.c:1348
exit_mm+0x21f/0x300 kernel/exit.c:567
do_exit+0x612/0x2290 kernel/exit.c:861
do_group_exit+0x206/0x2c0 kernel/exit.c:1024
__do_sys_exit_group kernel/exit.c:1035 [inline]
__se_sys_exit_group kernel/exit.c:1033 [inline]
__x64_sys_exit_group+0x3f/0x40 kernel/exit.c:1033
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
Memory state around the buggy address:
ffff8880650dc000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff8880650dc080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff8880650dc100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff8880650dc180: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff8880650dc200: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================
Tested on:
commit: 2ccdd1b1 Linux 6.5-rc6
git tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git v6.5-rc6
console output:
https://syzkaller.appspot.com/x/log.txt?x=1012c769a80000
kernel config:
https://syzkaller.appspot.com/x/.config?x=9c37cc0e4fcc5f8d
dashboard link:
https://syzkaller.appspot.com/bug?extid=ef50f8eb00b54feb7ba2
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch:
https://syzkaller.appspot.com/x/patch.diff?x=12eaf76ba80000