Is syz-env in github container registry outdated?

[Daniel Wappner]

Hi,

I am building syzkaller using syz-env. Following the steps from the documentation, I tried to pull from the github container registry, since pulling from gcr.io seemed to be failing for me at the moment for some reason. 

Since github migrated from docker.pkg.github.com to ghcr.io I think the link mentioned in the documentation should be updated to ghcr.io/google/syzkaller/env (instead of docker.pkg.github.com/google/syzkaller/env).

I can pull from ghcr.io/google/syzkaller/env just fine, but inside the container it fails to build syzkaller. I checked the output of `go version` inside the container and it outputs: `go version go1.17 linux/amd64` , while in the image pulled from gcr.io/syzkaller/env, go version is 1.24.4.

I don't think this is really a problem since the image in gcr.io/syzkaller/env builds just fine, but I just wanted to know if the image hosted in github is still supported.

On a different note, I should mention that I tried to build the image locally using the Dockerfile in syzkaller/tools/docker/env, but it fails on line 121with the output:

 => ERROR [stage-1 24/35] RUN rustup component add rust-src
------
 > [stage-1 24/35] RUN rustup component add rust-src:
1.328 /bin/sh: 1: rustup: not found
------

Is there any previous setup that should be done to build from this Dockerfile?

Thanks in advance!

Best,

Daniel

[Dmitry Vyukov]

Yes, github repo is not updated:
https://github.com/google/syzkaller/commit/02b6492ea9aa946771baee36254b2dbb4c07c0b6
+Taras (who is OOO and will be back next week).

> --
> You received this message because you are subscribed to the Google Groups "syzkaller" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller+...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/syzkaller/fc1830c7-6d3e-432a-9d2d-bd11279dc94dn%40googlegroups.com.

[Daniel Wappner]

Thanks!
Do you think it should be removed from/mark as deprecated in https://github.com/google/syzkaller/blob/master/docs/contributing.md as well?

[Taras Madan]

Thanks for noticing it. We don't use gh containers anymore.

Do you want to fix the documentation?

If not please let me know.

To view this discussion visit https://groups.google.com/d/msgid/syzkaller/e0734258-802f-4d9f-92a4-7d27080fae4cn%40googlegroups.com.

[Daniel Wappner]

Ok,
I've just submitted PR#6386 deleting the mention of gh containers.