[google/syzkaller] 2c961e: dashboard/app: fix Google Analytics integration in...

0 views
Skip to first unread message

Alexander Potapenko

unread,
Apr 7, 2026, 10:22:21 AM (3 days ago) Apr 7
to syzk...@googlegroups.com
Branch: refs/heads/gh-readonly-queue/master/pr-7043-628666c62893a7468bcf1a68fc1129bbce02f74a
Home: https://github.com/google/syzkaller
Commit: 2c961e87c4283949ab543035190edfd8c1d70939
https://github.com/google/syzkaller/commit/2c961e87c4283949ab543035190edfd8c1d70939
Author: Alexander Potapenko <gli...@google.com>
Date: 2026-04-07 (Tue, 07 Apr 2026)

Changed paths:
M dashboard/app/local_ui_test.go
M dashboard/app/templates/dungeon-hero.html
M dashboard/app/templates/dungeon-kingdom.html
M dashboard/app/templates/dungeon.html

Log Message:
-----------
dashboard/app: fix Google Analytics integration in dungeon templates

The Google Analytics script in `dungeon-theme.html` was not rendering
because the template was included without passing the current context
(the dot `.`) in `dungeon.html`, `dungeon-hero.html`, and
`dungeon-kingdom.html`.

In Go templates, invoking a template without a pipeline (e.g.,
`{{template "dungeon-theme"}}`) sets the value of the dot `.` inside
that template to `nil`. This caused the check
`{{if .Header.AnalyticsTrackingID}}` to fail, preventing the tracking
script from being included in the rendered HTML.

This change passes the current context to the template call
(`{{template "dungeon-theme" .}}`), ensuring that the header and the
tracking ID are accessible.

Also add a dummy tracking ID to dashboard/app/local_ui_test.go.



To unsubscribe from these emails, change your notification settings at https://github.com/google/syzkaller/settings/notifications

Alexander Potapenko

unread,
Apr 7, 2026, 10:34:23 AM (3 days ago) Apr 7
to syzk...@googlegroups.com
Branch: refs/heads/master
Reply all
Reply to author
Forward
0 new messages