[google/syzkaller] b247b6: pkg/report: don't record error for empty repro log...

[Aleksandr Nogikh]

Branch: refs/heads/master
Home: https://github.com/google/syzkaller
Commit: b247b6b84a9681b3bb8bddd3a31d81d3424cc0a3
https://github.com/google/syzkaller/commit/b247b6b84a9681b3bb8bddd3a31d81d3424cc0a3
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2023-05-25 (Thu, 25 May 2023)

Changed paths:
M pkg/repro/repro.go
M syz-manager/manager.go

Log Message:
-----------
pkg/report: don't record error for empty repro log case

It's not entirely normal, but it can still happen and it's not a big
problem by itself. Let's not pollute our error logs.


Commit: e5881af751ea9a8409b341a95109823e3ffcedcf
https://github.com/google/syzkaller/commit/e5881af751ea9a8409b341a95109823e3ffcedcf
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2023-05-25 (Thu, 25 May 2023)

Changed paths:
M pkg/repro/repro.go

Log Message:
-----------
pkg/repro: refactor the Run() method

Split Run() into several functions to facilitate testing.

This commit does not introduce any functional changes.


Commit: b36c307e4d7a49e7b738ab63576854eb43855e12
https://github.com/google/syzkaller/commit/b36c307e4d7a49e7b738ab63576854eb43855e12
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2023-05-25 (Thu, 25 May 2023)

Changed paths:
M pkg/instance/execprog.go
M pkg/repro/repro.go

Log Message:
-----------
pkg/repro: factor out an interface

Interact with a syz-execprog instance via an additional interface. This
will simplify testing.


Commit: 453f56a20332a18969781dc145c8ae8da75468ea
https://github.com/google/syzkaller/commit/453f56a20332a18969781dc145c8ae8da75468ea
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2023-05-25 (Thu, 25 May 2023)

Changed paths:
M pkg/repro/repro.go
M pkg/repro/repro_test.go

Log Message:
-----------
pkg/repro: add a smoke test

This is a sanity test for the overall pkg/repro machinery. It does not
focus on minor corner cases.


Commit: f7e4c7256881bef31f5332d73c569a82cdd6cfbe
https://github.com/google/syzkaller/commit/f7e4c7256881bef31f5332d73c569a82cdd6cfbe
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2023-05-25 (Thu, 25 May 2023)

Changed paths:
M pkg/repro/repro.go
M pkg/repro/repro_test.go

Log Message:
-----------
pkg/report: restructure the shutdown process

Only use ctx.bootRequests to indicate that no further VMs are needed.

Do not return from Run() until we have fully stopped the VM creation
loop as there's a risk it might interfere with fuzzing.


Commit: 0d9bcfef72eef7ccb5cf2320bbed5014385b59c2
https://github.com/google/syzkaller/commit/0d9bcfef72eef7ccb5cf2320bbed5014385b59c2
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2023-05-25 (Thu, 25 May 2023)

Changed paths:
M pkg/repro/repro.go
M pkg/repro/repro_test.go

Log Message:
-----------
pkg/repro: retry on ExecProgInstance errors

Most of those errors seem to be transient, so there's no sense to fail
the whole C repro generation process.

Give it one more chance and only fail after that.


Commit: 0513b3e670c9ff1eb79183e59e0f7d46ea76d243
https://github.com/google/syzkaller/commit/0513b3e670c9ff1eb79183e59e0f7d46ea76d243
Author: Aleksandr Nogikh <nog...@google.com>
Date: 2023-05-25 (Thu, 25 May 2023)

Changed paths:
M syz-manager/manager.go

Log Message:
-----------
syz-manager: use 3 VMs per bug reproduction

As the process is single-threaded, the positive contribution of each
additional VM allocated for the repro generation process decreases.

For GCE VMs (mostly used by syzbot), the time to set up a VM instance
is usually less than 5 minutes. The time to run a single test that
doesn't crash the VM is ~ 10 minutes and actually most runs will be like
that.

Therefore we have plenty of time to set up a VM while another one is being
tested (on average).

Let's save resources and use 3 VMs instead of 4: one for running the
test, one is prepared in parallel and one speeds up processing in the case
of transient errors and for cases when a reproducer is able to crash a
VM quickly.


Compare: https://github.com/google/syzkaller/compare/49dc4c1546f7...0513b3e670c9