[moderation] [trace?] KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit

0 views
Skip to first unread message

syzbot

unread,
7:03 PM (1 hour ago) 7:03 PM
to syzkaller-upst...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 8dac6df92a2e Merge tag 'nfsd-7.4-1' of git://git.kernel.or..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15febcd5580000
kernel config: https://syzkaller.appspot.com/x/.config?x=886d2ddd2d6b664e
dashboard link: https://syzkaller.appspot.com/bug?extid=321e4dd9c8425252f4d3
compiler: Debian clang version 22.1.8 (1~deb13u4), Debian LLD 22.1.8
CC: [linux-...@vger.kernel.org linux-tra...@vger.kernel.org mathieu....@efficios.com mhir...@kernel.org ros...@goodmis.org]

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/dfc787d10469/disk-8dac6df9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/db7a8e4799da/vmlinux-8dac6df9.xz
kernel image: https://storage.googleapis.com/syzbot-assets/169073a123bc/bzImage-8dac6df9.xz

AI-generated root cause summary:
A KCSAN data race occurs on `struct trace_event_file::flags` between
`event_enable_trigger()` on one CPU atomically toggling
`EVENT_FILE_FL_SOFT_DISABLED_BIT` via `set_bit()`/`clear_bit()` and
`__event_trigger_test_discard()` (inlined into `trace_event_buffer_commit()`) on
another CPU performing plain, unmarked reads of `file->flags`. As documented on
`struct trace_event_file::flags`, flag readers execute locklessly and tolerate
stale flag visibility, but `__event_trigger_test_discard()` lacks `READ_ONCE()`
(and re-reads `file->flags` multiple times instead of reusing a single
`READ_ONCE()` snapshot). This causes KCSAN to flag the concurrent unmarked read
against the marked atomic bit operation.

full analysis: https://syzkaller.appspot.com/x/ai_root_cause?x=321e4dd9c8425252f4d3

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+321e4d...@syzkaller.appspotmail.com

==================================================================
BUG: KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit

write (marked) to 0xffff888100172ac8 of 8 bytes by task 3330 on cpu 0:
event_enable_trigger+0x49/0x70 kernel/trace/trace_events_trigger.c:-1
data_ops_trigger kernel/trace/trace_events_trigger.c:154 [inline]
event_triggers_call kernel/trace/trace_events_trigger.c:199 [inline]
__trace_trigger_soft_disabled+0x10f/0x1a0 kernel/trace/trace_events_trigger.c:220
trace_trigger_soft_disabled include/linux/trace_events.h:777 [inline]
do_trace_event_raw_event_sched_switch include/trace/events/sched.h:220 [inline]
trace_event_raw_event_sched_switch+0x186/0x1a0 include/trace/events/sched.h:220
__traceiter_sched_switch+0x3f/0x60 include/trace/events/sched.h:220
__do_trace_sched_switch include/trace/events/sched.h:220 [inline]
trace_sched_switch include/trace/events/sched.h:220 [inline]
__schedule+0xc3d/0xd30 kernel/sched/core.c:7383
__schedule_loop kernel/sched/core.c:7463 [inline]
schedule+0x5b/0xa0 kernel/sched/core.c:7478
do_nanosleep+0xd6/0x3d0 kernel/time/hrtimer.c:2441
hrtimer_nanosleep+0xd5/0x1e0 kernel/time/hrtimer.c:2487
common_nsleep+0x62/0x80 kernel/time/posix-timers.c:1373
__do_sys_clock_nanosleep kernel/time/posix-timers.c:1419 [inline]
__se_sys_clock_nanosleep+0x223/0x260 kernel/time/posix-timers.c:1396
__x64_sys_clock_nanosleep+0x55/0x70 kernel/time/posix-timers.c:1396
x64_sys_call+0x244d/0x2550 arch/x86/include/generated/asm/syscalls_64.h:231
do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
entry_SYSCALL_64_after_hwframe+0x77/0x7f

read to 0xffff888100172ac8 of 8 bytes by task 4765 on cpu 1:
__event_trigger_test_discard kernel/trace/trace.h:1732 [inline]
trace_event_buffer_commit+0x5c/0x5b0 kernel/trace/trace.c:2025
do_trace_event_raw_event_sched_process_fork include/trace/events/sched.h:396 [inline]
trace_event_raw_event_sched_process_fork+0x153/0x1b0 include/trace/events/sched.h:396
__do_trace_sched_process_fork include/trace/events/sched.h:396 [inline]
trace_sched_process_fork include/trace/events/sched.h:396 [inline]
kernel_clone+0x621/0x640 kernel/fork.c:2808
__do_sys_clone kernel/fork.c:2940 [inline]
__se_sys_clone kernel/fork.c:2924 [inline]
__x64_sys_clone+0x143/0x180 kernel/fork.c:2924
x64_sys_call+0x2479/0x2550 arch/x86/include/generated/asm/syscalls_64.h:57
do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
entry_SYSCALL_64_after_hwframe+0x77/0x7f

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 UID: 0 PID: 4765 Comm: dhcpcd-run-hook Not tainted syzkaller #0 PREEMPT(lazy)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup
Reply all
Reply to author
Forward
0 new messages