[v5.15] possible deadlock in jbd2_log_wait_commit

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 0a51d2d4527b Linux 5.15.173
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=154443e8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=48dad5136d11d5fc
dashboard link: https://syzkaller.appspot.com/bug?extid=baaa0f0c7207b20b883b
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/df502ed32946/disk-0a51d2d4.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/a6f49f24ceaa/vmlinux-0a51d2d4.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f45db4b68abf/bzImage-0a51d2d4.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+baaa0f...@syzkaller.appspotmail.com

(syz-executor,4166,0):ocfs2_replay_truncate_records:5967 ERROR: status = -30
(syz-executor,4166,0):__ocfs2_flush_truncate_log:6048 ERROR: status = -30
(syz-executor,4166,0):ocfs2_sync_fs:405 ERROR: status = -30
============================================
WARNING: possible recursive locking detected
5.15.173-syzkaller #0 Not tainted
--------------------------------------------
syz-executor/4166 is trying to acquire lock:
ffff8880206ae990 (jbd2_handle){++++}-{0:0}, at: jbd2_log_wait_commit+0x14f/0x490 fs/jbd2/journal.c:697

but task is already holding lock:
ffff8880206ae990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x12b9/0x1570 fs/jbd2/transaction.c:462

other info that might help us debug this:
Possible unsafe locking scenario:

CPU0
----
lock(jbd2_handle);
lock(jbd2_handle);

*** DEADLOCK ***

May be due to missing lock nesting notation

4 locks held by syz-executor/4166:
#0: ffff8880253ca0e0 (&type->s_umount_key#51){+.+.}-{3:3}, at: deactivate_super+0xa9/0xe0 fs/super.c:365
#1: ffff8880253ca650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_replay_truncate_records fs/ocfs2/alloc.c:5931 [inline]
#1: ffff8880253ca650 (sb_internal#2){.+.+}-{0:0}, at: __ocfs2_flush_truncate_log+0x4d4/0x11c0 fs/ocfs2/alloc.c:6045
#2: ffff8880601fe4e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
#3: ffff8880206ae990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x12b9/0x1570 fs/jbd2/transaction.c:462

stack backtrace:
CPU: 1 PID: 4166 Comm: syz-executor Not tainted 5.15.173-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
print_deadlock_bug kernel/locking/lockdep.c:2946 [inline]
check_deadlock kernel/locking/lockdep.c:2989 [inline]
validate_chain+0x46d2/0x5930 kernel/locking/lockdep.c:3775
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
jbd2_log_wait_commit+0x16b/0x490 fs/jbd2/journal.c:697
ocfs2_sync_fs+0x230/0x380 fs/ocfs2/super.c:413
sync_filesystem+0x1bc/0x220 fs/sync.c:66
generic_shutdown_super+0x6b/0x310 fs/super.c:448
kill_block_super+0x7a/0xe0 fs/super.c:1427
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
__syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f34cda6a207
Code: a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 a8 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007ffc27aaab08 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 00007f34cdadcab4 RCX: 00007f34cda6a207
RDX: 0000000000000000 RSI: 0000000000000009 RDI: 00007ffc27aaabc0
RBP: 00007ffc27aaabc0 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000246 R12: 00007ffc27aabc40
R13: 00007f34cdadcab4 R14: 000000000002d746 R15: 00007ffc27aabc80
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

Auto-closing this bug as obsolete.
Crashes did not happen for a while, no reproducer and no activity.