[v5.15] WARNING in nilfs_rmdir

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 963e654022cc Linux 5.15.174
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16146730580000
kernel config: https://syzkaller.appspot.com/x/.config?x=b4bb7d7fb9aff2a9
dashboard link: https://syzkaller.appspot.com/bug?extid=7f26a8adda26dc68e3d5
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/f084bf9dc6c3/disk-963e6540.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/113f4b130c9e/vmlinux-963e6540.xz
kernel image: https://storage.googleapis.com/syzbot-assets/55585cc44f24/bzImage-963e6540.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7f26a8...@syzkaller.appspotmail.com

NILFS (loop4): nilfs_palloc_commit_free_entry (ino=6): entry number 16 already freed
NILFS (loop4): nilfs_palloc_commit_free_entry (ino=6): entry number 17 already freed
NILFS (loop4): deleting nonexistent file (ino=11), 0
------------[ cut here ]------------
WARNING: CPU: 0 PID: 4173 at fs/inode.c:307 drop_nlink+0xbb/0x100
Modules linked in:
CPU: 1 PID: 4173 Comm: syz-executor Not tainted 5.15.174-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
RIP: 0010:drop_nlink+0xbb/0x100 fs/inode.c:307
Code: 49 8b 1e 48 8d bb c8 07 00 00 be 08 00 00 00 e8 4b a4 ed ff f0 48 ff 83 c8 07 00 00 5b 41 5c 41 5e 41 5f 5d c3 e8 95 c7 a3 ff <0f> 0b eb 89 44 89 e1 80 e1 07 80 c1 03 38 c1 0f 8c 62 ff ff ff 4c
RSP: 0018:ffffc90002f2fc70 EFLAGS: 00010293
RAX: ffffffff81dcbd4b RBX: 1ffff1100ea64101 RCX: ffff8880288fd940
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffff81dcbccf R09: ffffed100f48e0fa
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff888075320808
R13: 1ffff1100c2a8c33 R14: ffff8880753207c0 R15: dffffc0000000000
FS: 000055558e402500(0000) GS:ffff8880b8f00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffe14a84ff8 CR3: 0000000063c48000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
nilfs_rmdir+0x1ac/0x250 fs/nilfs2/namei.c:341
vfs_rmdir+0x305/0x460 fs/namei.c:4149
do_rmdir+0x368/0x670 fs/namei.c:4210
__do_sys_unlinkat fs/namei.c:4390 [inline]
__se_sys_unlinkat fs/namei.c:4384 [inline]
__x64_sys_unlinkat+0xdc/0xf0 fs/namei.c:4384
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fb562d032f7
Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 07 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc73b4fe38 EFLAGS: 00000207 ORIG_RAX: 0000000000000107
RAX: ffffffffffffffda RBX: 0000000000000065 RCX: 00007fb562d032f7
RDX: 0000000000000200 RSI: 00007ffc73b50fe0 RDI: 00000000ffffff9c
RBP: 00007fb562d7f80c R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000001000 R11: 0000000000000207 R12: 00007ffc73b50fe0
R13: 00007fb562d7f80c R14: 00007ffc73b53190 R15: 0000000000000030
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 963e654022cc Linux 5.15.174
git tree: linux-5.15.y

console output: https://syzkaller.appspot.com/x/log.txt?x=14d3fbe8580000

kernel config: https://syzkaller.appspot.com/x/.config?x=b4bb7d7fb9aff2a9
dashboard link: https://syzkaller.appspot.com/bug?extid=7f26a8adda26dc68e3d5
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1354bcdf980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1051060f980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/f084bf9dc6c3/disk-963e6540.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/113f4b130c9e/vmlinux-963e6540.xz
kernel image: https://storage.googleapis.com/syzbot-assets/55585cc44f24/bzImage-963e6540.xz

mounted in repro: https://storage.googleapis.com/syzbot-assets/6856ef562623/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7f26a8...@syzkaller.appspotmail.com

NILFS (loop0): nilfs_palloc_commit_free_entry (ino=6): entry number 14 already freed
NILFS (loop0): nilfs_palloc_commit_free_entry (ino=6): entry number 15 already freed
NILFS (loop0): nilfs_palloc_commit_free_entry (ino=6): entry number 16 already freed
NILFS (loop0): nilfs_palloc_commit_free_entry (ino=6): entry number 17 already freed
NILFS (loop0): deleting nonexistent file (ino=11), 0
------------[ cut here ]------------
WARNING: CPU: 0 PID: 4161 at fs/inode.c:307 drop_nlink+0xbb/0x100
Modules linked in:
CPU: 0 PID: 4161 Comm: syz-executor402 Not tainted 5.15.174-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
RIP: 0010:drop_nlink+0xbb/0x100 fs/inode.c:307
Code: 49 8b 1e 48 8d bb c8 07 00 00 be 08 00 00 00 e8 4b a4 ed ff f0 48 ff 83 c8 07 00 00 5b 41 5c 41 5e 41 5f 5d c3 e8 95 c7 a3 ff <0f> 0b eb 89 44 89 e1 80 e1 07 80 c1 03 38 c1 0f 8c 62 ff ff ff 4c

RSP: 0018:ffffc900011dfc90 EFLAGS: 00010293
RAX: ffffffff81dcbd4b RBX: 1ffff1100ea3c69c RCX: ffff888071883b80

RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000

RBP: 0000000000000000 R08: ffffffff81dcbccf R09: ffffed10055100fa
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff8880751e34e0
R13: 1ffff1100ea3c5cb R14: ffff8880751e3498 R15: dffffc0000000000
FS: 000055555e7d4380(0000) GS:ffff8880b8e00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007f6f74c01130 CR3: 00000000256b4000 CR4: 00000000003506f0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
nilfs_rmdir+0x1ac/0x250 fs/nilfs2/namei.c:341
vfs_rmdir+0x305/0x460 fs/namei.c:4149
do_rmdir+0x368/0x670 fs/namei.c:4210

__do_sys_rmdir fs/namei.c:4229 [inline]
__se_sys_rmdir fs/namei.c:4227 [inline]
__x64_sys_rmdir+0x45/0x50 fs/namei.c:4227

do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

RIP: 0033:0x7f6f74b87c07
Code: 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 54 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffea93d1aa8 EFLAGS: 00000207 ORIG_RAX: 0000000000000054
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f6f74b87c07
RDX: 0000000000008890 RSI: 0000000000000000 RDI: 00007ffea93d2c50
RBP: 0000000000000065 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000001000 R11: 0000000000000207 R12: 00007ffea93d2c50
R13: 000055555e7e5740 R14: 431bde82d7b634db R15: 00007ffea93d4dd0
</TASK>


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 912188316a8c9e41b8c1603c2276a05043b14f96
Author: Edward Adam Davis <ead...@qq.com>
Date: Mon Dec 9 06:56:52 2024 +0000

nilfs2: prevent use of deleted inode

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16b26ddf980000
start commit: 963e654022cc Linux 5.15.174
git tree: linux-5.15.y

kernel config: https://syzkaller.appspot.com/x/.config?x=b4bb7d7fb9aff2a9
dashboard link: https://syzkaller.appspot.com/bug?extid=7f26a8adda26dc68e3d5

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1354bcdf980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1051060f980000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: nilfs2: prevent use of deleted inode

For information about bisection process see: https://goo.gl/tpsmEJ#bisection