[v5.15] possible deadlock in ocfs2_lock_refcount_tree (3)

1 view
Skip to first unread message

syzbot

unread,
May 31, 2026, 10:21:25 PM (2 days ago) May 31
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 241d66fa280c Linux 5.15.208
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=133b4e73980000
kernel config: https://syzkaller.appspot.com/x/.config?x=353ae28c40b35af5
dashboard link: https://syzkaller.appspot.com/bug?extid=3cbab7d2de5bc451e3a8
compiler: Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d3e9d10633a1/disk-241d66fa.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/beca1f713e4b/vmlinux-241d66fa.xz
kernel image: https://storage.googleapis.com/syzbot-assets/26a15a6e1c14/bzImage-241d66fa.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+3cbab7...@syzkaller.appspotmail.com

ocfs2: Mounting device (7,4) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.35/4451 is trying to acquire lock:
ffff888022a65098 (&new->rf_sem){+.+.}-{3:3}, at: __ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
ffff888022a65098 (&new->rf_sem){+.+.}-{3:3}, at: ocfs2_lock_refcount_tree+0x1b4/0xa40 fs/ocfs2/refcounttree.c:463

but task is already holding lock:
ffff88805ecf8660 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_inode_lock_for_extent_tree+0x72/0x190 fs/ocfs2/file.c:2211

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_read_virt_blocks+0x237/0x8d0 fs/ocfs2/extent_map.c:984
ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
ocfs2_find_entry+0x3ca/0x2060 fs/ocfs2/dir.c:1091
ocfs2_find_files_on_disk+0xdb/0x2f0 fs/ocfs2/dir.c:1995
ocfs2_lookup_ino_from_name+0x4f/0xf0 fs/ocfs2/dir.c:2017
_ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
ocfs2_get_system_file_inode+0x32b/0x7f0 fs/ocfs2/sysfile.c:112
ocfs2_init_global_system_inodes+0x2f3/0x6d0 fs/ocfs2/super.c:458
ocfs2_initialize_super fs/ocfs2/super.c:2279 [inline]
ocfs2_fill_super+0x4060/0x50f0 fs/ocfs2/super.c:995
mount_bdev+0x287/0x3c0 fs/super.c:1400
legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
vfs_get_tree+0x88/0x270 fs/super.c:1530
do_new_mount+0x24a/0xa40 fs/namespace.c:3034
do_mount fs/namespace.c:3377 [inline]
__do_sys_mount fs/namespace.c:3585 [inline]
__se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&osb->system_file_mutex){+.+.}-{3:3}:
__mutex_lock_common+0x1e3/0x2400 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
ocfs2_get_system_file_inode+0x1b6/0x7f0 fs/ocfs2/sysfile.c:101
ocfs2_reserve_suballoc_bits+0x12b/0x44d0 fs/ocfs2/suballoc.c:776
ocfs2_reserve_new_metadata_blocks+0x412/0x9a0 fs/ocfs2/suballoc.c:978
ocfs2_add_refcount_flag+0x37d/0xe10 fs/ocfs2/refcounttree.c:3711
ocfs2_reflink_remap_extent fs/ocfs2/refcounttree.c:4591 [inline]
ocfs2_reflink_remap_blocks+0xbaf/0x1a20 fs/ocfs2/refcounttree.c:4718
ocfs2_remap_file_range+0x4ac/0x740 fs/ocfs2/file.c:2706
vfs_copy_file_range+0xd31/0x1480 fs/read_write.c:1510
__do_sys_copy_file_range fs/read_write.c:1588 [inline]
__se_sys_copy_file_range+0x320/0x470 fs/read_write.c:1551
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&new->rf_sem){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
__ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
ocfs2_lock_refcount_tree+0x1b4/0xa40 fs/ocfs2/refcounttree.c:463
ocfs2_refcount_cow_hunk fs/ocfs2/refcounttree.c:3443 [inline]
ocfs2_refcount_cow+0x581/0xd10 fs/ocfs2/refcounttree.c:3504
ocfs2_prepare_inode_for_write fs/ocfs2/file.c:2343 [inline]
ocfs2_file_write_iter+0xecb/0x1e70 fs/ocfs2/file.c:2454
do_iter_readv_writev+0x47e/0x5f0 fs/read_write.c:-1
do_iter_write+0x205/0x7b0 fs/read_write.c:855
iter_file_splice_write+0x699/0xcc0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe1/0x130 fs/splice.c:956
splice_direct_to_actor+0x4ea/0xc10 fs/splice.c:902
do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
do_sendfile+0x5fc/0xeb0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
&new->rf_sem --> &osb->system_file_mutex --> &ocfs2_file_ip_alloc_sem_key

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ocfs2_file_ip_alloc_sem_key);
lock(&osb->system_file_mutex);
lock(&ocfs2_file_ip_alloc_sem_key);
lock(&new->rf_sem);

*** DEADLOCK ***

3 locks held by syz.4.35/4451:
#0: ffff888019b9c460 (sb_writers#13){.+.+}-{0:0}, at: do_sendfile+0x5d9/0xeb0 fs/read_write.c:1248
#1: ffff88805ecf89c8 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
#1: ffff88805ecf89c8 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x436/0x1e70 fs/ocfs2/file.c:2402
#2: ffff88805ecf8660 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_inode_lock_for_extent_tree+0x72/0x190 fs/ocfs2/file.c:2211

stack backtrace:
CPU: 0 PID: 4451 Comm: syz.4.35 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/18/2026
Call Trace:
<TASK>
dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
__ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
ocfs2_lock_refcount_tree+0x1b4/0xa40 fs/ocfs2/refcounttree.c:463
ocfs2_refcount_cow_hunk fs/ocfs2/refcounttree.c:3443 [inline]
ocfs2_refcount_cow+0x581/0xd10 fs/ocfs2/refcounttree.c:3504
ocfs2_prepare_inode_for_write fs/ocfs2/file.c:2343 [inline]
ocfs2_file_write_iter+0xecb/0x1e70 fs/ocfs2/file.c:2454
do_iter_readv_writev+0x47e/0x5f0 fs/read_write.c:-1
do_iter_write+0x205/0x7b0 fs/read_write.c:855
iter_file_splice_write+0x699/0xcc0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe1/0x130 fs/splice.c:956
splice_direct_to_actor+0x4ea/0xc10 fs/splice.c:902
do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
do_sendfile+0x5fc/0xeb0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fd89da5ee59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd89bcb8028 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007fd89dcd7fa0 RCX: 00007fd89da5ee59
RDX: 0000000000000000 RSI: 000000000000000a RDI: 0000000000000009
RBP: 00007fd89daf4d6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000020fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fd89dcd8038 R14: 00007fd89dcd7fa0 R15: 00007fffcfe85b98
</TASK>
(syz.4.35,4451,1):ocfs2_dio_end_io:2428 ERROR: Direct IO failed, bytes = -12


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup
Reply all
Reply to author
Forward
0 new messages