possible deadlock in ovl_copy_up_start (2)

3 views
Skip to first unread message

syzbot

unread,
Nov 28, 2021, 12:44:17 AM11/28/21
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 66722c42ec91 Linux 4.14.256
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=11e63306b00000
kernel config: https://syzkaller.appspot.com/x/.config?x=b8004ce84f364d9
dashboard link: https://syzkaller.appspot.com/bug?extid=5a4ef18b82fe4c06dd72
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+5a4ef1...@syzkaller.appspotmail.com

batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
======================================================
WARNING: possible circular locking dependency detected
4.14.256-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/9472 is trying to acquire lock:
(&oi->lock){+.+.}, at: [<ffffffff8230fd50>] ovl_copy_up_start+0x40/0xe0 fs/overlayfs/util.c:318

but task is already holding lock:
(sb_writers#6){.+.+}, at: [<ffffffff818de18a>] sb_start_write include/linux/fs.h:1549 [inline]
(sb_writers#6){.+.+}, at: [<ffffffff818de18a>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (sb_writers#6){.+.+}:
percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
__sb_start_write+0x64/0x260 fs/super.c:1342
sb_start_write include/linux/fs.h:1549 [inline]
mnt_want_write+0x3a/0xb0 fs/namespace.c:386
ovl_xattr_set+0x4d/0x290 fs/overlayfs/inode.c:214
__vfs_setxattr+0xdc/0x130 fs/xattr.c:150
__vfs_setxattr_noperm+0xfd/0x3d0 fs/xattr.c:181
__vfs_setxattr_locked+0x14d/0x250 fs/xattr.c:239
vfs_setxattr+0xcf/0x230 fs/xattr.c:256
setxattr+0x1a9/0x300 fs/xattr.c:523
path_setxattr+0x118/0x130 fs/xattr.c:542
SYSC_lsetxattr fs/xattr.c:564 [inline]
SyS_lsetxattr+0x33/0x40 fs/xattr.c:560
batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #1 (&ovl_i_mutex_dir_key[depth]#2){++++}:
down_read+0x36/0x80 kernel/locking/rwsem.c:24
inode_lock_shared include/linux/fs.h:729 [inline]
lookup_slow+0x129/0x400 fs/namei.c:1674
lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783
ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968
vfs_rename+0x560/0x1820 fs/namei.c:4496
SYSC_renameat2 fs/namei.c:4644 [inline]
SyS_renameat2+0x95b/0xad0 fs/namei.c:4533
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #0 (&oi->lock){+.+.}
batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3d) already exists on: batadv_slave_0
:
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
IPv6: ADDRCONF(NETDEV_UP): batadv_slave_0: link is not ready
ovl_copy_up_start+0x40/0xe0 fs/overlayfs/util.c:318
ovl_copy_up_one+0x21f/0x910 fs/overlayfs/copy_up.c:631
batman_adv: batadv0: Interface activated: batadv_slave_0
ovl_copy_up_flags+0xd5/0x120 fs/overlayfs/copy_up.c:686
ovl_create_or_link+0xa2/0x1200 fs/overlayfs/dir.c:476
ovl_create_object+0x17b/0x1d0 fs/overlayfs/dir.c:550
lookup_open+0x77a/0x1750 fs/namei.c:3241
do_last fs/namei.c:3334 [inline]
path_openat+0xe08/0x2970 fs/namei.c:3569
do_filp_open+0x179/0x3c0 fs/namei.c:3603
batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3e) already exists on: batadv_slave_1
do_sys_open+0x296/0x410 fs/open.c:1081
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb

other info that might help us debug this:

Chain exists of:
&oi->lock --> &ovl_i_mutex_dir_key[depth]#2
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
--> sb_writers#6

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(sb_writers#6);
lock(&ovl_i_mutex_dir_key[depth]#2);
lock(sb_writers#6);
lock(&oi->lock);

*** DEADLOCK ***

3 locks held by syz-executor.5/9472:
#0: (sb_writers#13){.+.+}, at: [<ffffffff818de18a>] sb_start_write include/linux/fs.h:1549 [inline]
#0: (sb_writers#13){.+.+}, at: [<ffffffff818de18a>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
#1:
batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3e) already exists on: batadv_slave_1
(&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818a0c32>] inode_lock include/linux/fs.h:719 [inline]
(&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818a0c32>] do_last fs/namei.c:3331 [inline]
(&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818a0c32>] path_openat+0xde2/0x2970 fs/namei.c:3569
#2:
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
(sb_writers#6){.+.+}, at: [<ffffffff818de18a>] sb_start_write include/linux/fs.h:1549 [inline]
(sb_writers#6){.+.+}, at: [<ffffffff818de18a>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386

stack backtrace:
batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3e) already exists on: batadv_slave_1
CPU: 0 PID: 9472 Comm: syz-executor.5 Not tainted 4.14.256-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x281 lib/dump_stack.c:58
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
check_prev_add kernel/locking/lockdep.c:1905 [inline]
check_prevs_add kernel/locking/lockdep.c:2022 [inline]
validate_chain kernel/locking/lockdep.c:2464 [inline]
__lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3e) already exists on: batadv_slave_1
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
ovl_copy_up_start+0x40/0xe0 fs/overlayfs/util.c:318
ovl_copy_up_one+0x21f/0x910 fs/overlayfs/copy_up.c:631
ovl_copy_up_flags+0xd5/0x120 fs/overlayfs/copy_up.c:686
ovl_create_or_link+0xa2/0x1200 fs/overlayfs/dir.c:476
batman_adv: The newly added mac address (aa:aa:aa:aa:aa:3e) already exists on: batadv_slave_1
batman_adv: It is strongly recommended to keep mac addresses unique to avoid problems!
ovl_create_object+0x17b/0x1d0 fs/overlayfs/dir.c:550
lookup_open+0x77a/0x1750 fs/namei.c:3241
do_last fs/namei.c:3334 [inline]
path_openat+0xe08/0x2970 fs/namei.c:3569
IPv6: ADDRCONF(NETDEV_UP): batadv_slave_1: link is not ready
do_filp_open+0x179/0x3c0 fs/namei.c:3603
batman_adv: batadv0: Interface activated: batadv_slave_1
do_sys_open+0x296/0x410 fs/open.c:1081
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x7f7c35a7bae9
RSP: 002b:00007f7c32fd0188 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 00007f7c35b8f020 RCX: 00007f7c35a7bae9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000280
RBP: 00007f7c35ad5f6d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff2e9c411f R14: 00007f7c32fd0300 R15: 0000000000022000
overlayfs: filesystem on './bus' not supported as upperdir
syz-executor.0 (9409) used greatest stack depth: 25256 bytes left
IPv6: ADDRCONF(NETDEV_CHANGE): macsec0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): batadv_slave_0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth0_to_batadv: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): batadv_slave_1: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth1_to_batadv: link becomes ready
print_req_error: I/O error, dev loop5, sector 0
(syz-executor.2,9504,1):ocfs2_parse_options:1484 ERROR: Unrecognized mount option "\+! {[!" or missing value
(syz-executor.2,9504,1):ocfs2_fill_super:1217 ERROR: status = -22
cramfs: wrong magic
overlayfs: unrecognized mount option "xino=off" or missing value
print_req_error: I/O error, dev loop2, sector 0
print_req_error: I/O error, dev loop2, sector 8
vxfs: WRONG superblock magic 00000000 at 1
vxfs: WRONG superblock magic 00000000 at 8
vxfs: can't find superblock.
(syz-executor.2,9570,1):ocfs2_parse_options:1484 ERROR: Unrecognized mount option "\+! {[!" or missing value
(syz-executor.2,9570,1):ocfs2_fill_super:1217 ERROR: status = -22
cramfs: wrong magic
overlayfs: unrecognized mount option "xino=off" or missing value
vxfs: WRONG superblock magic 00000000 at 1
vxfs: WRONG superblock magic 00000000 at 8
vxfs: can't find superblock.
EXT4-fs (loop5): mounted filesystem without journal. Opts: ,errors=continue
QAT: Invalid ioctl
x_tables: ip6_tables: TCPMSS target: only valid for protocol 6
QAT: Invalid ioctl
x_tables: ip6_tables: TCPMSS target: only valid for protocol 6
WARNING: can't dereference registers at 000000000000017b for ip entry_SYSCALL_64_after_hwframe+0x46/0xbb
PF_BRIDGE: br_mdb_parse() with invalid attr
PF_BRIDGE: br_mdb_parse() with invalid attr
cannot load conntrack support for proto=2
cannot load conntrack support for proto=2
cannot load conntrack support for proto=2
BTRFS: device fsid 9c215212-8e81-4b86-99b3-14b54e97ae55 devid 1 transid 7 /dev/loop2
BTRFS error (device loop2): unsupported checksum algorithm 3
BTRFS error (device loop2): superblock checksum mismatch
BTRFS error (device loop2): open_ctree failed
BTRFS error (device loop2): unsupported checksum algorithm 3
BTRFS error (device loop2): superblock checksum mismatch
BTRFS error (device loop2): open_ctree failed
print_req_error: I/O error, dev loop2, sector 0
can: notifier: receive list not found for dev tap0
can: notifier: receive list not found for dev tap0
ip_tables: iptables: counters copy to user failed while replacing table
x_tables: ip6_tables: TCPMSS target: only valid for protocol 6
ip_tables: iptables: counters copy to user failed while replacing table
x_tables: ip6_tables: TCPMSS target: only valid for protocol 6
ip_tables: iptables: counters copy to user failed while replacing table
x_tables: ip6_tables: TCPMSS target: only valid for protocol 6
ip_tables: iptables: counters copy to user failed while replacing table
x_tables: ip6_tables: TCPMSS target: only valid for protocol 6
ip_tables: iptables: counters copy to user failed while replacing table
x_tables: ip6_tables: TCPMSS target: only valid for protocol 6
ip_tables: iptables: counters copy to user failed while replacing table
x_tables: ip6_tables: TCPMSS target: only valid for protocol 6
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
net_ratelimit: 4 callbacks suppressed
ip_tables: iptables: counters copy to user failed while replacing table


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

syzbot

unread,
May 17, 2022, 2:42:16 AM5/17/22
to syzkaller...@googlegroups.com
Auto-closing this bug as obsolete.
Crashes did not happen for a while, no reproducer and no activity.
Reply all
Reply to author
Forward
0 new messages