possible deadlock in xt_find_table_lock
16 views
Skip to first unread message
syzbot
Feb 26, 2020, 9:41:12 AM2/26/20
to syzkaller...@googlegroups.com
Hello,
syzbot found the following crash on:
HEAD commit: 98db2bf2 Linux 4.14.171
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=136e9129e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=49cf7d1ab0dd7451
dashboard link: https://syzkaller.appspot.com/bug?extid=4a80cc431422830f28e9
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
Unfortunately, I don't have any reproducer for this crash yet.
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+4a80cc...@syzkaller.appspotmail.com
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
audit: type=1800 audit(1582728027.112:308): pid=31051 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="collect_data" cause="failed" comm="syz-executor.2" name="bus" dev="sda1" ino=17457 res=0
======================================================
WARNING: possible circular locking dependency detected
4.14.171-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/31102 is trying to acquire lock:
audit: type=1804 audit(1582728027.272:309): pid=31115 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir233529238/syzkaller.Pfzoju/894/bus" dev="sda1" ino=17399 res=1
(rtnl_mutex){+.+.}, at: [<ffffffff84fcd1fe>] unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1634
but task is already holding lock:
(&xt[i].mutex){+.+.}, at: [<ffffffff852bbb45>] xt_find_table_lock+0x35/0x3d0 net/netfilter/x_tables.c:1092
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&xt[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
xt_find_revision+0x89/0x200 net/netfilter/x_tables.c:373
nfnl_compat_get+0x1f7/0x8a0 net/netfilter/nft_compat.c:678
nfnetlink_rcv_msg+0xa08/0xc00 net/netfilter/nfnetlink.c:214
netlink_rcv_skb+0x127/0x370 net/netlink/af_netlink.c:2432
nfnetlink_rcv+0x1ab/0x1650 net/netfilter/nfnetlink.c:515
netlink_unicast_kernel net/netlink/af_netlink.c:1286 [inline]
netlink_unicast+0x437/0x620 net/netlink/af_netlink.c:1312
netlink_sendmsg+0x733/0xbe0 net/netlink/af_netlink.c:1877
audit: type=1804 audit(1582728027.282:310): pid=31114 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir319971923/syzkaller.uip3Kr/950/bus" dev="sda1" ino=17537 res=1
sock_sendmsg_nosec net/socket.c:646 [inline]
sock_sendmsg+0xc5/0x100 net/socket.c:656
___sys_sendmsg+0x70a/0x840 net/socket.c:2062
__sys_sendmsg+0xa3/0x120 net/socket.c:2096
SYSC_sendmsg net/socket.c:2107 [inline]
SyS_sendmsg+0x27/0x40 net/socket.c:2103
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
-> #1 (&table[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
notifier_call_chain+0x107/0x1a0 kernel/notifier.c:93
call_netdevice_notifiers net/core/dev.c:1687 [inline]
rollback_registered_many+0x694/0xa70 net/core/dev.c:7205
rollback_registered+0xd6/0x180 net/core/dev.c:7247
unregister_netdevice_queue net/core/dev.c:8259 [inline]
unregister_netdevice_queue+0x1a1/0x220 net/core/dev.c:8252
unregister_netdevice include/linux/netdevice.h:2442 [inline]
ppp_release+0x177/0x1a0 drivers/net/ppp/ppp_generic.c:408
__fput+0x25f/0x790 fs/file_table.c:210
task_work_run+0x113/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1d6/0x220 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x42/0xb7
-> #0 (rtnl_mutex){+.+.}:
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3994
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1634
tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
cleanup_entry+0x169/0x220 net/ipv4/netfilter/ip_tables.c:666
__do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086
do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline]
do_ipt_set_ctl+0x255/0x39d net/ipv4/netfilter/ip_tables.c:1674
nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline]
ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240
udp_setsockopt+0x45/0x80 net/ipv4/udp.c:2451
SYSC_setsockopt net/socket.c:1865 [inline]
SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
other info that might help us debug this:
Chain exists of:
rtnl_mutex --> &table[i].mutex --> &xt[i].mutex
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&xt[i].mutex);
lock(&table[i].mutex);
lock(&xt[i].mutex);
lock(rtnl_mutex);
*** DEADLOCK ***
1 lock held by syz-executor.1/31102:
#0: (&xt[i].mutex){+.+.}, at: [<ffffffff852bbb45>] xt_find_table_lock+0x35/0x3d0 net/netfilter/x_tables.c:1092
stack backtrace:
CPU: 0 PID: 31102 Comm: syz-executor.1 Not tainted 4.14.171-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x13e/0x194 lib/dump_stack.c:58
print_circular_bug.isra.0.cold+0x1c4/0x282 kernel/locking/lockdep.c:1258
check_prev_add kernel/locking/lockdep.c:1901 [inline]
check_prevs_add kernel/locking/lockdep.c:2018 [inline]
validate_chain kernel/locking/lockdep.c:2460 [inline]
__lock_acquire+0x2cb3/0x4620 kernel/locking/lockdep.c:3487
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3994
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1634
tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
cleanup_entry+0x169/0x220 net/ipv4/netfilter/ip_tables.c:666
__do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086
do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline]
do_ipt_set_ctl+0x255/0x39d net/ipv4/netfilter/ip_tables.c:1674
nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline]
ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240
udp_setsockopt+0x45/0x80 net/ipv4/udp.c:2451
SYSC_setsockopt net/socket.c:1865 [inline]
SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x45c449
RSP: 002b:00007f5ad64a0c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 00007f5ad64a16d4 RCX: 000000000045c449
RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 000000000076bf20 R08: 0000000000000410 R09: 0000000000000000
R10: 00000000200009c0 R11: 0000000000000246 R12: 00000000ffffffff
R13: 0000000000000a34 R14: 00000000004cc9b4 R15: 000000000076bf2c
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
audit: type=1804 audit(1582728028.132:311): pid=31136 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir319971923/syzkaller.uip3Kr/951/bus" dev="sda1" ino=17398 res=1
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
audit: type=1804 audit(1582728028.172:312): pid=31134 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir233529238/syzkaller.Pfzoju/895/bus" dev="sda1" ino=17425 res=1
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
ip_tables: iptables: counters copy to user failed while replacing table
audit: type=1804 audit(1582728028.182:313): pid=31131 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir697167179/syzkaller.bT7U0o/935/bus" dev="sda1" ino=17809 res=1
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
audit: type=1804 audit(1582728029.032:314): pid=31178 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir319971923/syzkaller.uip3Kr/952/bus" dev="sda1" ino=17921 res=1
ip_tables: iptables: counters copy to user failed while replacing table
audit: type=1804 audit(1582728029.082:315): pid=31180 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir697167179/syzkaller.bT7U0o/936/bus" dev="sda1" ino=17985 res=1
device macvlan2 entered promiscuous mode
device veth15 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth15 left promiscuous mode
ip_tables: iptables: counters copy to user failed while replacing table
device macvlan2 entered promiscuous mode
device veth17 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth17 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth19 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth19 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth37 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth37 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth21 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth21 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth39 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth39 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth41 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth41 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth43 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth43 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth23 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth23 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth17 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth17 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth45 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth45 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth25 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth25 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth19 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth19 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth47 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth47 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth27 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth27 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth21 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth21 left promiscuous mode
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot found the following crash on:
HEAD commit: 98db2bf2 Linux 4.14.171
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=136e9129e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=49cf7d1ab0dd7451
dashboard link: https://syzkaller.appspot.com/bug?extid=4a80cc431422830f28e9
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
Unfortunately, I don't have any reproducer for this crash yet.
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+4a80cc...@syzkaller.appspotmail.com
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
audit: type=1800 audit(1582728027.112:308): pid=31051 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="collect_data" cause="failed" comm="syz-executor.2" name="bus" dev="sda1" ino=17457 res=0
======================================================
WARNING: possible circular locking dependency detected
4.14.171-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/31102 is trying to acquire lock:
audit: type=1804 audit(1582728027.272:309): pid=31115 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir233529238/syzkaller.Pfzoju/894/bus" dev="sda1" ino=17399 res=1
(rtnl_mutex){+.+.}, at: [<ffffffff84fcd1fe>] unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1634
but task is already holding lock:
(&xt[i].mutex){+.+.}, at: [<ffffffff852bbb45>] xt_find_table_lock+0x35/0x3d0 net/netfilter/x_tables.c:1092
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&xt[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
xt_find_revision+0x89/0x200 net/netfilter/x_tables.c:373
nfnl_compat_get+0x1f7/0x8a0 net/netfilter/nft_compat.c:678
nfnetlink_rcv_msg+0xa08/0xc00 net/netfilter/nfnetlink.c:214
netlink_rcv_skb+0x127/0x370 net/netlink/af_netlink.c:2432
nfnetlink_rcv+0x1ab/0x1650 net/netfilter/nfnetlink.c:515
netlink_unicast_kernel net/netlink/af_netlink.c:1286 [inline]
netlink_unicast+0x437/0x620 net/netlink/af_netlink.c:1312
netlink_sendmsg+0x733/0xbe0 net/netlink/af_netlink.c:1877
audit: type=1804 audit(1582728027.282:310): pid=31114 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir319971923/syzkaller.uip3Kr/950/bus" dev="sda1" ino=17537 res=1
sock_sendmsg_nosec net/socket.c:646 [inline]
sock_sendmsg+0xc5/0x100 net/socket.c:656
___sys_sendmsg+0x70a/0x840 net/socket.c:2062
__sys_sendmsg+0xa3/0x120 net/socket.c:2096
SYSC_sendmsg net/socket.c:2107 [inline]
SyS_sendmsg+0x27/0x40 net/socket.c:2103
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
-> #1 (&table[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
notifier_call_chain+0x107/0x1a0 kernel/notifier.c:93
call_netdevice_notifiers net/core/dev.c:1687 [inline]
rollback_registered_many+0x694/0xa70 net/core/dev.c:7205
rollback_registered+0xd6/0x180 net/core/dev.c:7247
unregister_netdevice_queue net/core/dev.c:8259 [inline]
unregister_netdevice_queue+0x1a1/0x220 net/core/dev.c:8252
unregister_netdevice include/linux/netdevice.h:2442 [inline]
ppp_release+0x177/0x1a0 drivers/net/ppp/ppp_generic.c:408
__fput+0x25f/0x790 fs/file_table.c:210
task_work_run+0x113/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1d6/0x220 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x42/0xb7
-> #0 (rtnl_mutex){+.+.}:
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3994
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1634
tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
cleanup_entry+0x169/0x220 net/ipv4/netfilter/ip_tables.c:666
__do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086
do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline]
do_ipt_set_ctl+0x255/0x39d net/ipv4/netfilter/ip_tables.c:1674
nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline]
ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240
udp_setsockopt+0x45/0x80 net/ipv4/udp.c:2451
SYSC_setsockopt net/socket.c:1865 [inline]
SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
other info that might help us debug this:
Chain exists of:
rtnl_mutex --> &table[i].mutex --> &xt[i].mutex
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&xt[i].mutex);
lock(&table[i].mutex);
lock(&xt[i].mutex);
lock(rtnl_mutex);
*** DEADLOCK ***
1 lock held by syz-executor.1/31102:
#0: (&xt[i].mutex){+.+.}, at: [<ffffffff852bbb45>] xt_find_table_lock+0x35/0x3d0 net/netfilter/x_tables.c:1092
stack backtrace:
CPU: 0 PID: 31102 Comm: syz-executor.1 Not tainted 4.14.171-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x13e/0x194 lib/dump_stack.c:58
print_circular_bug.isra.0.cold+0x1c4/0x282 kernel/locking/lockdep.c:1258
check_prev_add kernel/locking/lockdep.c:1901 [inline]
check_prevs_add kernel/locking/lockdep.c:2018 [inline]
validate_chain kernel/locking/lockdep.c:2460 [inline]
__lock_acquire+0x2cb3/0x4620 kernel/locking/lockdep.c:3487
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3994
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1634
tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
cleanup_entry+0x169/0x220 net/ipv4/netfilter/ip_tables.c:666
__do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086
do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline]
do_ipt_set_ctl+0x255/0x39d net/ipv4/netfilter/ip_tables.c:1674
nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline]
ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240
udp_setsockopt+0x45/0x80 net/ipv4/udp.c:2451
SYSC_setsockopt net/socket.c:1865 [inline]
SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x45c449
RSP: 002b:00007f5ad64a0c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 00007f5ad64a16d4 RCX: 000000000045c449
RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 000000000076bf20 R08: 0000000000000410 R09: 0000000000000000
R10: 00000000200009c0 R11: 0000000000000246 R12: 00000000ffffffff
R13: 0000000000000a34 R14: 00000000004cc9b4 R15: 000000000076bf2c
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
audit: type=1804 audit(1582728028.132:311): pid=31136 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir319971923/syzkaller.uip3Kr/951/bus" dev="sda1" ino=17398 res=1
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
audit: type=1804 audit(1582728028.172:312): pid=31134 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir233529238/syzkaller.Pfzoju/895/bus" dev="sda1" ino=17425 res=1
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
ip_tables: iptables: counters copy to user failed while replacing table
audit: type=1804 audit(1582728028.182:313): pid=31131 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir697167179/syzkaller.bT7U0o/935/bus" dev="sda1" ino=17809 res=1
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
ip_tables: iptables: counters copy to user failed while replacing table
audit: type=1804 audit(1582728029.032:314): pid=31178 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir319971923/syzkaller.uip3Kr/952/bus" dev="sda1" ino=17921 res=1
ip_tables: iptables: counters copy to user failed while replacing table
audit: type=1804 audit(1582728029.082:315): pid=31180 uid=0 auid=4294967295 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir697167179/syzkaller.bT7U0o/936/bus" dev="sda1" ino=17985 res=1
device macvlan2 entered promiscuous mode
device veth15 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth15 left promiscuous mode
ip_tables: iptables: counters copy to user failed while replacing table
device macvlan2 entered promiscuous mode
device veth17 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth17 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth19 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth19 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth37 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth37 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth21 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth21 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth39 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth39 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth41 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth41 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth43 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth43 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth23 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth23 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth17 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth17 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth45 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth45 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth25 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth25 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth19 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth19 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth47 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth47 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth27 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth27 left promiscuous mode
device macvlan2 entered promiscuous mode
device veth21 entered promiscuous mode
IPv6: ADDRCONF(NETDEV_UP): macvlan2: link is not ready
device veth21 left promiscuous mode
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
devpts: called with bogus options
---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot
Feb 27, 2020, 1:45:13 AM2/27/20
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following crash on:
HEAD commit: 98db2bf2 Linux 4.14.171
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12c43645e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13c54d31e00000
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+4a80cc...@syzkaller.appspotmail.com
audit: type=1400 audit(1582785701.707:38): avc: denied { write } for pid=7428 comm="syz-executor867" scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tclass=netlink_netfilter_socket permissive=1
rtnl_newlink+0xecb/0x1720 net/core/rtnetlink.c:2728
rtnetlink_rcv_msg+0x3be/0xb10 net/core/rtnetlink.c:4315
netlink_rcv_skb+0x127/0x370 net/netlink/af_netlink.c:2432
1 lock held by syz-executor867/7439:
RIP: 0033:0x441329
RSP: 002b:00007ffc8852f188 EFLAGS: 00000246 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441329
RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000004
RBP: 000000000000adcf R08: 0000000000000001 R09: 00000000004002c8
R10: 0000000020000b80 R11: 0000000000000246 R12: 0000000000402150
R13: 00000000004021e0 R14: 0000000000000000 R15: 0000000000000000
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
net_ratelimit: 34 callbacks suppressed
HEAD commit: 98db2bf2 Linux 4.14.171
git tree: linux-4.14.y
kernel config: https://syzkaller.appspot.com/x/.config?x=49cf7d1ab0dd7451
dashboard link: https://syzkaller.appspot.com/bug?extid=4a80cc431422830f28e9
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=176463a1e00000
dashboard link: https://syzkaller.appspot.com/bug?extid=4a80cc431422830f28e9
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13c54d31e00000
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+4a80cc...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
4.14.171-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor867/7439 is trying to acquire lock:
WARNING: possible circular locking dependency detected
4.14.171-syzkaller #0 Not tainted
------------------------------------------------------
(rtnl_mutex){+.+.}, at: [<ffffffff84fcd1fe>] unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1634
but task is already holding lock:
(&xt[i].mutex){+.+.}, at: [<ffffffff852bbb45>] xt_find_table_lock+0x35/0x3d0 net/netfilter/x_tables.c:1092
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&xt[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
xt_find_revision+0x89/0x200 net/netfilter/x_tables.c:373
nfnl_compat_get+0x1f7/0x8a0 net/netfilter/nft_compat.c:678
nfnetlink_rcv_msg+0xa08/0xc00 net/netfilter/nfnetlink.c:214
netlink_rcv_skb+0x127/0x370 net/netlink/af_netlink.c:2432
nfnetlink_rcv+0x1ab/0x1650 net/netfilter/nfnetlink.c:515
netlink_unicast_kernel net/netlink/af_netlink.c:1286 [inline]
netlink_unicast+0x437/0x620 net/netlink/af_netlink.c:1312
netlink_sendmsg+0x733/0xbe0 net/netlink/af_netlink.c:1877
but task is already holding lock:
(&xt[i].mutex){+.+.}, at: [<ffffffff852bbb45>] xt_find_table_lock+0x35/0x3d0 net/netfilter/x_tables.c:1092
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&xt[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
xt_find_revision+0x89/0x200 net/netfilter/x_tables.c:373
nfnl_compat_get+0x1f7/0x8a0 net/netfilter/nft_compat.c:678
nfnetlink_rcv_msg+0xa08/0xc00 net/netfilter/nfnetlink.c:214
netlink_rcv_skb+0x127/0x370 net/netlink/af_netlink.c:2432
nfnetlink_rcv+0x1ab/0x1650 net/netfilter/nfnetlink.c:515
netlink_unicast_kernel net/netlink/af_netlink.c:1286 [inline]
netlink_unicast+0x437/0x620 net/netlink/af_netlink.c:1312
netlink_sendmsg+0x733/0xbe0 net/netlink/af_netlink.c:1877
sock_sendmsg_nosec net/socket.c:646 [inline]
sock_sendmsg+0xc5/0x100 net/socket.c:656
___sys_sendmsg+0x70a/0x840 net/socket.c:2062
__sys_sendmsg+0xa3/0x120 net/socket.c:2096
SYSC_sendmsg net/socket.c:2107 [inline]
SyS_sendmsg+0x27/0x40 net/socket.c:2103
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
-> #1 (&table[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
notifier_call_chain+0x107/0x1a0 kernel/notifier.c:93
call_netdevice_notifiers net/core/dev.c:1687 [inline]
rollback_registered_many+0x694/0xa70 net/core/dev.c:7205
rollback_registered+0xd6/0x180 net/core/dev.c:7247
unregister_netdevice_queue net/core/dev.c:8259 [inline]
unregister_netdevice_queue+0x1a1/0x220 net/core/dev.c:8252
unregister_netdevice include/linux/netdevice.h:2442 [inline]
veth_newlink+0x53e/0x8a0 drivers/net/veth.c:463
sock_sendmsg+0xc5/0x100 net/socket.c:656
___sys_sendmsg+0x70a/0x840 net/socket.c:2062
__sys_sendmsg+0xa3/0x120 net/socket.c:2096
SYSC_sendmsg net/socket.c:2107 [inline]
SyS_sendmsg+0x27/0x40 net/socket.c:2103
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
-> #1 (&table[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
notifier_call_chain+0x107/0x1a0 kernel/notifier.c:93
call_netdevice_notifiers net/core/dev.c:1687 [inline]
rollback_registered_many+0x694/0xa70 net/core/dev.c:7205
rollback_registered+0xd6/0x180 net/core/dev.c:7247
unregister_netdevice_queue net/core/dev.c:8259 [inline]
unregister_netdevice_queue+0x1a1/0x220 net/core/dev.c:8252
unregister_netdevice include/linux/netdevice.h:2442 [inline]
rtnl_newlink+0xecb/0x1720 net/core/rtnetlink.c:2728
rtnetlink_rcv_msg+0x3be/0xb10 net/core/rtnetlink.c:4315
netlink_rcv_skb+0x127/0x370 net/netlink/af_netlink.c:2432
netlink_unicast_kernel net/netlink/af_netlink.c:1286 [inline]
netlink_unicast+0x437/0x620 net/netlink/af_netlink.c:1312
netlink_sendmsg+0x733/0xbe0 net/netlink/af_netlink.c:1877
netlink_unicast+0x437/0x620 net/netlink/af_netlink.c:1312
netlink_sendmsg+0x733/0xbe0 net/netlink/af_netlink.c:1877
sock_sendmsg_nosec net/socket.c:646 [inline]
sock_sendmsg+0xc5/0x100 net/socket.c:656
___sys_sendmsg+0x70a/0x840 net/socket.c:2062
__sys_sendmsg+0xa3/0x120 net/socket.c:2096
SYSC_sendmsg net/socket.c:2107 [inline]
SyS_sendmsg+0x27/0x40 net/socket.c:2103
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
sock_sendmsg+0xc5/0x100 net/socket.c:656
___sys_sendmsg+0x70a/0x840 net/socket.c:2062
__sys_sendmsg+0xa3/0x120 net/socket.c:2096
SYSC_sendmsg net/socket.c:2107 [inline]
SyS_sendmsg+0x27/0x40 net/socket.c:2103
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
#0: (&xt[i].mutex){+.+.}, at: [<ffffffff852bbb45>] xt_find_table_lock+0x35/0x3d0 net/netfilter/x_tables.c:1092
stack backtrace:
CPU: 0 PID: 7439 Comm: syz-executor867 Not tainted 4.14.171-syzkaller #0
stack backtrace:
RSP: 002b:00007ffc8852f188 EFLAGS: 00000246 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441329
RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000004
RBP: 000000000000adcf R08: 0000000000000001 R09: 00000000004002c8
R10: 0000000020000b80 R11: 0000000000000246 R12: 0000000000402150
R13: 00000000004021e0 R14: 0000000000000000 R15: 0000000000000000
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
net_ratelimit: 29 callbacks suppressed
ip_tables: iptables: counters copy to user failed while replacing table
nla_parse: 30 callbacks suppressed
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
ip_tables: iptables: counters copy to user failed while replacing table
netlink: 20 bytes leftover after parsing attributes in process `syz-executor867'.
net_ratelimit: 34 callbacks suppressed
Reply all
Reply to author
Forward
0 new messages