possible deadlock in red_adaptative_timer

5 views
Skip to first unread message

syzbot

unread,
Jul 28, 2020, 9:48:16 AM7/28/20
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 20b3a3df Linux 4.19.134
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17753728900000
kernel config: https://syzkaller.appspot.com/x/.config?x=7c76c572c403b9ac
dashboard link: https://syzkaller.appspot.com/bug?extid=9f57216a517eb79b590e
compiler: gcc (GCC) 10.1.0-syz 20200507

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9f5721...@syzkaller.appspotmail.com

hid-generic 0000:0000:0000.005E: unknown main item tag 0x0
hid-generic 0000:0000:0000.005E: unknown main item tag 0x0
hid-generic 0000:0000:0000.005E: unknown main item tag 0x0
hid-generic 0000:0000:0000.005E: unknown main item tag 0x0
======================================================
WARNING: possible circular locking dependency detected
4.19.134-syzkaller #0 Not tainted
------------------------------------------------------
kworker/1:0/19 is trying to acquire lock:
00000000748e17d1 (&qdisc_tx_lock){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
00000000748e17d1 (&qdisc_tx_lock){+.-.}, at: red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265

but task is already holding lock:
00000000e010beb1 ((&q->adapt_timer)){+.-.}, at: lockdep_copy_map include/linux/lockdep.h:168 [inline]
00000000e010beb1 ((&q->adapt_timer)){+.-.}, at: call_timer_fn+0xc9/0x700 kernel/time/timer.c:1327

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 ((&q->adapt_timer)){+.-.}:
red_destroy+0x15/0x60 net/sched/sch_red.c:182
qdisc_destroy+0x180/0x780 net/sched/sch_generic.c:983
red_change+0x514/0x1080 net/sched/sch_red.c:236
qdisc_change net/sched/sch_api.c:1239 [inline]
tc_modify_qdisc+0xf6a/0x1a80 net/sched/sch_api.c:1542
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4777
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2455
netlink_unicast_kernel net/netlink/af_netlink.c:1318 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1344
netlink_sendmsg+0x6bb/0xc40 net/netlink/af_netlink.c:1909
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:632
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2115
__sys_sendmsg net/socket.c:2153 [inline]
__do_sys_sendmsg net/socket.c:2162 [inline]
__se_sys_sendmsg net/socket.c:2160 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2160
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&qdisc_tx_lock){+.-.}:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265
call_timer_fn+0x177/0x700 kernel/time/timer.c:1337
expire_timers+0x243/0x4e0 kernel/time/timer.c:1374
__run_timers kernel/time/timer.c:1695 [inline]
run_timer_softirq+0x21c/0x670 kernel/time/timer.c:1708
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
invoke_softirq kernel/softirq.c:372 [inline]
irq_exit+0x215/0x260 kernel/softirq.c:412
exiting_irq arch/x86/include/asm/apic.h:544 [inline]
smp_apic_timer_interrupt+0x136/0x550 arch/x86/kernel/apic/apic.c:1094
apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:894
arch_local_irq_restore arch/x86/include/asm/paravirt.h:789 [inline]
console_unlock+0xe7b/0x1110 kernel/printk/printk.c:2465
vprintk_emit+0x2d1/0x740 kernel/printk/printk.c:1965
dev_vprintk_emit+0x2e3/0x640 drivers/base/core.c:3248
dev_printk_emit+0xbb/0xf0 drivers/base/core.c:3259
__dev_printk+0x108/0x260 drivers/base/core.c:3271
_dev_warn+0xd8/0x110 drivers/base/core.c:3315
hid_parser_main+0x65d/0xb60 drivers/hid/hid-core.c:629
hid_open_report+0x355/0x6e0 drivers/hid/hid-core.c:1089
hid_parse include/linux/hid.h:1014 [inline]
hid_generic_probe+0x4a/0x90 drivers/hid/hid-generic.c:66
hid_device_probe+0x29e/0x3d0 drivers/hid/hid-core.c:2088
really_probe+0x58c/0x7e0 drivers/base/dd.c:503
driver_probe_device+0xf9/0x200 drivers/base/dd.c:664
__device_attach_driver+0x28b/0x310 drivers/base/dd.c:751
bus_for_each_drv+0x159/0x1e0 drivers/base/bus.c:464
__device_attach+0x298/0x3d0 drivers/base/dd.c:817
bus_probe_device+0x1ea/0x2a0 drivers/base/bus.c:524
device_add+0xac3/0x1610 drivers/base/core.c:2154
hid_add_device+0x344/0x9e0 drivers/hid/hid-core.c:2244
uhid_device_add_worker+0x3a/0x150 drivers/hid/uhid.c:65
process_one_work+0x864/0x1570 kernel/workqueue.c:2155
worker_thread+0x64c/0x1130 kernel/workqueue.c:2298
kthread+0x30b/0x410 kernel/kthread.c:246
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock((&q->adapt_timer));
lock(&qdisc_tx_lock);
lock((&q->adapt_timer));
lock(&qdisc_tx_lock);

*** DEADLOCK ***

5 locks held by kworker/1:0/19:
#0: 00000000e104779b ((wq_completion)"events"){+.+.}, at: process_one_work+0x767/0x1570 kernel/workqueue.c:2126
#1: 0000000013ab6314 ((work_completion)(&uhid->worker)){+.+.}, at: process_one_work+0x79c/0x1570 kernel/workqueue.c:2130
#2: 000000006844c2ce (&dev->mutex){....}, at: device_lock include/linux/device.h:1173 [inline]
#2: 000000006844c2ce (&dev->mutex){....}, at: __device_attach+0x7a/0x3d0 drivers/base/dd.c:794
#3: 000000004b32a696 (console_lock){+.+.}, at: dev_vprintk_emit+0x2e3/0x640 drivers/base/core.c:3248
#4: 00000000e010beb1 ((&q->adapt_timer)){+.-.}, at: lockdep_copy_map include/linux/lockdep.h:168 [inline]
#4: 00000000e010beb1 ((&q->adapt_timer)){+.-.}, at: call_timer_fn+0xc9/0x700 kernel/time/timer.c:1327

stack backtrace:
CPU: 1 PID: 19 Comm: kworker/1:0 Not tainted 4.19.134-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events uhid_device_add_worker
Call Trace:
<IRQ>
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2fe lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1221
check_prev_add kernel/locking/lockdep.c:1865 [inline]
check_prevs_add kernel/locking/lockdep.c:1978 [inline]
validate_chain kernel/locking/lockdep.c:2419 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3415
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3907
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265
call_timer_fn+0x177/0x700 kernel/time/timer.c:1337
expire_timers+0x243/0x4e0 kernel/time/timer.c:1374
__run_timers kernel/time/timer.c:1695 [inline]
run_timer_softirq+0x21c/0x670 kernel/time/timer.c:1708
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
invoke_softirq kernel/softirq.c:372 [inline]
irq_exit+0x215/0x260 kernel/softirq.c:412
exiting_irq arch/x86/include/asm/apic.h:544 [inline]
smp_apic_timer_interrupt+0x136/0x550 arch/x86/kernel/apic/apic.c:1094
apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:894
</IRQ>
RIP: 0010:arch_local_irq_restore arch/x86/include/asm/paravirt.h:789 [inline]
RIP: 0010:console_unlock+0xe7b/0x1110 kernel/printk/printk.c:2465
Code: ff df 48 c1 e8 03 80 3c 08 00 0f 85 66 02 00 00 48 83 3d 9f d4 7d 07 00 0f 84 9e 00 00 00 e8 8c 28 15 00 48 8b 7c 24 30 57 9d <0f> 1f 44 00 00 e9 9b fc ff ff e8 76 28 15 00 0f 0b e8 6f 28 15 00
RSP: 0018:ffff8880a9f7f380 EFLAGS: 00000293 ORIG_RAX: ffffffffffffff13
RAX: ffff8880a9f70500 RBX: 0000000000000200 RCX: dffffc0000000000
RDX: 0000000000000000 RSI: ffffffff815486b4 RDI: 0000000000000293
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff845c88d0
R13: 000000000000004a R14: 0000000000000000 R15: ffffffff894602d0
vprintk_emit+0x2d1/0x740 kernel/printk/printk.c:1965
dev_vprintk_emit+0x2e3/0x640 drivers/base/core.c:3248
dev_printk_emit+0xbb/0xf0 drivers/base/core.c:3259
__dev_printk+0x108/0x260 drivers/base/core.c:3271
_dev_warn+0xd8/0x110 drivers/base/core.c:3315
hid_parser_main+0x65d/0xb60 drivers/hid/hid-core.c:629
hid_open_report+0x355/0x6e0 drivers/hid/hid-core.c:1089
hid_parse include/linux/hid.h:1014 [inline]
hid_generic_probe+0x4a/0x90 drivers/hid/hid-generic.c:66
hid_device_probe+0x29e/0x3d0 drivers/hid/hid-core.c:2088
really_probe+0x58c/0x7e0 drivers/base/dd.c:503
driver_probe_device+0xf9/0x200 drivers/base/dd.c:664
__device_attach_driver+0x28b/0x310 drivers/base/dd.c:751
bus_for_each_drv+0x159/0x1e0 drivers/base/bus.c:464
__device_attach+0x298/0x3d0 drivers/base/dd.c:817
bus_probe_device+0x1ea/0x2a0 drivers/base/bus.c:524
device_add+0xac3/0x1610 drivers/base/core.c:2154
hid_add_device+0x344/0x9e0 drivers/hid/hid-core.c:2244
uhid_device_add_worker+0x3a/0x150 drivers/hid/uhid.c:65
process_one_work+0x864/0x1570 kernel/workqueue.c:2155
worker_thread+0x64c/0x1130 kernel/workqueue.c:2298
kthread+0x30b/0x410 kernel/kthread.c:246
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415
SELinux: duplicate or incompatible mount options
IPVS: ftp: loaded support on port[0] = 21
hid-generic 0000:0000:0000.005E: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.005E: unknown main item tag 0x0
hid-generic 0000:0000:0000.005E: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
IPVS: ftp: loaded support on port[0] = 21
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: unknown main item tag 0x0
hid-generic 0000:0000:0000.005F: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
IPVS: ftp: loaded support on port[0] = 21
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: unknown main item tag 0x0
hid-generic 0000:0000:0000.0060: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: unknown main item tag 0x0
hid-generic 0000:0000:0000.0061: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
SELinux: duplicate or incompatible mount options
IPVS: ftp: loaded support on port[0] = 21
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: unknown main item tag 0x0
hid-generic 0000:0000:0000.0062: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
IPVS: ftp: loaded support on port[0] = 21
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
netlink: 268 bytes leftover after parsing attributes in process `syz-executor.0'.
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
netlink: 268 bytes leftover after parsing attributes in process `syz-executor.0'.
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
IPVS: ftp: loaded support on port[0] = 21
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
netlink: 'syz-executor.0': attribute type 3 has an invalid length.
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
netlink: 212 bytes leftover after parsing attributes in process `syz-executor.0'.
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: unknown main item tag 0x0
hid-generic 0000:0000:0000.0063: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
netlink: 'syz-executor.0': attribute type 3 has an invalid length.
netlink: 212 bytes leftover after parsing attributes in process `syz-executor.0'.
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: unknown main item tag 0x0
hid-generic 0000:0000:0000.0064: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
IPVS: ftp: loaded support on port[0] = 21
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
netlink: 'syz-executor.0': attribute type 3 has an invalid length.
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: unknown main item tag 0x0
hid-generic 0000:0000:0000.0065: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: unknown main item tag 0x0
hid-generic 0000:0000:0000.0066: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
IPVS: ftp: loaded support on port[0] = 21
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
netlink: 268 bytes leftover after parsing attributes in process `syz-executor.0'.
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
netlink: 268 bytes leftover after parsing attributes in process `syz-executor.0'.
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
netlink: 268 bytes leftover after parsing attributes in process `syz-executor.0'.
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
netlink: 268 bytes leftover after parsing attributes in process `syz-executor.0'.
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: unknown main item tag 0x0
hid-generic 0000:0000:0000.0067: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: unknown main item tag 0x0
hid-generic 0000:0000:0000.0068: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
SELinux: duplicate or incompatible mount options
IPVS: ftp: loaded support on port[0] = 21
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
netlink: 268 bytes leftover after parsing attributes in process `syz-executor.0'.
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
hid-generic 0000:0000:0000.0069: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.0069: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
netlink: 268 bytes leftover after parsing attributes in process `syz-executor.0'.
SELinux: duplicate or incompatible mount options
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
IPVS: ftp: loaded support on port[0] = 21
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
hid-generic 0000:0000:0000.006A: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006A: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
IPVS: ftp: loaded support on port[0] = 21
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: unknown main item tag 0x0
hid-generic 0000:0000:0000.006B: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
SELinux: duplicate or incompatible mount options
IPVS: ftp: loaded support on port[0] = 21
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
SELinux: duplicate or incompatible mount options
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: unknown main item tag 0x0
hid-generic 0000:0000:0000.006C: hidraw0: <UNKNOWN> HID v0.00 Device [syz1 ] on s�z͏DJ��
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0
hid-generic 0000:0000:0000.006D: unknown main item tag 0x0


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

syzbot

unread,
Nov 11, 2020, 11:10:27 AM11/11/20
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: 31acccdc Linux 4.19.157
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17942cbe500000
kernel config: https://syzkaller.appspot.com/x/.config?x=1f604e014c43fe09
dashboard link: https://syzkaller.appspot.com/bug?extid=9f57216a517eb79b590e
compiler: gcc (GCC) 10.1.0-syz 20200507
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=147f3b62500000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9f5721...@syzkaller.appspotmail.com

IPv6: ADDRCONF(NETDEV_UP): wlan1: link is not ready
wlan1: Created IBSS using preconfigured BSSID 50:50:50:50:50:50
wlan1: Creating new IBSS network, BSSID 50:50:50:50:50:50
======================================================
WARNING: possible circular locking dependency detected
4.19.157-syzkaller #0 Not tainted
------------------------------------------------------
IPv6: ADDRCONF(NETDEV_CHANGE): wlan1: link becomes ready
syz-executor.3/8146 is trying to acquire lock:
00000000525b88b6 (&qdisc_rx_lock){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
00000000525b88b6 (&qdisc_rx_lock){+.-.}, at: red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265

but task is already holding lock:
000000008b0daee6 ((&q->adapt_timer)){+.-.}, at: lockdep_copy_map include/linux/lockdep.h:168 [inline]
000000008b0daee6 ((&q->adapt_timer)){+.-.}, at: call_timer_fn+0xc9/0x700 kernel/time/timer.c:1328

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 ((&q->adapt_timer)){+.-.}:
red_destroy+0x15/0x60 net/sched/sch_red.c:182
qdisc_destroy+0x180/0x790 net/sched/sch_generic.c:983
red_change+0x514/0x1080 net/sched/sch_red.c:236
qdisc_change net/sched/sch_api.c:1239 [inline]
tc_modify_qdisc+0xf6a/0x1a80 net/sched/sch_api.c:1542
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4778
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2455
netlink_unicast_kernel net/netlink/af_netlink.c:1318 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1344
netlink_sendmsg+0x6bb/0xc40 net/netlink/af_netlink.c:1909
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:632
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2115
__sys_sendmsg net/socket.c:2153 [inline]
__do_sys_sendmsg net/socket.c:2162 [inline]
__se_sys_sendmsg net/socket.c:2160 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2160
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&qdisc_rx_lock){+.-.}:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265
call_timer_fn+0x177/0x700 kernel/time/timer.c:1338
expire_timers+0x243/0x4e0 kernel/time/timer.c:1375
__run_timers kernel/time/timer.c:1703 [inline]
run_timer_softirq+0x21c/0x670 kernel/time/timer.c:1716
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
invoke_softirq kernel/softirq.c:372 [inline]
irq_exit+0x215/0x260 kernel/softirq.c:412
exiting_irq arch/x86/include/asm/apic.h:544 [inline]
smp_apic_timer_interrupt+0x136/0x550 arch/x86/kernel/apic/apic.c:1094
apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:894
__might_fault+0x41/0x1d0 mm/memory.c:4724
_copy_from_user+0x29/0x130 lib/usercopy.c:10
copy_from_user include/linux/uaccess.h:147 [inline]
get_timespec64+0x75/0x120 kernel/time/time.c:862
__do_sys_nanosleep kernel/time/hrtimer.c:1771 [inline]
__se_sys_nanosleep kernel/time/hrtimer.c:1766 [inline]
__x64_sys_nanosleep+0xab/0x220 kernel/time/hrtimer.c:1766
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock((&q->adapt_timer));
lock(&qdisc_rx_lock);
lock((&q->adapt_timer));
lock(&qdisc_rx_lock);

*** DEADLOCK ***

1 lock held by syz-executor.3/8146:
#0: 000000008b0daee6 ((&q->adapt_timer)){+.-.}, at: lockdep_copy_map include/linux/lockdep.h:168 [inline]
#0: 000000008b0daee6 ((&q->adapt_timer)){+.-.}, at: call_timer_fn+0xc9/0x700 kernel/time/timer.c:1328

stack backtrace:
CPU: 1 PID: 8146 Comm: syz-executor.3 Not tainted 4.19.157-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
<IRQ>
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2fe lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1221
check_prev_add kernel/locking/lockdep.c:1865 [inline]
check_prevs_add kernel/locking/lockdep.c:1978 [inline]
validate_chain kernel/locking/lockdep.c:2419 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3415
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3907
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265
call_timer_fn+0x177/0x700 kernel/time/timer.c:1338
expire_timers+0x243/0x4e0 kernel/time/timer.c:1375
__run_timers kernel/time/timer.c:1703 [inline]
run_timer_softirq+0x21c/0x670 kernel/time/timer.c:1716
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
invoke_softirq kernel/softirq.c:372 [inline]
irq_exit+0x215/0x260 kernel/softirq.c:412
exiting_irq arch/x86/include/asm/apic.h:544 [inline]
smp_apic_timer_interrupt+0x136/0x550 arch/x86/kernel/apic/apic.c:1094
apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:894
</IRQ>
RIP: 0010:__might_fault+0x41/0x1d0 mm/memory.c:4724
Code: ff df 65 48 8b 1c 25 80 df 01 00 48 8d bb 18 14 00 00 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 6b 01 00 00 48 8b 9b 18 14 00 00 <48> c7 c7 ff ff ff ff 48 89 de e8 80 49 d7 ff 48 83 fb ff 74 49 e8
RSP: 0018:ffff8880932dfdb0 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff13
RAX: dffffc0000000000 RBX: 00007ffffffff000 RCX: ffffffff81007d01
RDX: 1ffff110160666b3 RSI: ffffffff818d872f RDI: ffff8880b0333598
RBP: ffffffff88b39820 R08: 0000000000000000 R09: 0000000000000223
R10: 0000000000000007 R11: 0000000000000000 R12: 000000000000000a
R13: ffff8880932dfe28 R14: 0000000000000000 R15: 0000000000000000
_copy_from_user+0x29/0x130 lib/usercopy.c:10
copy_from_user include/linux/uaccess.h:147 [inline]
get_timespec64+0x75/0x120 kernel/time/time.c:862
__do_sys_nanosleep kernel/time/hrtimer.c:1771 [inline]
__se_sys_nanosleep kernel/time/hrtimer.c:1766 [inline]
__x64_sys_nanosleep+0xab/0x220 kernel/time/hrtimer.c:1766
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x45c381
Code: 75 14 b8 23 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 34 cf fb ff c3 48 83 ec 08 e8 0a 47 00 00 48 89 04 24 b8 23 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 47 00 00 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007ffc5f2a3590 EFLAGS: 00000293 ORIG_RAX: 0000000000000023
RAX: ffffffffffffffda RBX: 00000000016a4300 RCX: 000000000045c381
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00007ffc5f2a35a0
RBP: 0000000000000041 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000000004
R13: 0000000000000000 R14: 0000000000000002 R15: 0000000000000000
ieee80211 phy12: Selected rate control algorithm 'minstrel_ht'
IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready
wlan0: Created IBSS using preconfigured BSSID 50:50:50:50:50:50
wlan0: Creating new IBSS network, BSSID 50:50:50:50:50:50
ieee80211 phy13: Selected rate control algorithm 'minstrel_ht'
IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
IPv6: ADDRCONF(NETDEV_UP): wlan1: link is not ready
wlan1: Created IBSS using preconfigured BSSID 50:50:50:50:50:50
wlan1: Creating new IBSS network, BSSID 50:50:50:50:50:50
IPv6: ADDRCONF(NETDEV_CHANGE): wlan1: link becomes ready

syzbot

unread,
Jan 12, 2021, 11:24:21 PM1/12/21
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: 675cc038 Linux 4.19.167
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1267c868d00000
kernel config: https://syzkaller.appspot.com/x/.config?x=25b512beb95e2b66
dashboard link: https://syzkaller.appspot.com/bug?extid=9f57216a517eb79b590e
compiler: gcc (GCC) 10.1.0-syz 20200507
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12458b1f500000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15f096e0d00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9f5721...@syzkaller.appspotmail.com

IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
======================================================
WARNING: possible circular locking dependency detected
4.19.167-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor237/10868 is trying to acquire lock:
00000000d5244787 (&qdisc_rx_lock){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
00000000d5244787 (&qdisc_rx_lock){+.-.}, at: red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265

but task is already holding lock:
000000005a88ab3f ((&q->adapt_timer)){+.-.}, at: lockdep_copy_map include/linux/lockdep.h:168 [inline]
000000005a88ab3f ((&q->adapt_timer)){+.-.}, at: call_timer_fn+0xc9/0x700 kernel/time/timer.c:1328

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 ((&q->adapt_timer)){+.-.}:
red_destroy+0x15/0x60 net/sched/sch_red.c:182
qdisc_destroy+0x180/0x790 net/sched/sch_generic.c:983
red_change+0x588/0x10b0 net/sched/sch_red.c:236
qdisc_change net/sched/sch_api.c:1239 [inline]
tc_modify_qdisc+0xf6a/0x1a80 net/sched/sch_api.c:1542
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4778
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2455
netlink_unicast_kernel net/netlink/af_netlink.c:1318 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1344
netlink_sendmsg+0x6bb/0xc40 net/netlink/af_netlink.c:1909
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:632
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2115
__sys_sendmsg net/socket.c:2153 [inline]
__do_sys_sendmsg net/socket.c:2162 [inline]
__se_sys_sendmsg net/socket.c:2160 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2160
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&qdisc_rx_lock){+.-.}:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265
call_timer_fn+0x177/0x700 kernel/time/timer.c:1338
expire_timers+0x243/0x4e0 kernel/time/timer.c:1375
__run_timers kernel/time/timer.c:1696 [inline]
run_timer_softirq+0x21c/0x670 kernel/time/timer.c:1709
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
invoke_softirq kernel/softirq.c:372 [inline]
irq_exit+0x215/0x260 kernel/softirq.c:412
exiting_irq arch/x86/include/asm/apic.h:545 [inline]
smp_apic_timer_interrupt+0x136/0x550 arch/x86/kernel/apic/apic.c:1094
apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:894
arch_local_irq_restore arch/x86/include/asm/paravirt.h:789 [inline]
console_unlock+0xe7b/0x1110 kernel/printk/printk.c:2468
vprintk_emit+0x2d1/0x740 kernel/printk/printk.c:1965
vprintk_func+0x79/0x17e kernel/printk/printk_safe.c:397
printk+0xba/0xed kernel/printk/printk.c:2040
__ip_vs_ftp_init.cold+0x5b/0x6a net/netfilter/ipvs/ip_vs_ftp.c:600
ops_init+0xb3/0x410 net/core/net_namespace.c:129
setup_net+0x2c2/0x720 net/core/net_namespace.c:315
copy_net_ns+0x1f7/0x335 net/core/net_namespace.c:438
create_new_namespaces+0x3f6/0x7b0 kernel/nsproxy.c:107
copy_namespaces+0x325/0x3c0 kernel/nsproxy.c:165
copy_process.part.0+0x3a59/0x8200 kernel/fork.c:1919
copy_process kernel/fork.c:1713 [inline]
_do_fork+0x22f/0xf30 kernel/fork.c:2228
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock((&q->adapt_timer));
lock(&qdisc_rx_lock);
lock((&q->adapt_timer));
lock(&qdisc_rx_lock);

*** DEADLOCK ***

3 locks held by syz-executor237/10868:
#0: 0000000050f5def9 (pernet_ops_rwsem){++++}, at: copy_net_ns+0x1d8/0x335 net/core/net_namespace.c:434
#1: 0000000012e72b14 (console_lock){+.+.}, at: vprintk_func+0x79/0x17e kernel/printk/printk_safe.c:397
#2: 000000005a88ab3f ((&q->adapt_timer)){+.-.}, at: lockdep_copy_map include/linux/lockdep.h:168 [inline]
#2: 000000005a88ab3f ((&q->adapt_timer)){+.-.}, at: call_timer_fn+0xc9/0x700 kernel/time/timer.c:1328

stack backtrace:
CPU: 1 PID: 10868 Comm: syz-executor237 Not tainted 4.19.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
<IRQ>
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2fe lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1221
check_prev_add kernel/locking/lockdep.c:1865 [inline]
check_prevs_add kernel/locking/lockdep.c:1978 [inline]
validate_chain kernel/locking/lockdep.c:2419 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3415
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3907
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
red_adaptative_timer+0x92/0x5c0 net/sched/sch_red.c:265
call_timer_fn+0x177/0x700 kernel/time/timer.c:1338
expire_timers+0x243/0x4e0 kernel/time/timer.c:1375
__run_timers kernel/time/timer.c:1696 [inline]
run_timer_softirq+0x21c/0x670 kernel/time/timer.c:1709
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
invoke_softirq kernel/softirq.c:372 [inline]
irq_exit+0x215/0x260 kernel/softirq.c:412
exiting_irq arch/x86/include/asm/apic.h:545 [inline]
smp_apic_timer_interrupt+0x136/0x550 arch/x86/kernel/apic/apic.c:1094
apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:894
</IRQ>
RIP: 0010:arch_local_irq_restore arch/x86/include/asm/paravirt.h:789 [inline]
RIP: 0010:console_unlock+0xe7b/0x1110 kernel/printk/printk.c:2468
Code: ff df 48 c1 e8 03 80 3c 08 00 0f 85 66 02 00 00 48 83 3d df eb a1 08 00 0f 84 9e 00 00 00 e8 4c 3c 15 00 48 8b 7c 24 30 57 9d <0f> 1f 44 00 00 e9 9b fc ff ff e8 36 3c 15 00 0f 0b e8 2f 3c 15 00
RSP: 0018:ffff8880849cf7f8 EFLAGS: 00000293 ORIG_RAX: ffffffffffffff13
RAX: ffff88809f3a6240 RBX: 0000000000000200 RCX: dffffc0000000000
RDX: 0000000000000000 RSI: ffffffff814f95b4 RDI: 0000000000000293
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff84546460
R13: 0000000000000039 R14: 0000000000000000 R15: ffffffff8a6da0b0
vprintk_emit+0x2d1/0x740 kernel/printk/printk.c:1965
vprintk_func+0x79/0x17e kernel/printk/printk_safe.c:397
printk+0xba/0xed kernel/printk/printk.c:2040
__ip_vs_ftp_init.cold+0x5b/0x6a net/netfilter/ipvs/ip_vs_ftp.c:600
ops_init+0xb3/0x410 net/core/net_namespace.c:129
setup_net+0x2c2/0x720 net/core/net_namespace.c:315
copy_net_ns+0x1f7/0x335 net/core/net_namespace.c:438
create_new_namespaces+0x3f6/0x7b0 kernel/nsproxy.c:107
copy_namespaces+0x325/0x3c0 kernel/nsproxy.c:165
copy_process.part.0+0x3a59/0x8200 kernel/fork.c:1919
copy_process kernel/fork.c:1713 [inline]
_do_fork+0x22f/0xf30 kernel/fork.c:2228
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x443689
Code: e8 0c e8 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb 06 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffc89eed828 EFLAGS: 00000246 ORIG_RAX: 0000000000000038
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000443689
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000070224100
RBP: 00007ffc89eed860 R08: 0000000000000000 R09: 0000000000000004
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000000a61d
R13: 0000000000000000 R14: 000000000000000c R15: 0000000000000004
Reply all
Reply to author
Forward
0 new messages