[v5.15] possible deadlock in __blockdev_direct_IO
1 view
Skip to first unread message
syzbot
Nov 11, 2024, 1:12:36 PM11/11/24
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 3c17fc483905 Linux 5.15.171
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=144db4e8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=b9c237e0cfa81702
dashboard link: https://syzkaller.appspot.com/bug?extid=95be16803df9182b82e6
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/97a9f2395dfd/disk-3c17fc48.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/c6a44ff13e98/vmlinux-3c17fc48.xz
kernel image: https://storage.googleapis.com/syzbot-assets/99e99ec0372d/bzImage-3c17fc48.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+95be16...@syzkaller.appspotmail.com
ntfs3: loop6: Different NTFS' sector size (2048) and media sector size (512)
ntfs3: loop6: Mark volume as dirty due to NTFS errors
======================================================
WARNING: possible circular locking dependency detected
5.15.171-syzkaller #0 Not tainted
------------------------------------------------------
syz.6.582/6552 is trying to acquire lock:
ffff88801faab928 (&mm->mmap_lock){++++}-{3:3}, at: get_current arch/x86/include/asm/current.h:15 [inline]
ffff88801faab928 (&mm->mmap_lock){++++}-{3:3}, at: internal_get_user_pages_fast+0x1c7/0x2810 mm/gup.c:2895
but task is already holding lock:
ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: do_blockdev_direct_IO fs/direct-io.c:1169 [inline]
ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: __blockdev_direct_IO+0x3db/0x4f40 fs/direct-io.c:1368
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ntfs_file_mmap+0x589/0x7e0 fs/ntfs3/file.c:401
call_mmap include/linux/fs.h:2179 [inline]
mmap_region+0x10e7/0x1670 mm/mmap.c:1791
do_mmap+0x78d/0xe00 mm/mmap.c:1575
vm_mmap_pgoff+0x1ca/0x2d0 mm/util.c:551
ksys_mmap_pgoff+0x559/0x780 mm/mmap.c:1624
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895
iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544
dio_refill_pages fs/direct-io.c:173 [inline]
dio_get_page fs/direct-io.c:217 [inline]
do_direct_IO fs/direct-io.c:938 [inline]
do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
__blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368
blockdev_direct_IO include/linux/fs.h:3310 [inline]
ntfs_direct_IO+0x193/0x360 fs/ntfs3/inode.c:798
generic_file_read_iter+0x28d/0x460 mm/filemap.c:2772
call_read_iter include/linux/fs.h:2168 [inline]
new_sync_read fs/read_write.c:404 [inline]
vfs_read+0xa93/0xe10 fs/read_write.c:485
ksys_read+0x1a2/0x2c0 fs/read_write.c:623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sb->s_type->i_mutex_key#29);
lock(&mm->mmap_lock);
lock(&sb->s_type->i_mutex_key#29);
lock(&mm->mmap_lock);
*** DEADLOCK ***
2 locks held by syz.6.582/6552:
#0: ffff888078c654f0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1057
#1: ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: do_blockdev_direct_IO fs/direct-io.c:1169 [inline]
#1: ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: __blockdev_direct_IO+0x3db/0x4f40 fs/direct-io.c:1368
stack backtrace:
CPU: 0 PID: 6552 Comm: syz.6.582 Not tainted 5.15.171-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895
iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544
dio_refill_pages fs/direct-io.c:173 [inline]
dio_get_page fs/direct-io.c:217 [inline]
do_direct_IO fs/direct-io.c:938 [inline]
do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
__blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368
blockdev_direct_IO include/linux/fs.h:3310 [inline]
ntfs_direct_IO+0x193/0x360 fs/ntfs3/inode.c:798
generic_file_read_iter+0x28d/0x460 mm/filemap.c:2772
call_read_iter include/linux/fs.h:2168 [inline]
new_sync_read fs/read_write.c:404 [inline]
vfs_read+0xa93/0xe10 fs/read_write.c:485
ksys_read+0x1a2/0x2c0 fs/read_write.c:623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fd0b24d2719
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd0b094a038 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 00007fd0b2689f80 RCX: 00007fd0b24d2719
RDX: 0000000000002000 RSI: 0000000020000000 RDI: 0000000000000004
RBP: 00007fd0b254539e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fd0b2689f80 R15: 00007ffd80538d38
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot found the following issue on:
HEAD commit: 3c17fc483905 Linux 5.15.171
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=144db4e8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=b9c237e0cfa81702
dashboard link: https://syzkaller.appspot.com/bug?extid=95be16803df9182b82e6
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/97a9f2395dfd/disk-3c17fc48.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/c6a44ff13e98/vmlinux-3c17fc48.xz
kernel image: https://storage.googleapis.com/syzbot-assets/99e99ec0372d/bzImage-3c17fc48.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+95be16...@syzkaller.appspotmail.com
ntfs3: loop6: Different NTFS' sector size (2048) and media sector size (512)
ntfs3: loop6: Mark volume as dirty due to NTFS errors
======================================================
WARNING: possible circular locking dependency detected
5.15.171-syzkaller #0 Not tainted
------------------------------------------------------
syz.6.582/6552 is trying to acquire lock:
ffff88801faab928 (&mm->mmap_lock){++++}-{3:3}, at: get_current arch/x86/include/asm/current.h:15 [inline]
ffff88801faab928 (&mm->mmap_lock){++++}-{3:3}, at: internal_get_user_pages_fast+0x1c7/0x2810 mm/gup.c:2895
but task is already holding lock:
ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: do_blockdev_direct_IO fs/direct-io.c:1169 [inline]
ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: __blockdev_direct_IO+0x3db/0x4f40 fs/direct-io.c:1368
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ntfs_file_mmap+0x589/0x7e0 fs/ntfs3/file.c:401
call_mmap include/linux/fs.h:2179 [inline]
mmap_region+0x10e7/0x1670 mm/mmap.c:1791
do_mmap+0x78d/0xe00 mm/mmap.c:1575
vm_mmap_pgoff+0x1ca/0x2d0 mm/util.c:551
ksys_mmap_pgoff+0x559/0x780 mm/mmap.c:1624
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895
iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544
dio_refill_pages fs/direct-io.c:173 [inline]
dio_get_page fs/direct-io.c:217 [inline]
do_direct_IO fs/direct-io.c:938 [inline]
do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
__blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368
blockdev_direct_IO include/linux/fs.h:3310 [inline]
ntfs_direct_IO+0x193/0x360 fs/ntfs3/inode.c:798
generic_file_read_iter+0x28d/0x460 mm/filemap.c:2772
call_read_iter include/linux/fs.h:2168 [inline]
new_sync_read fs/read_write.c:404 [inline]
vfs_read+0xa93/0xe10 fs/read_write.c:485
ksys_read+0x1a2/0x2c0 fs/read_write.c:623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sb->s_type->i_mutex_key#29);
lock(&mm->mmap_lock);
lock(&sb->s_type->i_mutex_key#29);
lock(&mm->mmap_lock);
*** DEADLOCK ***
2 locks held by syz.6.582/6552:
#0: ffff888078c654f0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1057
#1: ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: do_blockdev_direct_IO fs/direct-io.c:1169 [inline]
#1: ffff888062e3f240 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: __blockdev_direct_IO+0x3db/0x4f40 fs/direct-io.c:1368
stack backtrace:
CPU: 0 PID: 6552 Comm: syz.6.582 Not tainted 5.15.171-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895
iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544
dio_refill_pages fs/direct-io.c:173 [inline]
dio_get_page fs/direct-io.c:217 [inline]
do_direct_IO fs/direct-io.c:938 [inline]
do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
__blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368
blockdev_direct_IO include/linux/fs.h:3310 [inline]
ntfs_direct_IO+0x193/0x360 fs/ntfs3/inode.c:798
generic_file_read_iter+0x28d/0x460 mm/filemap.c:2772
call_read_iter include/linux/fs.h:2168 [inline]
new_sync_read fs/read_write.c:404 [inline]
vfs_read+0xa93/0xe10 fs/read_write.c:485
ksys_read+0x1a2/0x2c0 fs/read_write.c:623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fd0b24d2719
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd0b094a038 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 00007fd0b2689f80 RCX: 00007fd0b24d2719
RDX: 0000000000002000 RSI: 0000000020000000 RDI: 0000000000000004
RBP: 00007fd0b254539e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fd0b2689f80 R15: 00007ffd80538d38
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot
Jan 20, 2025, 2:09:27 AM1/20/25
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: 4735586da88e Linux 5.15.176
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16050964580000
kernel config: https://syzkaller.appspot.com/x/.config?x=8c3b695ffd9247a0
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10fc52b0580000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/44a9faa53b37/disk-4735586d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2e4ec21926b2/vmlinux-4735586d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f96f554b1d28/bzImage-4735586d.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/2b6e748157fe/mount_0.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+95be16...@syzkaller.appspotmail.com
------------------------------------------------------
syz-executor307/4160 is trying to acquire lock:
ffff88801746b928 (&mm->mmap_lock){++++}-{3:3}, at: get_current arch/x86/include/asm/current.h:15 [inline]
ffff88801746b928 (&mm->mmap_lock){++++}-{3:3}, at: internal_get_user_pages_fast+0x1c7/0x2810 mm/gup.c:2895
but task is already holding lock:
ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: do_blockdev_direct_IO fs/direct-io.c:1169 [inline]
ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: __blockdev_direct_IO+0x3db/0x4f40 fs/direct-io.c:1368
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}:
__mmap_region mm/mmap.c:1784 [inline]
mmap_region+0x1035/0x1870 mm/mmap.c:2921
do_mmap+0x78d/0xe00 mm/mmap.c:1574
vm_mmap_pgoff+0x1ca/0x2d0 mm/util.c:551
ksys_mmap_pgoff+0x559/0x780 mm/mmap.c:1623
lock(&mm->mmap_lock);
lock(&sb->s_type->i_mutex_key#15);
#0: ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#0: ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: do_blockdev_direct_IO fs/direct-io.c:1169 [inline]
#0: ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: __blockdev_direct_IO+0x3db/0x4f40 fs/direct-io.c:1368
stack backtrace:
CPU: 1 PID: 4160 Comm: syz-executor307 Not tainted 5.15.176-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc3040f258 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f9a36964739
RDX: 0000000000002000 RSI: 0000000020000000 RDI: 0000000000000005
RBP: 00007f9a369f7610
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
HEAD commit: 4735586da88e Linux 5.15.176
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16050964580000
kernel config: https://syzkaller.appspot.com/x/.config?x=8c3b695ffd9247a0
dashboard link: https://syzkaller.appspot.com/bug?extid=95be16803df9182b82e6
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10d839df980000
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10fc52b0580000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/44a9faa53b37/disk-4735586d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2e4ec21926b2/vmlinux-4735586d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f96f554b1d28/bzImage-4735586d.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/2b6e748157fe/mount_0.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+95be16...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.176-syzkaller #0 Not tainted
WARNING: possible circular locking dependency detected
------------------------------------------------------
syz-executor307/4160 is trying to acquire lock:
ffff88801746b928 (&mm->mmap_lock){++++}-{3:3}, at: get_current arch/x86/include/asm/current.h:15 [inline]
ffff88801746b928 (&mm->mmap_lock){++++}-{3:3}, at: internal_get_user_pages_fast+0x1c7/0x2810 mm/gup.c:2895
but task is already holding lock:
ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: do_blockdev_direct_IO fs/direct-io.c:1169 [inline]
ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: __blockdev_direct_IO+0x3db/0x4f40 fs/direct-io.c:1368
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ntfs_file_mmap+0x589/0x7e0 fs/ntfs3/file.c:401
call_mmap include/linux/fs.h:2179 [inline]
mmap_file+0x5a/0xb0 mm/util.c:1092
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ntfs_file_mmap+0x589/0x7e0 fs/ntfs3/file.c:401
call_mmap include/linux/fs.h:2179 [inline]
__mmap_region mm/mmap.c:1784 [inline]
mmap_region+0x1035/0x1870 mm/mmap.c:2921
do_mmap+0x78d/0xe00 mm/mmap.c:1574
vm_mmap_pgoff+0x1ca/0x2d0 mm/util.c:551
ksys_mmap_pgoff+0x559/0x780 mm/mmap.c:1623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895
iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544
dio_refill_pages fs/direct-io.c:173 [inline]
dio_get_page fs/direct-io.c:217 [inline]
do_direct_IO fs/direct-io.c:938 [inline]
do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
__blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368
blockdev_direct_IO include/linux/fs.h:3346 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895
iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544
dio_refill_pages fs/direct-io.c:173 [inline]
dio_get_page fs/direct-io.c:217 [inline]
do_direct_IO fs/direct-io.c:938 [inline]
do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
__blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368
ntfs_direct_IO+0x193/0x360 fs/ntfs3/inode.c:798
generic_file_read_iter+0x28d/0x460 mm/filemap.c:2772
call_read_iter include/linux/fs.h:2168 [inline]
new_sync_read fs/read_write.c:404 [inline]
vfs_read+0xa93/0xe10 fs/read_write.c:485
ksys_read+0x1a2/0x2c0 fs/read_write.c:623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sb->s_type->i_mutex_key#15);
generic_file_read_iter+0x28d/0x460 mm/filemap.c:2772
call_read_iter include/linux/fs.h:2168 [inline]
new_sync_read fs/read_write.c:404 [inline]
vfs_read+0xa93/0xe10 fs/read_write.c:485
ksys_read+0x1a2/0x2c0 fs/read_write.c:623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&mm->mmap_lock);
lock(&sb->s_type->i_mutex_key#15);
lock(&mm->mmap_lock);
*** DEADLOCK ***
1 lock held by syz-executor307/4160:
*** DEADLOCK ***
#0: ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#0: ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: do_blockdev_direct_IO fs/direct-io.c:1169 [inline]
#0: ffff88806fa803a0 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: __blockdev_direct_IO+0x3db/0x4f40 fs/direct-io.c:1368
stack backtrace:
CPU: 1 PID: 4160 Comm: syz-executor307 Not tainted 5.15.176-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895
iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544
dio_refill_pages fs/direct-io.c:173 [inline]
dio_get_page fs/direct-io.c:217 [inline]
do_direct_IO fs/direct-io.c:938 [inline]
do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
__blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368
blockdev_direct_IO include/linux/fs.h:3346 [inline]
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895
iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544
dio_refill_pages fs/direct-io.c:173 [inline]
dio_get_page fs/direct-io.c:217 [inline]
do_direct_IO fs/direct-io.c:938 [inline]
do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
__blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368
ntfs_direct_IO+0x193/0x360 fs/ntfs3/inode.c:798
generic_file_read_iter+0x28d/0x460 mm/filemap.c:2772
call_read_iter include/linux/fs.h:2168 [inline]
new_sync_read fs/read_write.c:404 [inline]
vfs_read+0xa93/0xe10 fs/read_write.c:485
ksys_read+0x1a2/0x2c0 fs/read_write.c:623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f9a36964739
generic_file_read_iter+0x28d/0x460 mm/filemap.c:2772
call_read_iter include/linux/fs.h:2168 [inline]
new_sync_read fs/read_write.c:404 [inline]
vfs_read+0xa93/0xe10 fs/read_write.c:485
ksys_read+0x1a2/0x2c0 fs/read_write.c:623
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc3040f258 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f9a36964739
RDX: 0000000000002000 RSI: 0000000020000000 RDI: 0000000000000005
RBP: 00007f9a369f7610
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
syzbot
Sep 21, 2025, 11:23:06 PM9/21/25
to syzkaller...@googlegroups.com
syzbot suspects this issue was fixed by commit:
commit 03b40bf5d0389ca23ae6857ee25789f0e0b47ce8
Author: Ye Bin <yeb...@huawei.com>
Date: Mon Aug 11 14:18:30 2025 +0000
fs/buffer: fix use-after-free when call bh_read() helper
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14695534580000
start commit: 4735586da88e Linux 5.15.176
git tree: linux-5.15.y
#syz fix: fs/buffer: fix use-after-free when call bh_read() helper
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
commit 03b40bf5d0389ca23ae6857ee25789f0e0b47ce8
Author: Ye Bin <yeb...@huawei.com>
Date: Mon Aug 11 14:18:30 2025 +0000
fs/buffer: fix use-after-free when call bh_read() helper
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14695534580000
start commit: 4735586da88e Linux 5.15.176
git tree: linux-5.15.y
kernel config: https://syzkaller.appspot.com/x/.config?x=8c3b695ffd9247a0
dashboard link: https://syzkaller.appspot.com/bug?extid=95be16803df9182b82e6
dashboard link: https://syzkaller.appspot.com/bug?extid=95be16803df9182b82e6
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10d839df980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10fc52b0580000
If the result looks correct, please mark the issue as fixed by replying with:
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10fc52b0580000
#syz fix: fs/buffer: fix use-after-free when call bh_read() helper
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
Reply all
Reply to author
Forward
0 new messages