possible deadlock in dev_uc_sync_multiple (3)

8 views
Skip to first unread message

syzbot

unread,
Aug 7, 2022, 8:40:27 PM8/7/22
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12c53751080000
kernel config: https://syzkaller.appspot.com/x/.config?x=9b9277b418617afe
dashboard link: https://syzkaller.appspot.com/bug?extid=6504b577549187cc7512
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6504b5...@syzkaller.appspotmail.com

8021q: adding VLAN 0 to HW filter on device team0
bond0: Enslaving team0 as an active interface with an up link
netlink: 'syz-executor.0': attribute type 10 has an invalid length.
8021q: adding VLAN 0 to HW filter on device team0
======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/5448 is trying to acquire lock:
00000000651d568e (&vlan_netdev_addr_lock_key#2/2){+...}, at: netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
00000000651d568e (&vlan_netdev_addr_lock_key#2/2){+...}, at: dev_uc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:574

but task is already holding lock:
00000000aeeba7ef (&dev_addr_list_lock_key#2/1){+...}, at: netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
00000000aeeba7ef (&dev_addr_list_lock_key#2/1){+...}, at: dev_mc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:795

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&dev_addr_list_lock_key#2/1){+...}:
netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
dev_mc_sync+0x11a/0x1e0 net/core/dev_addr_lists.c:765
vlan_dev_set_rx_mode+0x38/0x80 net/8021q/vlan_dev.c:488
__dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
dev_set_rx_mode net/core/dev.c:7607 [inline]
__dev_open+0x26c/0x3a0 net/core/dev.c:1410
__dev_change_flags+0x501/0x660 net/core/dev.c:7679
dev_change_flags+0x7e/0x140 net/core/dev.c:7748
vlan_device_event+0x1429/0x1e40 net/8021q/vlan.c:463
notifier_call_chain+0xc0/0x230 kernel/notifier.c:93
call_netdevice_notifiers net/core/dev.c:1762 [inline]
__dev_notify_flags+0x110/0x2b0 net/core/dev.c:7717
dev_change_flags+0xf0/0x140 net/core/dev.c:7753
do_setlink+0x14f1/0x3540 net/core/rtnetlink.c:2449
rtnl_group_changelink net/core/rtnetlink.c:2925 [inline]
rtnl_newlink+0xbc9/0x15c0 net/core/rtnetlink.c:3083
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2463
netlink_unicast_kernel net/netlink/af_netlink.c:1325 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1351
netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&vlan_netdev_addr_lock_key#2/2){+...}:
_raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:354
netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
dev_uc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:574
team_set_rx_mode+0xce/0x230 drivers/net/team/team.c:1788
__dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
dev_mc_sync_multiple+0x193/0x1e0 net/core/dev_addr_lists.c:798
bond_enslave+0x3d38/0x5250 drivers/net/bonding/bond_main.c:1767
do_set_master+0x1c8/0x220 net/core/rtnetlink.c:2321
do_setlink+0x7ec/0x3540 net/core/rtnetlink.c:2455
rtnl_newlink+0xda9/0x15c0 net/core/rtnetlink.c:3077
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2463
netlink_unicast_kernel net/netlink/af_netlink.c:1325 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1351
netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&dev_addr_list_lock_key#2/1);
lock(&vlan_netdev_addr_lock_key#2/2);
lock(&dev_addr_list_lock_key#2/1);
lock(&vlan_netdev_addr_lock_key#2/2);

*** DEADLOCK ***

4 locks held by syz-executor.0/5448:
#0: 00000000dabff89c (rtnl_mutex){+.+.}, at: rtnl_lock net/core/rtnetlink.c:77 [inline]
#0: 00000000dabff89c (rtnl_mutex){+.+.}, at: rtnetlink_rcv_msg+0x3fe/0xb80 net/core/rtnetlink.c:4779
#1: 000000001dcc932c (&dev_addr_list_lock_key){+...}, at: spin_lock_bh include/linux/spinlock.h:334 [inline]
#1: 000000001dcc932c (&dev_addr_list_lock_key){+...}, at: netif_addr_lock_bh include/linux/netdevice.h:4012 [inline]
#1: 000000001dcc932c (&dev_addr_list_lock_key){+...}, at: bond_enslave+0x3d2d/0x5250 drivers/net/bonding/bond_main.c:1766
#2: 00000000aeeba7ef (&dev_addr_list_lock_key#2/1){+...}, at: netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
#2: 00000000aeeba7ef (&dev_addr_list_lock_key#2/1){+...}, at: dev_mc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:795
#3: 000000007ef9ff0c (rcu_read_lock){....}, at: team_set_rx_mode+0x0/0x230 drivers/net/team/team.c:509

stack backtrace:
CPU: 0 PID: 5448 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
check_prev_add kernel/locking/lockdep.c:1866 [inline]
check_prevs_add kernel/locking/lockdep.c:1979 [inline]
validate_chain kernel/locking/lockdep.c:2420 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
_raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:354
netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
dev_uc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:574
team_set_rx_mode+0xce/0x230 drivers/net/team/team.c:1788
__dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
dev_mc_sync_multiple+0x193/0x1e0 net/core/dev_addr_lists.c:798
bond_enslave+0x3d38/0x5250 drivers/net/bonding/bond_main.c:1767
do_set_master+0x1c8/0x220 net/core/rtnetlink.c:2321
do_setlink+0x7ec/0x3540 net/core/rtnetlink.c:2455
rtnl_newlink+0xda9/0x15c0 net/core/rtnetlink.c:3077
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2463
netlink_unicast_kernel net/netlink/af_netlink.c:1325 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1351
netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f8ec3ec4279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8ec2839168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f8ec3fd6f80 RCX: 00007f8ec3ec4279
RDX: 0000000000000000 RSI: 0000000020000600 RDI: 0000000000000003
RBP: 00007f8ec3f1e189 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffff26573ef R14: 00007f8ec2839300 R15: 0000000000022000
bond0: Enslaving team0 as an active interface with an up link
netlink: 'syz-executor.5': attribute type 10 has an invalid length.
bond0: Releasing backup interface team0
bridge0: port 3(team0) entered blocking state
bridge0: port 3(team0) entered disabled state
device team0 entered promiscuous mode
device team_slave_0 entered promiscuous mode
device team_slave_1 entered promiscuous mode
netlink: 'syz-executor.0': attribute type 10 has an invalid length.
bond0: Releasing backup interface team0
bridge0: port 3(team0) entered blocking state
bridge0: port 3(team0) entered disabled state
device team0 entered promiscuous mode
device team_slave_0 entered promiscuous mode
device team_slave_1 entered promiscuous mode
device vlan2 entered promiscuous mode
device batadv0 entered promiscuous mode
base_sock_release(00000000a8a934d0) sk=000000009fbcdec9
base_sock_release(0000000098d287ff) sk=00000000d46e465d
base_sock_release(00000000bee51bf8) sk=000000005237a5a9
nla_parse: 37 callbacks suppressed
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 10 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.4'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.2'.
base_sock_release(00000000eec07ffa) sk=00000000e0e247b3
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.4'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.4'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.3'.
batman_adv: batadv0: Interface deactivated: batadv_slave_0
batman_adv: batadv0: Removing interface: batadv_slave_0
batman_adv: batadv0: Interface deactivated: batadv_slave_1
batman_adv: batadv0: Removing interface: batadv_slave_1
device team0 left promiscuous mode
device team_slave_0 left promiscuous mode
device team_slave_1 left promiscuous mode
bridge0: port 4(team0) entered disabled state
device batadv0 left promiscuous mode
bridge0: port 3(batadv0) entered disabled state
device bridge_slave_1 left promiscuous mode
bridge0: port 2(bridge_slave_1) entered disabled state
device bridge_slave_0 left promiscuous mode
bridge0: port 1(bridge_slave_0) entered disabled state
device veth1_macvtap left promiscuous mode
device veth0_macvtap left promiscuous mode
device veth1_vlan left promiscuous mode
device veth0_vlan left promiscuous mode
bond15 (unregistering): Released all slaves
bond14 (unregistering): Released all slaves
bond13 (unregistering): Released all slaves
can: notifier: receive list not found for dev dvmrp1
bond0 (unregistering): Releasing backup interface bridge1
bond12 (unregistering): Released all slaves
bond11 (unregistering): Released all slaves
bond10 (unregistering): Released all slaves
bond9 (unregistering): Released all slaves
bond8 (unregistering): Released all slaves
bond7 (unregistering): Released all slaves
bond6 (unregistering): Released all slaves
bond5 (unregistering): Released all slaves
bond4 (unregistering): Released all slaves
bond3 (unregistering): Released all slaves
bond2 (unregistering): Released all slaves
bond1 (unregistering): Released all slaves
device hsr_slave_1 left promiscuous mode
device hsr_slave_0 left promiscuous mode
team0 (unregistering): Port device team_slave_1 removed
team0 (unregistering): Port device team_slave_0 removed
bond0 (unregistering): Releasing backup interface bond_slave_1
bond0 (unregistering): Releasing backup interface bond_slave_0
bond0 (unregistering): Released all slaves
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 6032 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc_node mm/slab.c:3304 [inline]
kmem_cache_alloc_node+0x245/0x3b0 mm/slab.c:3647
__alloc_skb+0x71/0x560 net/core/skbuff.c:193
alloc_skb include/linux/skbuff.h:995 [inline]
netlink_alloc_large_skb net/netlink/af_netlink.c:1197 [inline]
netlink_sendmsg+0x9f6/0xc50 net/netlink/af_netlink.c:1892
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fa0074bd279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa005e32168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fa0075cff80 RCX: 00007fa0074bd279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007fa005e321d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffdaa2daacf R14: 00007fa005e32300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 6050 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc_node mm/slab.c:3304 [inline]
kmem_cache_alloc_node_trace+0x244/0x3b0 mm/slab.c:3666
__do_kmalloc_node mm/slab.c:3688 [inline]
__kmalloc_node_track_caller+0x38/0x70 mm/slab.c:3703
__kmalloc_reserve net/core/skbuff.c:137 [inline]
__alloc_skb+0xae/0x560 net/core/skbuff.c:205
alloc_skb include/linux/skbuff.h:995 [inline]
netlink_alloc_large_skb net/netlink/af_netlink.c:1197 [inline]
netlink_sendmsg+0x9f6/0xc50 net/netlink/af_netlink.c:1892
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fa0074bd279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa005e32168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fa0075cff80 RCX: 00007fa0074bd279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007fa005e321d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffdaa2daacf R14: 00007fa005e32300 R15: 0000000000022000
nla_parse: 167 callbacks suppressed
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 56 bytes leftover after parsing attributes in process `syz-executor.3'.
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
netlink: 22 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.4'.
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 6077 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
netlink: 56 bytes leftover after parsing attributes in process `syz-executor.3'.
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
netlink: 23 bytes leftover after parsing attributes in process `syz-executor.3'.
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc mm/slab.c:3383 [inline]
kmem_cache_alloc+0x3f/0x370 mm/slab.c:3557
skb_clone+0x151/0x3d0 net/core/skbuff.c:1293
__netlink_deliver_tap_skb net/netlink/af_netlink.c:296 [inline]
__netlink_deliver_tap net/netlink/af_netlink.c:321 [inline]
netlink_deliver_tap+0x955/0xb00 net/netlink/af_netlink.c:334
netlink_deliver_tap_kernel net/netlink/af_netlink.c:343 [inline]
netlink_unicast_kernel net/netlink/af_netlink.c:1324 [inline]
netlink_unicast+0x545/0x690 net/netlink/af_netlink.c:1351
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.4'.
netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
netlink: 56 bytes leftover after parsing attributes in process `syz-executor.3'.
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 28 bytes leftover after parsing attributes in process `syz-executor.4'.
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fa0074bd279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa005e32168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fa0075cff80 RCX: 00007fa0074bd279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007fa005e321d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffdaa2daacf R14: 00007fa005e32300 R15: 0000000000022000
CPU: 1 PID: 6079 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc_node mm/slab.c:3304 [inline]
kmem_cache_alloc_node+0x245/0x3b0 mm/slab.c:3647
__alloc_skb+0x71/0x560 net/core/skbuff.c:193
alloc_skb include/linux/skbuff.h:995 [inline]
netlink_alloc_large_skb net/netlink/af_netlink.c:1197 [inline]
netlink_sendmsg+0x9f6/0xc50 net/netlink/af_netlink.c:1892
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f8ec3ec4279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8ec2839168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f8ec3fd6f80 RCX: 00007f8ec3ec4279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007f8ec28391d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffff26573ef R14: 00007f8ec2839300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 1 PID: 6106 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc_node mm/slab.c:3304 [inline]
kmem_cache_alloc_node_trace+0x244/0x3b0 mm/slab.c:3666
__do_kmalloc_node mm/slab.c:3688 [inline]
__kmalloc_node_track_caller+0x38/0x70 mm/slab.c:3703
__kmalloc_reserve net/core/skbuff.c:137 [inline]
__alloc_skb+0xae/0x560 net/core/skbuff.c:205
alloc_skb include/linux/skbuff.h:995 [inline]
netlink_alloc_large_skb net/netlink/af_netlink.c:1197 [inline]
netlink_sendmsg+0x9f6/0xc50 net/netlink/af_netlink.c:1892
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f8ec3ec4279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8ec2839168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f8ec3fd6f80 RCX: 00007f8ec3ec4279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007f8ec28391d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffff26573ef R14: 00007f8ec2839300 R15: 0000000000022000
CPU: 1 PID: 6107 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc mm/slab.c:3383 [inline]
__do_kmalloc mm/slab.c:3725 [inline]
__kmalloc+0x2ab/0x3c0 mm/slab.c:3736
kmalloc include/linux/slab.h:520 [inline]
kzalloc include/linux/slab.h:709 [inline]
tcf_idr_create+0x5b/0x5e0 net/sched/act_api.c:361
tcf_skbmod_init+0x54b/0xd30 net/sched/act_skbmod.c:149
tcf_action_init_1+0xa06/0xcd0 net/sched/act_api.c:870
tcf_action_init+0x26e/0x3b0 net/sched/act_api.c:936
tcf_action_add+0xd9/0x360 net/sched/act_api.c:1317
tc_ctl_action+0x327/0x410 net/sched/act_api.c:1372
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2463
netlink_unicast_kernel net/netlink/af_netlink.c:1325 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1351
netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fa0074bd279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa005e32168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fa0075cff80 RCX: 00007fa0074bd279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007fa005e321d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffdaa2daacf R14: 00007fa005e32300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 6121 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc mm/slab.c:3383 [inline]
kmem_cache_alloc+0x3f/0x370 mm/slab.c:3557
skb_clone+0x151/0x3d0 net/core/skbuff.c:1293
__netlink_deliver_tap_skb net/netlink/af_netlink.c:296 [inline]
__netlink_deliver_tap net/netlink/af_netlink.c:321 [inline]
netlink_deliver_tap+0x955/0xb00 net/netlink/af_netlink.c:334
netlink_deliver_tap_kernel net/netlink/af_netlink.c:343 [inline]
netlink_unicast_kernel net/netlink/af_netlink.c:1324 [inline]
netlink_unicast+0x545/0x690 net/netlink/af_netlink.c:1351
netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f8ec3ec4279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8ec2839168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f8ec3fd6f80 RCX: 00007f8ec3ec4279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007f8ec28391d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffff26573ef R14: 00007f8ec2839300 R15: 0000000000022000
CPU: 1 PID: 6128 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc mm/slab.c:3383 [inline]
kmem_cache_alloc_trace+0x284/0x380 mm/slab.c:3623
kmalloc include/linux/slab.h:515 [inline]
kzalloc include/linux/slab.h:709 [inline]
tcf_skbmod_init+0x5be/0xd30 net/sched/act_skbmod.c:164
tcf_action_init_1+0xa06/0xcd0 net/sched/act_api.c:870
tcf_action_init+0x26e/0x3b0 net/sched/act_api.c:936
tcf_action_add+0xd9/0x360 net/sched/act_api.c:1317
tc_ctl_action+0x327/0x410 net/sched/act_api.c:1372
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2463
netlink_unicast_kernel net/netlink/af_netlink.c:1325 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1351
netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fa0074bd279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa005e32168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fa0075cff80 RCX: 00007fa0074bd279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007fa005e321d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffdaa2daacf R14: 00007fa005e32300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 6141 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc_node mm/slab.c:3304 [inline]
kmem_cache_alloc_node+0x245/0x3b0 mm/slab.c:3647
__alloc_skb+0x71/0x560 net/core/skbuff.c:193
alloc_skb include/linux/skbuff.h:995 [inline]
tcf_add_notify net/sched/act_api.c:1289 [inline]
tcf_action_add+0x198/0x360 net/sched/act_api.c:1325
tc_ctl_action+0x327/0x410 net/sched/act_api.c:1372
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2463
netlink_unicast_kernel net/netlink/af_netlink.c:1325 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1351
netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:651 [inline]
sock_sendmsg+0xc3/0x120 net/socket.c:661
___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
__sys_sendmsg net/socket.c:2265 [inline]
__do_sys_sendmsg net/socket.c:2274 [inline]
__se_sys_sendmsg net/socket.c:2272 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fa0074bd279
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa005e32168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fa0075cff80 RCX: 00007fa0074bd279
RDX: 0000000000000000 RSI: 0000000020005000 RDI: 0000000000000003
RBP: 00007fa005e321d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffdaa2daacf R14: 00007fa005e32300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
CPU: 0 PID: 6148 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
fail_dump lib/fault-inject.c:51 [inline]
should_fail.cold+0xa/0xf lib/fault-inject.c:149
__should_failslab+0x115/0x180 mm/failslab.c:32
should_failslab+0x5/0x10 mm/slab_common.c:1590
slab_pre_alloc_hook mm/slab.h:424 [inline]
slab_alloc mm/slab.c:3383 [inline]
__do_kmalloc mm/slab.c:3725 [inline]
__kmalloc+0x2ab/0x3c0 mm/slab.c:3736
kmalloc include/linux/slab.h:520 [inline]
kzalloc include/linux/slab.h:709 [inline]
tcf_idr_create+0x5b/0x5e0 net/sched/act_api.c:361
tcf_skbmod_init+0x54b/0xd30 net/sched/act_skbmod.c:149
tcf_action_init_1+0xa06/0xcd0 net/sched/act_api.c:870
tcf_action_init+0x26e/0x3b0 net/sched/act_api.c:936
tcf_action_add+0xd9/0x360 net/sched/act_api.c:1317
tc_ctl_action+0x327/0x410 net/sched/act_api.c:1372
rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

syzbot

unread,
Oct 29, 2022, 6:02:43 PM10/29/22
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=138fc5ce880000
kernel config: https://syzkaller.appspot.com/x/.config?x=9b9277b418617afe
dashboard link: https://syzkaller.appspot.com/bug?extid=6504b577549187cc7512
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16beab22880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=169863ce880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98c0bdb4abb3/disk-3f8a27f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ea228ff02669/vmlinux-3f8a27f9.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6504b5...@syzkaller.appspotmail.com

8021q: adding VLAN 0 to HW filter on device bond2
bond1: Enslaving vlan1 as an active interface with an up link
IPv6: ADDRCONF(NETDEV_CHANGE): bond1: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): vlan0: link becomes ready
============================================
WARNING: possible recursive locking detected
4.19.211-syzkaller #0 Not tainted
--------------------------------------------
kworker/1:0/19 is trying to acquire lock:
00000000a85d965e (&vlan_netdev_addr_lock_key/1){+...}, at: netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
00000000a85d965e (&vlan_netdev_addr_lock_key/1){+...}, at: dev_uc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:574

but task is already holding lock:
00000000360c7177 (&vlan_netdev_addr_lock_key/1){+...}, at: spin_lock_bh include/linux/spinlock.h:334 [inline]
00000000360c7177 (&vlan_netdev_addr_lock_key/1){+...}, at: netif_addr_lock_bh include/linux/netdevice.h:4012 [inline]
00000000360c7177 (&vlan_netdev_addr_lock_key/1){+...}, at: __dev_mc_add net/core/dev_addr_lists.c:669 [inline]
00000000360c7177 (&vlan_netdev_addr_lock_key/1){+...}, at: dev_mc_add+0x1f/0xb0 net/core/dev_addr_lists.c:687

other info that might help us debug this:
Possible unsafe locking scenario:

CPU0
----
lock(&vlan_netdev_addr_lock_key/1);
lock(&vlan_netdev_addr_lock_key/1);

*** DEADLOCK ***

May be due to missing lock nesting notation

7 locks held by kworker/1:0/19:
#0: 0000000029972925 ((wq_completion)"%s"("ipv6_addrconf")){+.+.}, at: process_one_work+0x767/0x1570 kernel/workqueue.c:2124
#1: 0000000059397c77 ((work_completion)(&(&ifa->dad_work)->work)){+.+.}, at: process_one_work+0x79c/0x1570 kernel/workqueue.c:2128
#2: 0000000012b85e13 (rtnl_mutex){+.+.}, at: addrconf_dad_work+0x9c/0x10a0 net/ipv6/addrconf.c:3989
#3: 00000000e221e088 (&(&mc->mca_lock)->rlock){+.-.}, at: spin_lock_bh include/linux/spinlock.h:334 [inline]
#3: 00000000e221e088 (&(&mc->mca_lock)->rlock){+.-.}, at: igmp6_group_added+0x154/0x5d0 net/ipv6/mcast.c:672
#4: 00000000360c7177 (&vlan_netdev_addr_lock_key/1){+...}, at: spin_lock_bh include/linux/spinlock.h:334 [inline]
#4: 00000000360c7177 (&vlan_netdev_addr_lock_key/1){+...}, at: netif_addr_lock_bh include/linux/netdevice.h:4012 [inline]
#4: 00000000360c7177 (&vlan_netdev_addr_lock_key/1){+...}, at: __dev_mc_add net/core/dev_addr_lists.c:669 [inline]
#4: 00000000360c7177 (&vlan_netdev_addr_lock_key/1){+...}, at: dev_mc_add+0x1f/0xb0 net/core/dev_addr_lists.c:687
#5: 00000000e3955c7f (&dev_addr_list_lock_key/3){+...}, at: netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
#5: 00000000e3955c7f (&dev_addr_list_lock_key/3){+...}, at: dev_mc_sync+0x11a/0x1e0 net/core/dev_addr_lists.c:765
#6: 00000000e4aed9a9 (rcu_read_lock){....}, at: bond_set_rx_mode+0x0/0x490 drivers/net/bonding/bond_main.c:3481

stack backtrace:
CPU: 1 PID: 19 Comm: kworker/1:0 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022
Workqueue: ipv6_addrconf addrconf_dad_work
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_deadlock_bug kernel/locking/lockdep.c:1764 [inline]
check_deadlock kernel/locking/lockdep.c:1808 [inline]
validate_chain kernel/locking/lockdep.c:2404 [inline]
__lock_acquire.cold+0x121/0x57e kernel/locking/lockdep.c:3416
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
_raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:354
netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
dev_uc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:574
bond_set_rx_mode+0x1ae/0x490 drivers/net/bonding/bond_main.c:3646
__dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
dev_mc_sync+0x193/0x1e0 net/core/dev_addr_lists.c:768
vlan_dev_set_rx_mode+0x38/0x80 net/8021q/vlan_dev.c:488
__dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
__dev_mc_add net/core/dev_addr_lists.c:673 [inline]
dev_mc_add+0xa1/0xb0 net/core/dev_addr_lists.c:687
igmp6_group_added+0x4bc/0x5d0 net/ipv6/mcast.c:676
__ipv6_dev_mc_inc+0x728/0xa80 net/ipv6/mcast.c:935
addrconf_join_solict net/ipv6/addrconf.c:2101 [inline]
addrconf_join_solict net/ipv6/addrconf.c:2093 [inline]
addrconf_dad_begin net/ipv6/addrconf.c:3895 [inline]
addrconf_dad_work+0xb7d/0x10a0 net/ipv6/addrconf.c:4022
process_one_work+0x864/0x1570 kernel/workqueue.c:2153
worker_thread+0x64c/0x1130 kernel/workqueue.c:2296
kthread+0x33f/0x460 kernel/kthread.c:259
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond3 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond3: link is not ready
8021q: adding VLAN 0 to HW filter on device bond3
bond1: Enslaving vlan2 as an active interface with an up link
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond4 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond4: link is not ready
8021q: adding VLAN 0 to HW filter on device bond4
bond1: Enslaving vlan3 as an active interface with an up link
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond5 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond5: link is not ready
8021q: adding VLAN 0 to HW filter on device bond5
bond1: Enslaving vlan4 as an active interface with an up link
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond6 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond6: link is not ready
8021q: adding VLAN 0 to HW filter on device bond6
bond1: Enslaving vlan5 as an active interface with an up link
bond7 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond7: link is not ready
8021q: adding VLAN 0 to HW filter on device bond7
bond1: Enslaving vlan6 as an active interface with an up link
bond8 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond8: link is not ready
8021q: adding VLAN 0 to HW filter on device bond8
bond1: Enslaving vlan7 as an active interface with an up link
bond9 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond9: link is not ready
8021q: adding VLAN 0 to HW filter on device bond9
bond1: Enslaving vlan8 as an active interface with an up link
bond10 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond10: link is not ready
8021q: adding VLAN 0 to HW filter on device bond10
bond1: Enslaving vlan9 as an active interface with an up link
bond11 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond11: link is not ready
8021q: adding VLAN 0 to HW filter on device bond11
bond1: Enslaving vlan10 as an active interface with an up link
bond12 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond12: link is not ready
8021q: adding VLAN 0 to HW filter on device bond12
bond1: Enslaving vlan11 as an active interface with an up link
bond13 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond13: link is not ready
8021q: adding VLAN 0 to HW filter on device bond13
bond1: Enslaving vlan12 as an active interface with an up link
bond14 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond14: link is not ready
8021q: adding VLAN 0 to HW filter on device bond14
bond1: Enslaving vlan13 as an active interface with an up link
bond15 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond15: link is not ready
8021q: adding VLAN 0 to HW filter on device bond15
bond1: Enslaving vlan14 as an active interface with an up link
bond16 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond16: link is not ready
8021q: adding VLAN 0 to HW filter on device bond16
bond1: Enslaving vlan15 as an active interface with an up link
bond17 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond17: link is not ready
8021q: adding VLAN 0 to HW filter on device bond17
bond1: Enslaving vlan16 as an active interface with an up link
bond18 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond18: link is not ready
8021q: adding VLAN 0 to HW filter on device bond18
bond1: Enslaving vlan17 as an active interface with an up link
bond19 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond19: link is not ready
8021q: adding VLAN 0 to HW filter on device bond19
bond1: Enslaving vlan18 as an active interface with an up link
bond20 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond20: link is not ready
8021q: adding VLAN 0 to HW filter on device bond20
bond1: Enslaving vlan19 as an active interface with an up link
bond21 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond21: link is not ready
8021q: adding VLAN 0 to HW filter on device bond21
bond1: Enslaving vlan20 as an active interface with an up link
validate_nla: 30 callbacks suppressed
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond22 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond22: link is not ready
8021q: adding VLAN 0 to HW filter on device bond22
bond1: Enslaving vlan21 as an active interface with an up link
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond23 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond23: link is not ready
8021q: adding VLAN 0 to HW filter on device bond23
bond1: Enslaving vlan22 as an active interface with an up link
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond24 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond24: link is not ready
8021q: adding VLAN 0 to HW filter on device bond24
bond1: Enslaving vlan23 as an active interface with an up link
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond25 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond25: link is not ready
8021q: adding VLAN 0 to HW filter on device bond25
bond1: Enslaving vlan24 as an active interface with an up link
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond26 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond26: link is not ready
8021q: adding VLAN 0 to HW filter on device bond26
bond1: Enslaving vlan25 as an active interface with an up link
bond27 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond27: link is not ready
8021q: adding VLAN 0 to HW filter on device bond27
bond1: Enslaving vlan26 as an active interface with an up link
bond28 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond28: link is not ready
8021q: adding VLAN 0 to HW filter on device bond28
bond1: Enslaving vlan27 as an active interface with an up link
bond29 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond29: link is not ready
8021q: adding VLAN 0 to HW filter on device bond29
bond1: Enslaving vlan28 as an active interface with an up link
bond30 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond30: link is not ready
8021q: adding VLAN 0 to HW filter on device bond30
bond1: Enslaving vlan29 as an active interface with an up link
bond31 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond31: link is not ready
8021q: adding VLAN 0 to HW filter on device bond31
bond1: Enslaving vlan30 as an active interface with an up link
bond32 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond32: link is not ready
8021q: adding VLAN 0 to HW filter on device bond32
bond1: Enslaving vlan31 as an active interface with an up link
bond33 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond33: link is not ready
8021q: adding VLAN 0 to HW filter on device bond33
bond1: Enslaving vlan32 as an active interface with an up link
bond34 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond34: link is not ready
8021q: adding VLAN 0 to HW filter on device bond34
bond1: Enslaving vlan33 as an active interface with an up link
bond35 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond35: link is not ready
8021q: adding VLAN 0 to HW filter on device bond35
bond1: Enslaving vlan34 as an active interface with an up link
bond36 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond36: link is not ready
8021q: adding VLAN 0 to HW filter on device bond36
bond1: Enslaving vlan35 as an active interface with an up link
bond37 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond37: link is not ready
8021q: adding VLAN 0 to HW filter on device bond37
bond1: Enslaving vlan36 as an active interface with an up link
bond38 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond38: link is not ready
8021q: adding VLAN 0 to HW filter on device bond38
bond1: Enslaving vlan37 as an active interface with an up link
bond39 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond39: link is not ready
8021q: adding VLAN 0 to HW filter on device bond39
bond1: Enslaving vlan38 as an active interface with an up link
bond40 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond40: link is not ready
8021q: adding VLAN 0 to HW filter on device bond40
bond1: Enslaving vlan39 as an active interface with an up link
bond41 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond41: link is not ready
8021q: adding VLAN 0 to HW filter on device bond41
bond1: Enslaving vlan40 as an active interface with an up link
bond42 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond42: link is not ready
8021q: adding VLAN 0 to HW filter on device bond42
bond1: Enslaving vlan41 as an active interface with an up link
bond43 (uninitialized): Released all slaves
IPv6: ADDRCONF(NETDEV_UP): bond43: link is not ready
8021q: adding VLAN 0 to HW filter on device bond43
bond1: Enslaving vlan42 as an active interface with an up link
validate_nla: 34 callbacks suppressed
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond44 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.
IPv6: ADDRCONF(NETDEV_UP): bond44: link is not ready
8021q: adding VLAN 0 to HW filter on device bond44
bond1: Enslaving vlan43 as an active interface with an up link
netlink: 'syz-executor692': attribute type 1 has an invalid length.
bond45 (uninitialized): Released all slaves
netlink: 'syz-executor692': attribute type 1 has an invalid length.

Reply all
Reply to author
Forward
0 new messages