[v6.1] possible deadlock in wait_transaction_locked

0 views
Skip to first unread message

syzbot

unread,
5:36 AM (13 hours ago) 5:36 AM
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: bec0e10ee67e Linux 6.1.160
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=143e299a580000
kernel config: https://syzkaller.appspot.com/x/.config?x=31ea1cecaf34f0db
dashboard link: https://syzkaller.appspot.com/bug?extid=8f8d45b5fea78a80274f
compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/0c7c6a53ac77/disk-bec0e10e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/38567d4ccc5b/vmlinux-bec0e10e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/5f0a7945f428/Image-bec0e10e.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8f8d45...@syzkaller.appspotmail.com

ocfs2: Mounting device (7,4) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.1382/9919 is trying to acquire lock:
ffff0000d1c58990 (jbd2_handle){++++}-{0:0}, at: wait_transaction_locked+0x158/0x22c fs/jbd2/transaction.c:176

but task is already holding lock:
ffff0000f55038e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x374/0x6c4 fs/ocfs2/journal.c:374

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&journal->j_trans_barrier){.+.+}-{3:3}:
down_read+0x64/0x304 kernel/locking/rwsem.c:1520
ocfs2_start_trans+0x374/0x6c4 fs/ocfs2/journal.c:374
ocfs2_modify_bh+0xe4/0x43c fs/ocfs2/quota_local.c:101
ocfs2_local_read_info+0x102c/0x131c fs/ocfs2/quota_local.c:764
dquot_load_quota_sb+0x6c4/0xa24 fs/quota/dquot.c:2470
dquot_load_quota_inode+0x274/0x4e4 fs/quota/dquot.c:2507
ocfs2_enable_quotas+0x17c/0x3b4 fs/ocfs2/super.c:926
ocfs2_fill_super+0x3060/0x3e98 fs/ocfs2/super.c:1139
mount_bdev+0x264/0x358 fs/super.c:1443
ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186
legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
vfs_get_tree+0x90/0x274 fs/super.c:1573
do_new_mount+0x228/0x810 fs/namespace.c:3078
path_mount+0x5b4/0xe78 fs/namespace.c:3408
do_mount fs/namespace.c:3421 [inline]
__do_sys_mount fs/namespace.c:3629 [inline]
__se_sys_mount fs/namespace.c:3606 [inline]
__arm64_sys_mount+0x49c/0x584 fs/namespace.c:3606
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #4 (sb_internal#5){.+.+}-{0:0}:
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x20c/0x6c4 fs/ocfs2/journal.c:372
ocfs2_acquire_dquot+0x5bc/0xac4 fs/ocfs2/quota_global.c:848
dqget+0x654/0xccc fs/quota/dquot.c:988
__dquot_initialize+0x2d4/0xa80 fs/quota/dquot.c:1517
dquot_initialize+0x24/0x34 fs/quota/dquot.c:1579
ocfs2_get_init_inode+0x134/0x1a8 fs/ocfs2/namei.c:202
ocfs2_mknod+0x774/0x1f18 fs/ocfs2/namei.c:310
ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3490 [inline]
open_last_lookups fs/namei.c:3558 [inline]
path_openat+0x112c/0x2680 fs/namei.c:3788
do_filp_open+0x174/0x344 fs/namei.c:3818
do_sys_openat2+0x128/0x3d8 fs/open.c:1320
do_sys_open fs/open.c:1336 [inline]
__do_sys_openat fs/open.c:1352 [inline]
__se_sys_openat fs/open.c:1347 [inline]
__arm64_sys_openat+0x120/0x154 fs/open.c:1347
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
ocfs2_create_local_dquot+0x15c/0x1330 fs/ocfs2/quota_local.c:1224
ocfs2_acquire_dquot+0x6e8/0xac4 fs/ocfs2/quota_global.c:871
dqget+0x654/0xccc fs/quota/dquot.c:988
__dquot_initialize+0x2d4/0xa80 fs/quota/dquot.c:1517
dquot_initialize+0x24/0x34 fs/quota/dquot.c:1579
ocfs2_get_init_inode+0x134/0x1a8 fs/ocfs2/namei.c:202
ocfs2_mknod+0x774/0x1f18 fs/ocfs2/namei.c:310
ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3490 [inline]
open_last_lookups fs/namei.c:3558 [inline]
path_openat+0x112c/0x2680 fs/namei.c:3788
do_filp_open+0x174/0x344 fs/namei.c:3818
do_sys_openat2+0x128/0x3d8 fs/open.c:1320
do_sys_open fs/open.c:1336 [inline]
__do_sys_openat fs/open.c:1352 [inline]
__se_sys_openat fs/open.c:1347 [inline]
__arm64_sys_openat+0x120/0x154 fs/open.c:1347
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
__mutex_lock_common+0x190/0x1f38 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
dquot_commit+0x50/0x1c4 fs/quota/dquot.c:507
ext4_write_dquot+0x1b4/0x31c fs/ext4/super.c:6811
ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6888
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
__dquot_alloc_space+0x560/0xce8 fs/quota/dquot.c:1752
dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
dquot_alloc_space include/linux/quotaops.h:313 [inline]
dquot_alloc_block include/linux/quotaops.h:337 [inline]
ext4_mb_new_blocks+0xd30/0x435c fs/ext4/mballoc.c:5738
ext4_ext_map_blocks+0x1340/0x56c8 fs/ext4/extents.c:4340
ext4_map_blocks+0x860/0x1770 fs/ext4/inode.c:679
ext4_getblk+0x170/0x654 fs/ext4/inode.c:890
ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:946
ext4_append+0x238/0x474 fs/ext4/namei.c:83
ext4_init_new_dir+0x264/0x4f4 fs/ext4/namei.c:3030
ext4_mkdir+0x3c0/0xa2c fs/ext4/namei.c:3076
vfs_mkdir+0x314/0x4d4 fs/namei.c:4114
do_mkdirat+0x1b4/0x3e0 fs/namei.c:4139
__do_sys_mkdirat fs/namei.c:4154 [inline]
__se_sys_mkdirat fs/namei.c:4152 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4152
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&ei->i_data_sem){++++}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
ext4_map_blocks+0x7c4/0x1770 fs/ext4/inode.c:672
mpage_map_one_extent fs/ext4/inode.c:2434 [inline]
mpage_map_and_submit_extent fs/ext4/inode.c:2487 [inline]
ext4_writepages+0xd8c/0x284c fs/ext4/inode.c:2855
do_writepages+0x2c0/0x4fc mm/page-writeback.c:2491
__writeback_single_inode+0x164/0x157c fs/fs-writeback.c:1622
writeback_sb_inodes+0x824/0x1404 fs/fs-writeback.c:1913
__writeback_inodes_wb+0x110/0x394 fs/fs-writeback.c:1984
wb_writeback+0x414/0xfb0 fs/fs-writeback.c:2089
wb_check_background_flush fs/fs-writeback.c:2155 [inline]
wb_do_writeback fs/fs-writeback.c:2243 [inline]
wb_workfn+0xac0/0xd98 fs/fs-writeback.c:2270
process_one_work+0x7f4/0x13a8 kernel/workqueue.c:2292
worker_thread+0x8c8/0xfbc kernel/workqueue.c:2439
kthread+0x250/0x2d8 kernel/kthread.c:376
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:850

-> #0 (jbd2_handle){++++}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049
lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662
wait_transaction_locked+0x180/0x22c fs/jbd2/transaction.c:177
add_transaction_credits+0xfc/0xad4 fs/jbd2/transaction.c:-1
start_this_handle+0x4fc/0x122c fs/jbd2/transaction.c:422
jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:520
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
ocfs2_start_trans+0x380/0x6c4 fs/ocfs2/journal.c:376
ocfs2_write_begin_nolock+0x2078/0x3ab4 fs/ocfs2/aops.c:1770
__ocfs2_page_mkwrite fs/ocfs2/mmap.c:93 [inline]
ocfs2_page_mkwrite+0x5b4/0xbf4 fs/ocfs2/mmap.c:144
do_page_mkwrite+0x13c/0x358 mm/memory.c:3009
do_shared_fault mm/memory.c:4694 [inline]
do_fault mm/memory.c:4762 [inline]
handle_pte_fault mm/memory.c:5029 [inline]
__handle_mm_fault mm/memory.c:5171 [inline]
handle_mm_fault+0x121c/0x2ff0 mm/memory.c:5292
__do_page_fault arch/arm64/mm/fault.c:499 [inline]
do_page_fault+0x310/0x99c arch/arm64/mm/fault.c:583
do_translation_fault+0x94/0xc8 arch/arm64/mm/fault.c:667
do_mem_abort+0x70/0x194 arch/arm64/mm/fault.c:804
el1_abort+0x3c/0x5c arch/arm64/kernel/entry-common.c:367
el1h_64_sync_handler+0x80/0xcc arch/arm64/kernel/entry-common.c:427
el1h_64_sync+0x64/0x68 arch/arm64/kernel/entry.S:580
__arch_copy_to_user+0x194/0x234 arch/arm64/lib/copy_template.S:164
vfs_read+0x288/0x7c4 fs/read_write.c:468
ksys_pread64 fs/read_write.c:665 [inline]
__do_sys_pread64 fs/read_write.c:675 [inline]
__se_sys_pread64 fs/read_write.c:672 [inline]
__arm64_sys_pread64+0x170/0x200 fs/read_write.c:672
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
jbd2_handle --> sb_internal#5 --> &journal->j_trans_barrier

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&journal->j_trans_barrier);
lock(sb_internal#5);
lock(&journal->j_trans_barrier);
lock(jbd2_handle);

*** DEADLOCK ***

6 locks held by syz.4.1382/9919:
#0: ffff0000ddbac348 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
#0: ffff0000ddbac348 (&mm->mmap_lock){++++}-{3:3}, at: get_mmap_lock_carefully mm/memory.c:5320 [inline]
#0: ffff0000ddbac348 (&mm->mmap_lock){++++}-{3:3}, at: lock_mm_and_find_vma+0x38/0x2e8 mm/memory.c:5382
#1: ffff0000d8808558 (sb_pagefaults#2){.+.+}-{0:0}, at: do_page_mkwrite+0x13c/0x358 mm/memory.c:3009
#2: ffff00010396b120 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_page_mkwrite+0x328/0xbf4 fs/ocfs2/mmap.c:142
#3: ffff000103966d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#3: ffff000103966d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0xf8/0x278c fs/ocfs2/localalloc.c:635
#4: ffff0000d8808650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x2078/0x3ab4 fs/ocfs2/aops.c:1770
#5: ffff0000f55038e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x374/0x6c4 fs/ocfs2/journal.c:374

stack backtrace:
CPU: 1 PID: 9919 Comm: syz.4.1382 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/03/2025
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack+0x30/0x40 lib/dump_stack.c:88
dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106
dump_stack+0x1c/0x5c lib/dump_stack.c:113
print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048
check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049
lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662
wait_transaction_locked+0x180/0x22c fs/jbd2/transaction.c:177
add_transaction_credits+0xfc/0xad4 fs/jbd2/transaction.c:-1
start_this_handle+0x4fc/0x122c fs/jbd2/transaction.c:422
jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:520
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
ocfs2_start_trans+0x380/0x6c4 fs/ocfs2/journal.c:376
ocfs2_write_begin_nolock+0x2078/0x3ab4 fs/ocfs2/aops.c:1770
__ocfs2_page_mkwrite fs/ocfs2/mmap.c:93 [inline]
ocfs2_page_mkwrite+0x5b4/0xbf4 fs/ocfs2/mmap.c:144
do_page_mkwrite+0x13c/0x358 mm/memory.c:3009
do_shared_fault mm/memory.c:4694 [inline]
do_fault mm/memory.c:4762 [inline]
handle_pte_fault mm/memory.c:5029 [inline]
__handle_mm_fault mm/memory.c:5171 [inline]
handle_mm_fault+0x121c/0x2ff0 mm/memory.c:5292
__do_page_fault arch/arm64/mm/fault.c:499 [inline]
do_page_fault+0x310/0x99c arch/arm64/mm/fault.c:583
do_translation_fault+0x94/0xc8 arch/arm64/mm/fault.c:667
do_mem_abort+0x70/0x194 arch/arm64/mm/fault.c:804
el1_abort+0x3c/0x5c arch/arm64/kernel/entry-common.c:367
el1h_64_sync_handler+0x80/0xcc arch/arm64/kernel/entry-common.c:427
el1h_64_sync+0x64/0x68 arch/arm64/kernel/entry.S:580
__arch_copy_to_user+0x194/0x234 arch/arm64/lib/copy_template.S:164
vfs_read+0x288/0x7c4 fs/read_write.c:468
ksys_pread64 fs/read_write.c:665 [inline]
__do_sys_pread64 fs/read_write.c:675 [inline]
__se_sys_pread64 fs/read_write.c:672 [inline]
__arm64_sys_pread64+0x170/0x200 fs/read_write.c:672
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup
Reply all
Reply to author
Forward
0 new messages