[v6.1] possible deadlock in ocfs2_calc_xattr_init (2)

0 views
Skip to first unread message

syzbot

unread,
Sep 21, 2025, 4:44:29 AMSep 21
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 363a599da6d9 Linux 6.1.153
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1360bc7c580000
kernel config: https://syzkaller.appspot.com/x/.config?x=68aa5a3af1cb953a
dashboard link: https://syzkaller.appspot.com/bug?extid=cd2e0cbc5b21ab15c2ca
compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/b29518096962/disk-363a599d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8196e10b1ead/vmlinux-363a599d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d3123d59503a/Image-363a599d.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+cd2e0c...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.136/5411 is trying to acquire lock:
ffff0000fa9486f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_calc_xattr_init+0x1c4/0xb9c fs/ocfs2/xattr.c:631

but task is already holding lock:
ffff0000f59189c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff0000f59189c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x12c/0x3cd4 fs/ocfs2/suballoc.c:782

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
inode_lock include/linux/fs.h:758 [inline]
ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
ocfs2_evict_inode+0x1248/0x3d2c fs/ocfs2/inode.c:1219
evict+0x3c8/0x810 fs/inode.c:705
iput_final fs/inode.c:1834 [inline]
iput+0x764/0x7f4 fs/inode.c:1860
d_delete_notify include/linux/fsnotify.h:267 [inline]
vfs_rmdir+0x32c/0x438 fs/namei.c:4204
do_rmdir+0x238/0x50c fs/namei.c:4252
__do_sys_unlinkat fs/namei.c:4432 [inline]
__se_sys_unlinkat fs/namei.c:4426 [inline]
__arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4426
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
inode_lock include/linux/fs.h:758 [inline]
ocfs2_del_inode_from_orphan+0x100/0x608 fs/ocfs2/namei.c:2713
ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
ocfs2_dio_end_io+0x3f4/0xed8 fs/ocfs2/aops.c:2431
dio_complete+0x230/0x70c fs/direct-io.c:271
__blockdev_direct_IO+0x2780/0x318c fs/direct-io.c:1326
ocfs2_direct_IO+0x208/0x280 fs/ocfs2/aops.c:2468
generic_file_direct_write+0x31c/0x620 mm/filemap.c:3770
__generic_file_write_iter+0x1bc/0x37c mm/filemap.c:3930
ocfs2_file_write_iter+0x1300/0x1bf4 fs/ocfs2/file.c:2469
do_iter_readv_writev fs/read_write.c:-1 [inline]
do_iter_write+0x530/0x91c fs/read_write.c:861
vfs_iter_write+0x88/0xac fs/read_write.c:902
iter_file_splice_write+0x500/0xa18 fs/splice.c:685
do_splice_from fs/splice.c:763 [inline]
direct_splice_actor+0xe4/0x134 fs/splice.c:950
splice_direct_to_actor+0x3b4/0x978 fs/splice.c:896
do_splice_direct+0x158/0x244 fs/splice.c:1002
do_sendfile+0x458/0xc88 fs/read_write.c:1255
__do_sys_sendfile64 fs/read_write.c:1323 [inline]
__se_sys_sendfile64 fs/read_write.c:1309 [inline]
__arm64_sys_sendfile64+0x130/0x360 fs/read_write.c:1309
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&oi->ip_alloc_sem){++++}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
ocfs2_try_remove_refcount_tree+0xb4/0x2d8 fs/ocfs2/refcounttree.c:932
ocfs2_truncate_file+0xce8/0x149c fs/ocfs2/file.c:517
ocfs2_setattr+0x1234/0x18d4 fs/ocfs2/file.c:1212
notify_change+0xb0c/0xdcc fs/attr.c:499
do_truncate+0x178/0x1f0 fs/open.c:65
do_coredump+0x1940/0x1c4c fs/coredump.c:801
get_signal+0xdec/0x1310 kernel/signal.c:2857
do_signal arch/arm64/kernel/signal.c:1081 [inline]
do_notify_resume+0x290/0x2b0c arch/arm64/kernel/signal.c:1134
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
el0_da+0xb4/0x154 arch/arm64/kernel/entry-common.c:516
el0t_64_sync_handler+0x90/0xf0 arch/arm64/kernel/entry-common.c:658
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049
lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662
down_read+0x64/0x304 kernel/locking/rwsem.c:1520
ocfs2_calc_xattr_init+0x1c4/0xb9c fs/ocfs2/xattr.c:631
ocfs2_mknod+0xafc/0x1f18 fs/ocfs2/namei.c:330
ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3482 [inline]
open_last_lookups fs/namei.c:3550 [inline]
path_openat+0x112c/0x2680 fs/namei.c:3780
do_filp_open+0x174/0x344 fs/namei.c:3810
do_sys_openat2+0x128/0x3d8 fs/open.c:1318
do_sys_open fs/open.c:1334 [inline]
__do_sys_openat fs/open.c:1350 [inline]
__se_sys_openat fs/open.c:1345 [inline]
__arm64_sys_openat+0x120/0x154 fs/open.c:1345
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
&oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
lock(&oi->ip_xattr_sem);

*** DEADLOCK ***

3 locks held by syz.2.136/5411:
#0: ffff0000e65f2460 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393
#1: ffff0000fa9489c8 (&type->i_mutex_dir_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#1: ffff0000fa9489c8 (&type->i_mutex_dir_key#9){++++}-{3:3}, at: open_last_lookups fs/namei.c:3547 [inline]
#1: ffff0000fa9489c8 (&type->i_mutex_dir_key#9){++++}-{3:3}, at: path_openat+0x5e4/0x2680 fs/namei.c:3780
#2: ffff0000f59189c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#2: ffff0000f59189c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x12c/0x3cd4 fs/ocfs2/suballoc.c:782

stack backtrace:
CPU: 1 PID: 5411 Comm: syz.2.136 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/30/2025
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack+0x30/0x40 lib/dump_stack.c:88
dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106
dump_stack+0x1c/0x5c lib/dump_stack.c:113
print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048
check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049
lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662
down_read+0x64/0x304 kernel/locking/rwsem.c:1520
ocfs2_calc_xattr_init+0x1c4/0xb9c fs/ocfs2/xattr.c:631
ocfs2_mknod+0xafc/0x1f18 fs/ocfs2/namei.c:330
ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3482 [inline]
open_last_lookups fs/namei.c:3550 [inline]
path_openat+0x112c/0x2680 fs/namei.c:3780
do_filp_open+0x174/0x344 fs/namei.c:3810
do_sys_openat2+0x128/0x3d8 fs/open.c:1318
do_sys_open fs/open.c:1334 [inline]
__do_sys_openat fs/open.c:1350 [inline]
__se_sys_openat fs/open.c:1345 [inline]
__arm64_sys_openat+0x120/0x154 fs/open.c:1345
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup
Reply all
Reply to author
Forward
0 new messages