[syzbot] BUG: corrupted list in nfc_llcp_unregister_device

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 9e46a7996732 Add linux-next specific files for 20221125
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=149b558d880000
kernel config: https://syzkaller.appspot.com/x/.config?x=11e19c740a0b2926
dashboard link: https://syzkaller.appspot.com/bug?extid=81232c4a81a886e2b580
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/758d818cf966/disk-9e46a799.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f7c8696b40a5/vmlinux-9e46a799.xz
kernel image: https://storage.googleapis.com/syzbot-assets/810f9750b87f/bzImage-9e46a799.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+81232c...@syzkaller.appspotmail.com

list_del corruption. prev->next should be ffff888060ce7000, but was ffff88802a0ad000. (prev=ffffffff8e536240)
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:59!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 16622 Comm: syz-executor.5 Not tainted 6.1.0-rc6-next-20221125-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
RIP: 0010:__list_del_entry_valid.cold+0x12/0x72 lib/list_debug.c:59
Code: f0 ff 0f 0b 48 89 f1 48 c7 c7 60 96 a6 8a 4c 89 e6 e8 4b 29 f0 ff 0f 0b 4c 89 e1 48 89 ee 48 c7 c7 c0 98 a6 8a e8 37 29 f0 ff <0f> 0b 48 89 ee 48 c7 c7 a0 97 a6 8a e8 26 29 f0 ff 0f 0b 4c 89 e2
RSP: 0018:ffffc900151afd58 EFLAGS: 00010282
RAX: 000000000000006d RBX: 0000000000000001 RCX: 0000000000000000
RDX: ffff88801e7eba80 RSI: ffffffff8166001c RDI: fffff52002a35f9d
RBP: ffff888060ce7000 R08: 000000000000006d R09: 0000000000000000
R10: 0000000080000000 R11: 0000000000000000 R12: ffffffff8e536240
R13: ffff88801f3f3000 R14: ffff888060ce1000 R15: ffff888079d855f0
FS: 0000555556f57400(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f095d5ad988 CR3: 000000002155a000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__list_del_entry include/linux/list.h:134 [inline]
list_del include/linux/list.h:148 [inline]
local_release net/nfc/llcp_core.c:171 [inline]
kref_put include/linux/kref.h:65 [inline]
nfc_llcp_local_put net/nfc/llcp_core.c:181 [inline]
nfc_llcp_local_put net/nfc/llcp_core.c:176 [inline]
nfc_llcp_unregister_device+0xb8/0x260 net/nfc/llcp_core.c:1619
nfc_unregister_device+0x196/0x330 net/nfc/core.c:1179
virtual_ncidev_close+0x52/0xb0 drivers/nfc/virtual_ncidev.c:163
__fput+0x27c/0xa90 fs/file_table.c:320
task_work_run+0x16f/0x270 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop kernel/entry/common.c:171 [inline]
exit_to_user_mode_prepare+0x23c/0x250 kernel/entry/common.c:203
__syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
syscall_exit_to_user_mode+0x1d/0x50 kernel/entry/common.c:296
do_syscall_64+0x46/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f8e7103df8b
Code: 0f 05 48 3d 00 f0 ff ff 77 45 c3 0f 1f 40 00 48 83 ec 18 89 7c 24 0c e8 63 fc ff ff 8b 7c 24 0c 41 89 c0 b8 03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 35 44 89 c7 89 44 24 0c e8 a1 fc ff ff 8b 44
RSP: 002b:00007fffb68ce4c0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000004 RCX: 00007f8e7103df8b
RDX: 00007f8e70c00e38 RSI: ffffffffffffffff RDI: 0000000000000003
RBP: 00007f8e711ad980 R08: 0000000000000000 R09: 00007f8e70c00000
R10: 00007f8e70c00e40 R11: 0000000000000293 R12: 000000000002bca8
R13: 00007fffb68ce5c0 R14: 00007f8e711abf80 R15: 0000000000000032
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:__list_del_entry_valid.cold+0x12/0x72 lib/list_debug.c:59
Code: f0 ff 0f 0b 48 89 f1 48 c7 c7 60 96 a6 8a 4c 89 e6 e8 4b 29 f0 ff 0f 0b 4c 89 e1 48 89 ee 48 c7 c7 c0 98 a6 8a e8 37 29 f0 ff <0f> 0b 48 89 ee 48 c7 c7 a0 97 a6 8a e8 26 29 f0 ff 0f 0b 4c 89 e2
RSP: 0018:ffffc900151afd58 EFLAGS: 00010282
RAX: 000000000000006d RBX: 0000000000000001 RCX: 0000000000000000
RDX: ffff88801e7eba80 RSI: ffffffff8166001c RDI: fffff52002a35f9d
RBP: ffff888060ce7000 R08: 000000000000006d R09: 0000000000000000
R10: 0000000080000000 R11: 0000000000000000 R12: ffffffff8e536240
R13: ffff88801f3f3000 R14: ffff888060ce1000 R15: ffff888079d855f0
FS: 0000555556f57400(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fa7f4ab1718 CR3: 000000002155a000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[3093...@QQ.COM]

nfc: llcp: Fix race in handling llcp_devices

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

b7b275e60bcd

--- a/net/nfc/llcp_core.c

+++ b/net/nfc/llcp_core.c
@@ -17,6 +17,7 @@
 static u8 llcp_magic[3] = {0x46, 0x66, 0x6d};

 static LIST_HEAD(llcp_devices);
+static DEFINE_MUTEX(llcp_devices_list_lock);

 static void nfc_llcp_rx_skb(struct nfc_llcp_local *local, struct sk_buff *skb);

@@ -168,7 +169,9 @@ static void local_release(struct kref *ref)

        local = container_of(ref, struct nfc_llcp_local, ref);

+       mutex_lock(&llcp_devices_list_lock);
        list_del(&local->list);
+       mutex_unlock(&llcp_devices_list_lock);
        local_cleanup(local);
        kfree(local);
 }
@@ -282,9 +285,13 @@ struct nfc_llcp_local *nfc_llcp_find_local(struct nfc_dev *dev)
 {
        struct nfc_llcp_local *local;

+       mutex_lock(&llcp_devices_list_lock);
        list_for_each_entry(local, &llcp_devices, list)
-               if (local->dev == dev)
+               if (local->dev == dev) {
+                       mutex_unlock(&llcp_devices_list_lock);
                        return local;
+               }
+       mutex_unlock(&llcp_devices_list_lock);

        pr_debug("No device found\n");

@@ -1600,7 +1607,9 @@ int nfc_llcp_register_device(struct nfc_dev *ndev)
        timer_setup(&local->sdreq_timer, nfc_llcp_sdreq_timer, 0);
        INIT_WORK(&local->sdreq_timeout_work, nfc_llcp_sdreq_timeout_work);

+       mutex_lock(&llcp_devices_list_lock);
        list_add(&local->list, &llcp_devices);
+       mutex_unlock(&llcp_devices_list_lock);

        return 0;
 }
--

[syzbot]

> nfc: llcp: Fix race in handling llcp_devices
>
> #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

This crash does not have a reproducer. I cannot test it.

> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bug...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/7d09645c-75cb-4d5b-b247-1a7ff3f63b2bn%40googlegroups.com.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 2258c2dc850b Merge tag 'for-linus' of git://git.kernel.org..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13c52432480000
kernel config: https://syzkaller.appspot.com/x/.config?x=555d27e379d75ff1
dashboard link: https://syzkaller.appspot.com/bug?extid=81232c4a81a886e2b580
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=170f1214480000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/c7ce28c7893b/disk-2258c2dc.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/467de08be04b/vmlinux-2258c2dc.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d5b6a70e73f2/bzImage-2258c2dc.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+81232c...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: use-after-free in nfc_llcp_unregister_device+0x65/0x1b0 net/nfc/llcp_core.c:1610
Read of size 8 at addr ffff88802ca38000 by task syz-executor.1/6961

CPU: 1 PID: 6961 Comm: syz-executor.1 Not tainted 6.2.0-rc1-syzkaller-00043-g2258c2dc850b #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022

Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
print_address_description+0x74/0x340 mm/kasan/report.c:306
print_report+0x107/0x220 mm/kasan/report.c:417
kasan_report+0x139/0x170 mm/kasan/report.c:517
nfc_llcp_unregister_device+0x65/0x1b0 net/nfc/llcp_core.c:1610
nfc_unregister_device+0x18a/0x290 net/nfc/core.c:1179
virtual_ncidev_close+0x55/0x90 drivers/nfc/virtual_ncidev.c:163
__fput+0x3ba/0x880 fs/file_table.c:320
task_work_run+0x243/0x300 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0x134/0x160 kernel/entry/common.c:171
exit_to_user_mode_prepare+0xad/0x110 kernel/entry/common.c:203
__syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
syscall_exit_to_user_mode+0x2e/0x60 kernel/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fd45fe3df5b

Code: 0f 05 48 3d 00 f0 ff ff 77 45 c3 0f 1f 40 00 48 83 ec 18 89 7c 24 0c e8 63 fc ff ff 8b 7c 24 0c 41 89 c0 b8 03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 35 44 89 c7 89 44 24 0c e8 a1 fc ff ff 8b 44

RSP: 002b:00007ffd4c417c70 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000004 RCX: 00007fd45fe3df5b
RDX: 0000001b2e720000 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 00007fd45ffad980 R08: 0000000000000000 R09: 0000000000000010
R10: 00007ffd4c55f0b8 R11: 0000000000000293 R12: 000000000018c31c
R13: 00007ffd4c417d70 R14: 00007fd45ffac120 R15: 0000000000000032
</TASK>

Allocated by task 6975:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4c/0x70 mm/kasan/common.c:52
____kasan_kmalloc mm/kasan/common.c:371 [inline]
__kasan_kmalloc+0x97/0xb0 mm/kasan/common.c:380
kmalloc include/linux/slab.h:580 [inline]
kzalloc include/linux/slab.h:720 [inline]
nfc_llcp_register_device+0x51/0x800 net/nfc/llcp_core.c:1566
nfc_register_device+0x68/0x320 net/nfc/core.c:1124
nci_register_device+0x7c7/0x900 net/nfc/nci/core.c:1257
virtual_ncidev_open+0x138/0x1b0 drivers/nfc/virtual_ncidev.c:148
misc_open+0x346/0x3c0 drivers/char/misc.c:165
chrdev_open+0x5fb/0x680 fs/char_dev.c:414
do_dentry_open+0x85f/0x11b0 fs/open.c:882
do_open fs/namei.c:3557 [inline]
path_openat+0x25cc/0x2de0 fs/namei.c:3714
do_filp_open+0x275/0x500 fs/namei.c:3741
do_sys_openat2+0x13b/0x500 fs/open.c:1310
do_sys_open fs/open.c:1326 [inline]
__do_sys_openat fs/open.c:1342 [inline]
__se_sys_openat fs/open.c:1337 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1337
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Freed by task 6966:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4c/0x70 mm/kasan/common.c:52
kasan_save_free_info+0x27/0x40 mm/kasan/generic.c:518
____kasan_slab_free+0xd6/0x120 mm/kasan/common.c:236
kasan_slab_free include/linux/kasan.h:177 [inline]
slab_free_hook mm/slub.c:1781 [inline]
slab_free_freelist_hook+0x12e/0x1a0 mm/slub.c:1807
slab_free mm/slub.c:3787 [inline]
__kmem_cache_free+0x71/0x110 mm/slub.c:3800
local_release net/nfc/llcp_core.c:173 [inline]
kref_put include/linux/kref.h:65 [inline]
nfc_llcp_local_put+0x209/0x230 net/nfc/llcp_core.c:181
nfc_unregister_device+0x18a/0x290 net/nfc/core.c:1179
virtual_ncidev_close+0x55/0x90 drivers/nfc/virtual_ncidev.c:163
__fput+0x3ba/0x880 fs/file_table.c:320
task_work_run+0x243/0x300 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0x134/0x160 kernel/entry/common.c:171
exit_to_user_mode_prepare+0xad/0x110 kernel/entry/common.c:203
__syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
syscall_exit_to_user_mode+0x2e/0x60 kernel/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x63/0xcd

The buggy address belongs to the object at ffff88802ca38000
which belongs to the cache kmalloc-2k of size 2048
The buggy address is located 0 bytes inside of
2048-byte region [ffff88802ca38000, ffff88802ca38800)

The buggy address belongs to the physical page:
page:ffffea0000b28e00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x2ca38
head:ffffea0000b28e00 order:3 compound_mapcount:0 subpages_mapcount:0 compound_pincount:0
anon flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000010200 ffff888012842000 0000000000000000 dead000000000001
raw: 0000000000000000 0000000000080008 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 26, tgid 26 (kworker/1:1), ts 13630378390, free_ts 0
prep_new_page mm/page_alloc.c:2531 [inline]
get_page_from_freelist+0x72b/0x7a0 mm/page_alloc.c:4283
__alloc_pages+0x259/0x560 mm/page_alloc.c:5549
alloc_slab_page+0xbd/0x190 mm/slub.c:1851
allocate_slab+0x5e/0x3c0 mm/slub.c:1998
new_slab mm/slub.c:2051 [inline]
___slab_alloc+0x7f4/0xeb0 mm/slub.c:3193
__slab_alloc mm/slub.c:3292 [inline]
__slab_alloc_node mm/slub.c:3345 [inline]
slab_alloc_node mm/slub.c:3442 [inline]
__kmem_cache_alloc_node+0x25b/0x340 mm/slub.c:3491
kmalloc_trace+0x26/0x60 mm/slab_common.c:1062
kmalloc include/linux/slab.h:580 [inline]
kzalloc include/linux/slab.h:720 [inline]
fw_create_instance+0x59/0x180 drivers/base/firmware_loader/sysfs.c:402
fw_load_from_user_helper+0xcb/0x1f0 drivers/base/firmware_loader/fallback.c:151
_request_firmware+0x44b/0x6a0 drivers/base/firmware_loader/main.c:856
request_firmware_work_func+0x125/0x270 drivers/base/firmware_loader/main.c:1105
process_one_work+0x81c/0xd10 kernel/workqueue.c:2289
worker_thread+0xb14/0x1330 kernel/workqueue.c:2436
kthread+0x266/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
page_owner free stack trace missing

Memory state around the buggy address:
ffff88802ca37f00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff88802ca37f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff88802ca38000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff88802ca38080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff88802ca38100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

[Hillf Danton]

On 30 Dec 2022 02:41:42 -0800

> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 2258c2dc850b Merge tag 'for-linus' of git://git.kernel.org..
> git tree: upstream

Add vnd_close_mutex to serialize __fput().

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2258c2dc850b

--- x/drivers/nfc/virtual_ncidev.c
+++ y/drivers/nfc/virtual_ncidev.c
@@ -156,10 +156,18 @@ static int virtual_ncidev_open(struct in
return 0;
}

+static DEFINE_MUTEX(vnd_close_mutex);
+
static int virtual_ncidev_close(struct inode *inode, struct file *file)
{
- struct virtual_nci_dev *vdev = file->private_data;
+ struct virtual_nci_dev *vdev;

+ mutex_lock(&vnd_close_mutex);
+ vdev = file->private_data;
+ file->private_data = NULL;
+ mutex_unlock(&vnd_close_mutex);
+ if (!vdev)
+ return 0;
nci_unregister_device(vdev->ndev);
nci_free_device(vdev->ndev);
mutex_destroy(&vdev->mtx);
--

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
INFO: rcu detected stall in corrupted

rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5544 } 2636 jiffies s: 2861 root: 0x0/T
rcu: blocking rcu_node structures (internal RCU debug):


Tested on:

commit: 2258c2dc Merge tag 'for-linus' of git://git.kernel.org..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=13a33938480000

kernel config: https://syzkaller.appspot.com/x/.config?x=555d27e379d75ff1
dashboard link: https://syzkaller.appspot.com/bug?extid=81232c4a81a886e2b580
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2

patch: https://syzkaller.appspot.com/x/patch.diff?x=1341acbc480000

[syzbot]

syzbot suspects this issue was fixed by commit:

commit b938790e70540bf4f2e653dcd74b232494d06c8f
Author: Luiz Augusto von Dentz <luiz.vo...@intel.com>
Date: Fri Sep 15 20:24:47 2023 +0000

Bluetooth: hci_codec: Fix leaking content of local_codecs

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15cb8f17680000
start commit: e1c04510f521 Merge tag 'pm-6.2-rc9' of git://git.kernel.or..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=fe56f7d193926860
dashboard link: https://syzkaller.appspot.com/bug?extid=81232c4a81a886e2b580
userspace arch: i386
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14e90568c80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: Bluetooth: hci_codec: Fix leaking content of local_codecs

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[syzbot]

Auto-closing this bug as obsolete.
No recent activity, existing reproducers are no longer triggering the issue.