KASAN: slab-out-of-bounds Write in rmd160_final

7 views
Skip to first unread message

syzbot

unread,
Jun 7, 2018, 9:12:02 AM6/7/18
to da...@davemloft.net, her...@gondor.apana.org.au, linux-...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
Hello,

syzbot found the following crash on:

HEAD commit: 1c8c5a9d38f6 Merge git://git.kernel.org/pub/scm/linux/kern..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17f025df800000
kernel config: https://syzkaller.appspot.com/x/.config?x=2e1a31e8576e013a
dashboard link: https://syzkaller.appspot.com/bug?extid=d04e58bd384f1fe0b112
compiler: gcc (GCC) 8.0.1 20180413 (experimental)

Unfortunately, I don't have any reproducer for this crash yet.

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+d04e58...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: slab-out-of-bounds in rmd160_final+0x201/0x240
crypto/rmd160.c:334
Write of size 4 at addr ffff8801b00585d8 by task syz-executor1/15928

CPU: 0 PID: 15928 Comm: syz-executor1 Not tainted 4.17.0+ #88
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1b9/0x294 lib/dump_stack.c:113
print_address_description+0x6c/0x20b mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report.cold.7+0x242/0x2fe mm/kasan/report.c:412
__asan_report_store4_noabort+0x17/0x20 mm/kasan/report.c:437
rmd160_final+0x201/0x240 crypto/rmd160.c:334
crypto_shash_final+0x104/0x260 crypto/shash.c:152
kdf_ctr security/keys/dh.c:186 [inline]
keyctl_dh_compute_kdf security/keys/dh.c:217 [inline]
__keyctl_dh_compute+0x1184/0x1bc0 security/keys/dh.c:389
keyctl_dh_compute+0xb9/0x100 security/keys/dh.c:425
__do_sys_keyctl security/keys/keyctl.c:1741 [inline]
__se_sys_keyctl security/keys/keyctl.c:1637 [inline]
__x64_sys_keyctl+0x12a/0x3b0 security/keys/keyctl.c:1637
do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x455a09
Code: 1d ba fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 eb b9 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f2e9de49c68 EFLAGS: 00000246 ORIG_RAX: 00000000000000fa
RAX: ffffffffffffffda RBX: 00007f2e9de4a6d4 RCX: 0000000000455a09
RDX: 0000000020a53ffb RSI: 0000000020000140 RDI: 0000000000000017
RBP: 000000000072bea0 R08: 0000000020c61fc8 R09: 0000000000000000
R10: 0000000000000005 R11: 0000000000000246 R12: 00000000ffffffff
R13: 0000000000000499 R14: 00000000006fbef8 R15: 0000000000000000

Allocated by task 15928:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc+0xc4/0xe0 mm/kasan/kasan.c:553
__do_kmalloc mm/slab.c:3718 [inline]
__kmalloc+0x14e/0x760 mm/slab.c:3727
kmalloc include/linux/slab.h:518 [inline]
keyctl_dh_compute_kdf security/keys/dh.c:211 [inline]
__keyctl_dh_compute+0xfe9/0x1bc0 security/keys/dh.c:389
keyctl_dh_compute+0xb9/0x100 security/keys/dh.c:425
__do_sys_keyctl security/keys/keyctl.c:1741 [inline]
__se_sys_keyctl security/keys/keyctl.c:1637 [inline]
__x64_sys_keyctl+0x12a/0x3b0 security/keys/keyctl.c:1637
do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 4605:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x11a/0x170 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3498 [inline]
kfree+0xd9/0x260 mm/slab.c:3813
kvfree+0x61/0x70 mm/util.c:440
translate_table+0xc24/0x1780 net/ipv4/netfilter/ip_tables.c:714
do_replace net/ipv4/netfilter/ip_tables.c:1138 [inline]
do_ipt_set_ctl+0x3c7/0x645 net/ipv4/netfilter/ip_tables.c:1674
nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
nf_setsockopt+0x7d/0xd0 net/netfilter/nf_sockopt.c:115
ip_setsockopt+0xd8/0xf0 net/ipv4/ip_sockglue.c:1258
tcp_setsockopt+0x93/0xe0 net/ipv4/tcp.c:3047
sock_common_setsockopt+0x9a/0xe0 net/core/sock.c:3053
__sys_setsockopt+0x1bd/0x390 net/socket.c:1935
__do_sys_setsockopt net/socket.c:1946 [inline]
__se_sys_setsockopt net/socket.c:1943 [inline]
__x64_sys_setsockopt+0xbe/0x150 net/socket.c:1943
do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8801b00585c0
which belongs to the cache kmalloc-32 of size 32
The buggy address is located 24 bytes inside of
32-byte region [ffff8801b00585c0, ffff8801b00585e0)
The buggy address belongs to the page:
page:ffffea0006c01600 count:1 mapcount:0 mapping:ffff8801b0058000
index:0xffff8801b0058fc1
flags: 0x2fffc0000000100(slab)
raw: 02fffc0000000100 ffff8801b0058000 ffff8801b0058fc1 0000000100000031
raw: ffffea00073f66a0 ffffea0007209620 ffff8801da8001c0 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8801b0058480: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
ffff8801b0058500: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
> ffff8801b0058580: 05 fc fc fc fc fc fc fc 00 00 00 fc fc fc fc fc
^
ffff8801b0058600: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
ffff8801b0058680: 00 00 01 fc fc fc fc fc 00 00 03 fc fc fc fc fc
==================================================================


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with
syzbot.

syzbot

unread,
Jun 7, 2018, 11:35:03 AM6/7/18
to da...@davemloft.net, her...@gondor.apana.org.au, linux-...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
syzbot has found a reproducer for the following crash on:

HEAD commit: 1c8c5a9d38f6 Merge git://git.kernel.org/pub/scm/linux/kern..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1189a3d7800000
kernel config: https://syzkaller.appspot.com/x/.config?x=4f1acdf888c9d4e9
dashboard link: https://syzkaller.appspot.com/bug?extid=d04e58bd384f1fe0b112
compiler: gcc (GCC) 8.0.1 20180413 (experimental)
userspace arch: i386
syzkaller repro:https://syzkaller.appspot.com/x/repro.syz?x=14dde79f800000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+d04e58...@syzkaller.appspotmail.com

IPv6: ADDRCONF(NETDEV_UP): veth0: link is not ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): bond0: link becomes ready
8021q: adding VLAN 0 to HW filter on device team0
==================================================================
BUG: KASAN: slab-out-of-bounds in rmd160_final+0x201/0x240
crypto/rmd160.c:334
Write of size 4 at addr ffff8801d0fae518 by task syz-executor0/4822

CPU: 0 PID: 4822 Comm: syz-executor0 Not tainted 4.17.0+ #114
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1b9/0x294 lib/dump_stack.c:113
print_address_description+0x6c/0x20b mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report.cold.7+0x242/0x2fe mm/kasan/report.c:412
__asan_report_store4_noabort+0x17/0x20 mm/kasan/report.c:437
rmd160_final+0x201/0x240 crypto/rmd160.c:334
crypto_shash_final+0x104/0x260 crypto/shash.c:152
kdf_ctr security/keys/dh.c:186 [inline]
keyctl_dh_compute_kdf security/keys/dh.c:217 [inline]
__keyctl_dh_compute+0x1184/0x1bc0 security/keys/dh.c:389
compat_keyctl_dh_compute+0x2c8/0x3e0 security/keys/compat_dh.c:39
__do_compat_sys_keyctl security/keys/compat.c:136 [inline]
__se_compat_sys_keyctl security/keys/compat.c:59 [inline]
__ia32_compat_sys_keyctl+0x137/0x3b0 security/keys/compat.c:59
do_syscall_32_irqs_on arch/x86/entry/common.c:323 [inline]
do_fast_syscall_32+0x345/0xf9b arch/x86/entry/common.c:394
entry_SYSENTER_compat+0x70/0x7f arch/x86/entry/entry_64_compat.S:139
RIP: 0023:0xf7faacb9
Code: 55 08 8b 88 64 cd ff ff 8b 98 68 cd ff ff 89 c8 85 d2 74 02 89 0a 5b
5d c3 8b 04 24 c3 8b 1c 24 c3 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90
90 90 90 eb 0d 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 002b:00000000ffab4bcc EFLAGS: 00000282 ORIG_RAX: 0000000000000120
RAX: ffffffffffffffda RBX: 0000000000000017 RCX: 0000000020000100
RDX: 0000000020a53ffb RSI: 0000000000000005 RDI: 0000000020c61fc8
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000296 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 4822:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc+0xc4/0xe0 mm/kasan/kasan.c:553
__do_kmalloc mm/slab.c:3718 [inline]
__kmalloc+0x14e/0x760 mm/slab.c:3727
kmalloc include/linux/slab.h:518 [inline]
keyctl_dh_compute_kdf security/keys/dh.c:211 [inline]
__keyctl_dh_compute+0xfe9/0x1bc0 security/keys/dh.c:389
compat_keyctl_dh_compute+0x2c8/0x3e0 security/keys/compat_dh.c:39
__do_compat_sys_keyctl security/keys/compat.c:136 [inline]
__se_compat_sys_keyctl security/keys/compat.c:59 [inline]
__ia32_compat_sys_keyctl+0x137/0x3b0 security/keys/compat.c:59
do_syscall_32_irqs_on arch/x86/entry/common.c:323 [inline]
do_fast_syscall_32+0x345/0xf9b arch/x86/entry/common.c:394
entry_SYSENTER_compat+0x70/0x7f arch/x86/entry/entry_64_compat.S:139

Freed by task 3199:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x11a/0x170 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3498 [inline]
kfree+0xd9/0x260 mm/slab.c:3813
load_elf_binary+0x463e/0x5610 fs/binfmt_elf.c:1108
search_binary_handler+0x17d/0x570 fs/exec.c:1653
exec_binprm fs/exec.c:1695 [inline]
__do_execve_file.isra.34+0x16fe/0x2610 fs/exec.c:1819
do_execveat_common fs/exec.c:1865 [inline]
do_execve fs/exec.c:1882 [inline]
__do_sys_execve fs/exec.c:1963 [inline]
__se_sys_execve fs/exec.c:1958 [inline]
__x64_sys_execve+0x8f/0xc0 fs/exec.c:1958
do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8801d0fae500
which belongs to the cache kmalloc-32 of size 32
The buggy address is located 24 bytes inside of
32-byte region [ffff8801d0fae500, ffff8801d0fae520)
The buggy address belongs to the page:
page:ffffea000743eb80 count:1 mapcount:0 mapping:ffff8801d0fae000
index:0xffff8801d0faefc1
flags: 0x2fffc0000000100(slab)
raw: 02fffc0000000100 ffff8801d0fae000 ffff8801d0faefc1 0000000100000023
raw: ffffea00074171a0 ffffea000749e220 ffff8801da8001c0 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8801d0fae400: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
ffff8801d0fae480: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
> ffff8801d0fae500: 00 00 00 fc fc fc fc fc fb fb fb fb fc fc fc fc
^
ffff8801d0fae580: 00 fc fc fc fc fc fc fc fb fb fb fb fc fc fc fc
ffff8801d0fae600: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
==================================================================

syzbot

unread,
Jun 7, 2018, 12:36:03 PM6/7/18
to da...@davemloft.net, her...@gondor.apana.org.au, linux-...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
syzbot has found a reproducer for the following crash on:

HEAD commit: 1c8c5a9d38f6 Merge git://git.kernel.org/pub/scm/linux/kern..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=14c7f96f800000
kernel config: https://syzkaller.appspot.com/x/.config?x=4f1acdf888c9d4e9
dashboard link: https://syzkaller.appspot.com/bug?extid=d04e58bd384f1fe0b112
compiler: gcc (GCC) 8.0.1 20180413 (experimental)
syzkaller repro:https://syzkaller.appspot.com/x/repro.syz?x=1432a66f800000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11b5034f800000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+d04e58...@syzkaller.appspotmail.com

random: sshd: uninitialized urandom read (32 bytes read)
random: sshd: uninitialized urandom read (32 bytes read)
random: sshd: uninitialized urandom read (32 bytes read)
random: sshd: uninitialized urandom read (32 bytes read)
==================================================================
BUG: KASAN: slab-out-of-bounds in rmd160_final+0x201/0x240
crypto/rmd160.c:334
Write of size 4 at addr ffff8801d88781d8 by task syz-executor724/4532

CPU: 1 PID: 4532 Comm: syz-executor724 Not tainted 4.17.0+ #89
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1b9/0x294 lib/dump_stack.c:113
print_address_description+0x6c/0x20b mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report.cold.7+0x242/0x2fe mm/kasan/report.c:412
__asan_report_store4_noabort+0x17/0x20 mm/kasan/report.c:437
rmd160_final+0x201/0x240 crypto/rmd160.c:334
crypto_shash_final+0x104/0x260 crypto/shash.c:152
kdf_ctr security/keys/dh.c:186 [inline]
keyctl_dh_compute_kdf security/keys/dh.c:217 [inline]
__keyctl_dh_compute+0x1184/0x1bc0 security/keys/dh.c:389
keyctl_dh_compute+0xb9/0x100 security/keys/dh.c:425
__do_sys_keyctl security/keys/keyctl.c:1741 [inline]
__se_sys_keyctl security/keys/keyctl.c:1637 [inline]
__x64_sys_keyctl+0x12a/0x3b0 security/keys/keyctl.c:1637
do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x43ffa9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 6b 45 00 00 c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffd9be52ed8 EFLAGS: 00000217 ORIG_RAX: 00000000000000fa
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 000000000043ffa9
RDX: 0000000020a53ffb RSI: 0000000020000100 RDI: 0000000000000017
RBP: 00000000006ca018 R08: 0000000020c61fc8 R09: 00000000004002c8
R10: 0000000000000005 R11: 0000000000000217 R12: 00000000004018d0
R13: 0000000000401960 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 4532:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc+0xc4/0xe0 mm/kasan/kasan.c:553
__do_kmalloc mm/slab.c:3718 [inline]
__kmalloc+0x14e/0x760 mm/slab.c:3727
kmalloc include/linux/slab.h:518 [inline]
keyctl_dh_compute_kdf security/keys/dh.c:211 [inline]
__keyctl_dh_compute+0xfe9/0x1bc0 security/keys/dh.c:389
keyctl_dh_compute+0xb9/0x100 security/keys/dh.c:425
__do_sys_keyctl security/keys/keyctl.c:1741 [inline]
__se_sys_keyctl security/keys/keyctl.c:1637 [inline]
__x64_sys_keyctl+0x12a/0x3b0 security/keys/keyctl.c:1637
do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 2865:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x11a/0x170 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3498 [inline]
kfree+0xd9/0x260 mm/slab.c:3813
single_release+0x8f/0xb0 fs/seq_file.c:609
__fput+0x353/0x890 fs/file_table.c:209
____fput+0x15/0x20 fs/file_table.c:243
task_work_run+0x1e4/0x290 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:192 [inline]
exit_to_usermode_loop+0x2bd/0x310 arch/x86/entry/common.c:166
prepare_exit_to_usermode arch/x86/entry/common.c:196 [inline]
syscall_return_slowpath arch/x86/entry/common.c:265 [inline]
do_syscall_64+0x6ac/0x800 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8801d88781c0
which belongs to the cache kmalloc-32 of size 32
The buggy address is located 24 bytes inside of
32-byte region [ffff8801d88781c0, ffff8801d88781e0)
The buggy address belongs to the page:
page:ffffea0007621e00 count:1 mapcount:0 mapping:ffff8801d8878000
index:0xffff8801d8878fc1
flags: 0x2fffc0000000100(slab)
raw: 02fffc0000000100 ffff8801d8878000 ffff8801d8878fc1 0000000100000018
raw: ffffea00070e71e0 ffffea00076222a0 ffff8801da8001c0 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8801d8878080: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
ffff8801d8878100: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
> ffff8801d8878180: fb fb fb fb fc fc fc fc 00 00 00 fc fc fc fc fc
^
ffff8801d8878200: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
ffff8801d8878280: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
==================================================================

Eric Biggers

unread,
Jun 7, 2018, 3:18:10 PM6/7/18
to syzbot, da...@davemloft.net, her...@gondor.apana.org.au, linux-...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
Duplicate:

#syz dup: KASAN: slab-out-of-bounds Write in sha1_finup

Tentative fix is "[PATCH] dh key: fix rounding up KDF output length".
Reply all
Reply to author
Forward
0 new messages