[PATCH syzbot] HID: wacom: Fix memory leak in wacom_probe()

[Peilin Ye]

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in rxrpc_lookup_local

BUG: memory leak
unreferenced object 0xffff888117db0500 (size 256):
comm "syz-executor.4", pid 8886, jiffies 4294944028 (age 432.930s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 0a 00 00 00 00 c0 79 17 81 88 ff ff ..........y.....
backtrace:
[<000000001169b470>] kmalloc include/linux/slab.h:552 [inline]
[<000000001169b470>] kzalloc include/linux/slab.h:664 [inline]
[<000000001169b470>] rxrpc_alloc_local net/rxrpc/local_object.c:79 [inline]
[<000000001169b470>] rxrpc_lookup_local+0x1c1/0x760 net/rxrpc/local_object.c:244
[<00000000e579837f>] rxrpc_bind+0x174/0x240 net/rxrpc/af_rxrpc.c:149
[<00000000200580c7>] afs_open_socket+0xdb/0x200 fs/afs/rxrpc.c:64
[<00000000be70b129>] afs_net_init+0x2b4/0x340 fs/afs/main.c:126
[<00000000449cb763>] ops_init+0x4e/0x190 net/core/net_namespace.c:152
[<00000000efe39ea0>] setup_net+0xdb/0x2d0 net/core/net_namespace.c:342
[<0000000080bf9a14>] copy_net_ns+0x14b/0x320 net/core/net_namespace.c:483
[<00000000fd18ae2f>] create_new_namespaces+0x199/0x4e0 kernel/nsproxy.c:110
[<000000008a230dcc>] unshare_nsproxy_namespaces+0x9b/0x120 kernel/nsproxy.c:231
[<00000000e5c837ae>] ksys_unshare+0x2fe/0x5c0 kernel/fork.c:2949
[<000000006188dafa>] __do_sys_unshare kernel/fork.c:3017 [inline]
[<000000006188dafa>] __se_sys_unshare kernel/fork.c:3015 [inline]
[<000000006188dafa>] __x64_sys_unshare+0x12/0x20 kernel/fork.c:3015
[<000000008705de4b>] do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
[<0000000058e35946>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff888117661700 (size 256):
comm "syz-executor.6", pid 8882, jiffies 4294944028 (age 432.930s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 0a 00 00 00 00 c0 06 11 81 88 ff ff ................
backtrace:
[<000000001169b470>] kmalloc include/linux/slab.h:552 [inline]
[<000000001169b470>] kzalloc include/linux/slab.h:664 [inline]
[<000000001169b470>] rxrpc_alloc_local net/rxrpc/local_object.c:79 [inline]
[<000000001169b470>] rxrpc_lookup_local+0x1c1/0x760 net/rxrpc/local_object.c:244
[<00000000e579837f>] rxrpc_bind+0x174/0x240 net/rxrpc/af_rxrpc.c:149
[<00000000200580c7>] afs_open_socket+0xdb/0x200 fs/afs/rxrpc.c:64
[<00000000be70b129>] afs_net_init+0x2b4/0x340 fs/afs/main.c:126
[<00000000449cb763>] ops_init+0x4e/0x190 net/core/net_namespace.c:152
[<00000000efe39ea0>] setup_net+0xdb/0x2d0 net/core/net_namespace.c:342
[<0000000080bf9a14>] copy_net_ns+0x14b/0x320 net/core/net_namespace.c:483
[<00000000fd18ae2f>] create_new_namespaces+0x199/0x4e0 kernel/nsproxy.c:110
[<000000008a230dcc>] unshare_nsproxy_namespaces+0x9b/0x120 kernel/nsproxy.c:231
[<00000000e5c837ae>] ksys_unshare+0x2fe/0x5c0 kernel/fork.c:2949
[<000000006188dafa>] __do_sys_unshare kernel/fork.c:3017 [inline]
[<000000006188dafa>] __se_sys_unshare kernel/fork.c:3015 [inline]
[<000000006188dafa>] __x64_sys_unshare+0x12/0x20 kernel/fork.c:3015
[<000000008705de4b>] do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
[<0000000058e35946>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff88810bb9f900 (size 256):
comm "syz-executor.0", pid 8879, jiffies 4294944030 (age 432.910s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 0a 00 00 00 00 40 b0 16 81 88 ff ff .........@......
backtrace:
[<000000001169b470>] kmalloc include/linux/slab.h:552 [inline]
[<000000001169b470>] kzalloc include/linux/slab.h:664 [inline]
[<000000001169b470>] rxrpc_alloc_local net/rxrpc/local_object.c:79 [inline]
[<000000001169b470>] rxrpc_lookup_local+0x1c1/0x760 net/rxrpc/local_object.c:244
[<00000000e579837f>] rxrpc_bind+0x174/0x240 net/rxrpc/af_rxrpc.c:149
[<00000000200580c7>] afs_open_socket+0xdb/0x200 fs/afs/rxrpc.c:64
[<00000000be70b129>] afs_net_init+0x2b4/0x340 fs/afs/main.c:126
[<00000000449cb763>] ops_init+0x4e/0x190 net/core/net_namespace.c:152
[<00000000efe39ea0>] setup_net+0xdb/0x2d0 net/core/net_namespace.c:342
[<0000000080bf9a14>] copy_net_ns+0x14b/0x320 net/core/net_namespace.c:483
[<00000000fd18ae2f>] create_new_namespaces+0x199/0x4e0 kernel/nsproxy.c:110
[<000000008a230dcc>] unshare_nsproxy_namespaces+0x9b/0x120 kernel/nsproxy.c:231
[<00000000e5c837ae>] ksys_unshare+0x2fe/0x5c0 kernel/fork.c:2949
[<000000006188dafa>] __do_sys_unshare kernel/fork.c:3017 [inline]
[<000000006188dafa>] __se_sys_unshare kernel/fork.c:3015 [inline]
[<000000006188dafa>] __x64_sys_unshare+0x12/0x20 kernel/fork.c:3015
[<000000008705de4b>] do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
[<0000000058e35946>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff888117791900 (size 256):
comm "syz-executor.5", pid 8885, jiffies 4294944032 (age 432.890s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 0a 00 00 00 00 40 e2 17 81 88 ff ff .........@......
backtrace:
[<000000001169b470>] kmalloc include/linux/slab.h:552 [inline]
[<000000001169b470>] kzalloc include/linux/slab.h:664 [inline]
[<000000001169b470>] rxrpc_alloc_local net/rxrpc/local_object.c:79 [inline]
[<000000001169b470>] rxrpc_lookup_local+0x1c1/0x760 net/rxrpc/local_object.c:244
[<00000000e579837f>] rxrpc_bind+0x174/0x240 net/rxrpc/af_rxrpc.c:149
[<00000000200580c7>] afs_open_socket+0xdb/0x200 fs/afs/rxrpc.c:64
[<00000000be70b129>] afs_net_init+0x2b4/0x340 fs/afs/main.c:126
[<00000000449cb763>] ops_init+0x4e/0x190 net/core/net_namespace.c:152
[<00000000efe39ea0>] setup_net+0xdb/0x2d0 net/core/net_namespace.c:342
[<0000000080bf9a14>] copy_net_ns+0x14b/0x320 net/core/net_namespace.c:483
[<00000000fd18ae2f>] create_new_namespaces+0x199/0x4e0 kernel/nsproxy.c:110
[<000000008a230dcc>] unshare_nsproxy_namespaces+0x9b/0x120 kernel/nsproxy.c:231
[<00000000e5c837ae>] ksys_unshare+0x2fe/0x5c0 kernel/fork.c:2949
[<000000006188dafa>] __do_sys_unshare kernel/fork.c:3017 [inline]
[<000000006188dafa>] __se_sys_unshare kernel/fork.c:3015 [inline]
[<000000006188dafa>] __x64_sys_unshare+0x12/0x20 kernel/fork.c:3015
[<000000008705de4b>] do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
[<0000000058e35946>] entry_SYSCALL_64_after_hwframe+0x44/0xa9



Tested on:

commit: ca4bbdaf Merge tag 'iommu-fixes' of git://git.kernel.org/p..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1764240f500000
kernel config: https://syzkaller.appspot.com/x/.config?x=4305fa9ea70c7a9f
dashboard link: https://syzkaller.appspot.com/bug?extid=5b49c9695968d7250a26
compiler: gcc (GCC) 10.1.0-syz 20200507
patch: https://syzkaller.appspot.com/x/patch.diff?x=1463946b500000