[syzbot] BUG: MAX_LOCKDEP_ENTRIES too low! (3)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 094226ad94f4 Linux 6.1-rc5
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10b21801880000
kernel config: https://syzkaller.appspot.com/x/.config?x=e9039cbe1d7613aa
dashboard link: https://syzkaller.appspot.com/bug?extid=b04c9ffbbd2f303d00d9
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/655851ef7ce3/disk-094226ad.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f1e7de729009/vmlinux-094226ad.xz
kernel image: https://storage.googleapis.com/syzbot-assets/849adc218fa0/bzImage-094226ad.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b04c9f...@syzkaller.appspotmail.com

BUG: MAX_LOCKDEP_ENTRIES too low!
turning off the locking correctness validator.
CPU: 1 PID: 26581 Comm: syz-executor.4 Not tainted 6.1.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
alloc_list_entry.cold+0x11/0x18 kernel/locking/lockdep.c:1402
add_lock_to_list kernel/locking/lockdep.c:1423 [inline]
check_prev_add kernel/locking/lockdep.c:3167 [inline]
check_prevs_add kernel/locking/lockdep.c:3216 [inline]
validate_chain kernel/locking/lockdep.c:3831 [inline]
__lock_acquire+0x3626/0x56d0 kernel/locking/lockdep.c:5055
lock_acquire kernel/locking/lockdep.c:5668 [inline]
lock_acquire+0x1df/0x630 kernel/locking/lockdep.c:5633
local_lock_acquire include/linux/local_lock_internal.h:29 [inline]
___slab_alloc+0xe1/0x1400 mm/slub.c:3099
__slab_alloc.constprop.0+0x56/0xa0 mm/slub.c:3279
slab_alloc_node mm/slub.c:3364 [inline]
__kmem_cache_alloc_node+0x191/0x3e0 mm/slub.c:3437
kmalloc_trace+0x22/0x60 mm/slab_common.c:1045
kmalloc include/linux/slab.h:553 [inline]
kzalloc include/linux/slab.h:689 [inline]
ref_tracker_alloc+0x14c/0x550 lib/ref_tracker.c:85
__netdev_tracker_alloc include/linux/netdevice.h:3995 [inline]
netdev_hold include/linux/netdevice.h:4024 [inline]
netdev_hold include/linux/netdevice.h:4019 [inline]
qdisc_alloc+0x7b2/0xb00 net/sched/sch_generic.c:974
qdisc_create_dflt+0x75/0x540 net/sched/sch_generic.c:996
attach_one_default_qdisc net/sched/sch_generic.c:1151 [inline]
netdev_for_each_tx_queue include/linux/netdevice.h:2440 [inline]
attach_default_qdiscs net/sched/sch_generic.c:1169 [inline]
dev_activate+0x760/0xcd0 net/sched/sch_generic.c:1228
__dev_open+0x393/0x4d0 net/core/dev.c:1441
dev_open net/core/dev.c:1468 [inline]
dev_open+0xe8/0x150 net/core/dev.c:1461
team_port_add drivers/net/team/team.c:1215 [inline]
team_add_slave+0x9ff/0x1b80 drivers/net/team/team.c:1984
do_set_master+0x1c8/0x220 net/core/rtnetlink.c:2578
rtnl_newlink_create net/core/rtnetlink.c:3381 [inline]
__rtnl_newlink+0x13ac/0x17e0 net/core/rtnetlink.c:3581
rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3594
rtnetlink_rcv_msg+0x43a/0xca0 net/core/rtnetlink.c:6091
netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2540
netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921
sock_sendmsg_nosec net/socket.c:714 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:734
____sys_sendmsg+0x712/0x8c0 net/socket.c:2482
___sys_sendmsg+0x110/0x1b0 net/socket.c:2536
__sys_sendmsg+0xf3/0x1c0 net/socket.c:2565
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fe8c728b639
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe8c7f81168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fe8c73ac120 RCX: 00007fe8c728b639
RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000000000004
RBP: 00007fe8c72e6ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fe8c74cfb1f R14: 00007fe8c7f81300 R15: 0000000000022000
</TASK>
8021q: adding VLAN 0 to HW filter on device batadv159
device batadv159 entered promiscuous mode
team83: Port device batadv159 added


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 9ab000d9ac54 Merge branch 'nfc-leaks'
git tree: net
console+strace: https://syzkaller.appspot.com/x/log.txt?x=178f3db5880000
kernel config: https://syzkaller.appspot.com/x/.config?x=6f4e5e9899396248

dashboard link: https://syzkaller.appspot.com/bug?extid=b04c9ffbbd2f303d00d9
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15051edd880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15b9d365880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/0db12aff8b37/disk-9ab000d9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/62dc4dacf73e/vmlinux-9ab000d9.xz
kernel image: https://storage.googleapis.com/syzbot-assets/0cc1ecdd9ab6/bzImage-9ab000d9.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b04c9f...@syzkaller.appspotmail.com

8021q: adding VLAN 0 to HW filter on device batadv968

BUG: MAX_LOCKDEP_ENTRIES too low!
turning off the locking correctness validator.

CPU: 1 PID: 5813 Comm: syz-executor248 Not tainted 6.1.0-rc5-syzkaller-00128-g9ab000d9ac54 #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]

dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106

alloc_list_entry.cold+0x11/0x18 kernel/locking/lockdep.c:1402
add_lock_to_list kernel/locking/lockdep.c:1423 [inline]
check_prev_add kernel/locking/lockdep.c:3167 [inline]
check_prevs_add kernel/locking/lockdep.c:3216 [inline]
validate_chain kernel/locking/lockdep.c:3831 [inline]
__lock_acquire+0x3626/0x56d0 kernel/locking/lockdep.c:5055
lock_acquire kernel/locking/lockdep.c:5668 [inline]

lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:355 [inline]
batadv_tt_local_event+0x1f6/0x7e0 net/batman-adv/translation-table.c:482
batadv_tt_local_add+0x638/0x1f50 net/batman-adv/translation-table.c:758
batadv_softif_create_vlan+0x2ed/0x530 net/batman-adv/soft-interface.c:586
batadv_interface_add_vid+0xd7/0x110 net/batman-adv/soft-interface.c:646
vlan_add_rx_filter_info+0x149/0x1d0 net/8021q/vlan_core.c:211
__vlan_vid_add net/8021q/vlan_core.c:306 [inline]
vlan_vid_add+0x3f6/0x7f0 net/8021q/vlan_core.c:336
vlan_device_event.cold+0x28/0x2d net/8021q/vlan.c:385
notifier_call_chain+0xb5/0x200 kernel/notifier.c:87
call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1945
call_netdevice_notifiers_extack net/core/dev.c:1983 [inline]
call_netdevice_notifiers net/core/dev.c:1997 [inline]
dev_open net/core/dev.c:1473 [inline]
dev_open+0x136/0x150 net/core/dev.c:1461
team_port_add drivers/net/team/team.c:1215 [inline]
team_add_slave+0xa03/0x1b90 drivers/net/team/team.c:1984

do_set_master+0x1c8/0x220 net/core/rtnetlink.c:2578
rtnl_newlink_create net/core/rtnetlink.c:3381 [inline]
__rtnl_newlink+0x13ac/0x17e0 net/core/rtnetlink.c:3581

rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3594
rtnetlink_rcv_msg+0x43e/0xca0 net/core/rtnetlink.c:6091
netlink_rcv_skb+0x157/0x430 net/netlink/af_netlink.c:2540
netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1345
netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1921
sock_sendmsg_nosec net/socket.c:714 [inline]
sock_sendmsg+0xd3/0x120 net/socket.c:734

____sys_sendmsg+0x712/0x8c0 net/socket.c:2482
___sys_sendmsg+0x110/0x1b0 net/socket.c:2536

__sys_sendmsg+0xf7/0x1c0 net/socket.c:2565
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f2d5511cab9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffddb541428 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000003d335 RCX: 00007f2d5511cab9

RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000000000004

RBP: 0000000000000000 R08: 00007ffddb5415c8 R09: 00007ffddb5415c8
R10: 00007ffddb5415c8 R11: 0000000000000246 R12: 00007ffddb54143c
R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
</TASK>
team968: Port device batadv968 added

[Hillf Danton]

On 21 Nov 2022 23:57:36 -0800

> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 9ab000d9ac54 Merge branch 'nfc-leaks'
> git tree: net
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=178f3db5880000
> kernel config: https://syzkaller.appspot.com/x/.config?x=6f4e5e9899396248
> dashboard link: https://syzkaller.appspot.com/bug?extid=b04c9ffbbd2f303d00d9
> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15051edd880000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15b9d365880000

If lifting up LOCKDEP_BITS is a cure to the BUG, set it to 20 by default
for syzbot?

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git 9ab000d9ac54

--- x/lib/Kconfig.debug
+++ y/lib/Kconfig.debug
@@ -1396,7 +1396,7 @@ config LOCKDEP_BITS
int "Bitsize for MAX_LOCKDEP_ENTRIES"
depends on LOCKDEP && !LOCKDEP_SMALL
range 10 30
- default 15
+ default 20
help
Try increasing this value if you hit "BUG: MAX_LOCKDEP_ENTRIES too low!" message.

--

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
BUG: MAX_LOCKDEP_ENTRIES too low!

BUG: MAX_LOCKDEP_ENTRIES too low!
turning off the locking correctness validator.

CPU: 0 PID: 7529 Comm: syz-executor.0 Not tainted 6.1.0-rc5-syzkaller-00128-g9ab000d9ac54-dirty #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106
alloc_list_entry.cold+0x11/0x18 kernel/locking/lockdep.c:1402
add_lock_to_list kernel/locking/lockdep.c:1423 [inline]
check_prev_add kernel/locking/lockdep.c:3167 [inline]
check_prevs_add kernel/locking/lockdep.c:3216 [inline]
validate_chain kernel/locking/lockdep.c:3831 [inline]
__lock_acquire+0x3626/0x56d0 kernel/locking/lockdep.c:5055
lock_acquire kernel/locking/lockdep.c:5668 [inline]
lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633

__raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
_raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154
__queue_work+0x367/0x13b0 kernel/workqueue.c:1474
__queue_delayed_work+0x1c8/0x270 kernel/workqueue.c:1665
mod_delayed_work_on+0xe1/0x220 kernel/workqueue.c:1739
mod_delayed_work include/linux/workqueue.h:533 [inline]
addrconf_mod_dad_work net/ipv6/addrconf.c:330 [inline]
addrconf_dad_start net/ipv6/addrconf.c:4065 [inline]
addrconf_add_linklocal+0x323/0x590 net/ipv6/addrconf.c:3219
addrconf_addr_gen+0x37e/0x3d0 net/ipv6/addrconf.c:3346
addrconf_dev_config+0x255/0x410 net/ipv6/addrconf.c:3391
addrconf_notify+0xee0/0x1c80 net/ipv6/addrconf.c:3635

RIP: 0033:0x7fe80a28c189
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe80af9c168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fe80a3abf80 RCX: 00007fe80a28c189
RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000000000005
RBP: 00007fe80a2e7b01 R08: 0000000000000000 R09: 0000000000000000

R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000

R13: 00007ffd2b4ff61f R14: 00007fe80af9c300 R15: 0000000000022000
</TASK>
8021q: adding VLAN 0 to HW filter on device batadv1338
team1336: Port device batadv1338 added


Tested on:

commit: 9ab000d9 Merge branch 'nfc-leaks'
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
console output: https://syzkaller.appspot.com/x/log.txt?x=1517350d880000

kernel config: https://syzkaller.appspot.com/x/.config?x=6f4e5e9899396248
dashboard link: https://syzkaller.appspot.com/bug?extid=b04c9ffbbd2f303d00d9
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

patch: https://syzkaller.appspot.com/x/patch.diff?x=11451edd880000