[syzbot] WARNING in i2cdev_detach_adapter

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: e77a830c Merge branch 'akpm' (patches from Andrew)
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=119458aed00000
kernel config: https://syzkaller.appspot.com/x/.config?x=c0a6882014fd3d45
dashboard link: https://syzkaller.appspot.com/bug?extid=8c9d567bbd8a4ed98b55
compiler: Debian clang version 11.0.1-2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=166354cdd00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17b89bbdd00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8c9d56...@syzkaller.appspotmail.com

pvrusb2: Attached sub-driver cx25840
pvrusb2: ***WARNING*** pvrusb2 device hardware appears to be jammed and I can't clear it.
pvrusb2: You might need to power cycle the pvrusb2 device in order to recover.
------------[ cut here ]------------
sysfs group 'power' not found for kobject 'i2c-1'
WARNING: CPU: 1 PID: 3952 at fs/sysfs/group.c:281 sysfs_remove_group+0x16e/0x280 fs/sysfs/group.c:279
Modules linked in:
CPU: 1 PID: 3952 Comm: pvrusb2-context Not tainted 5.12.0-rc8-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:sysfs_remove_group+0x16e/0x280 fs/sysfs/group.c:279
Code: 89 e0 48 c1 e8 03 42 80 3c 28 00 74 08 4c 89 e7 e8 57 da c8 ff 49 8b 14 24 48 c7 c7 c0 1b 22 8a 4c 89 f6 31 c0 e8 32 bc 4e ff <0f> 0b 5b 41 5c 41 5d 41 5e 41 5f 5d c3 e8 a0 59 82 ff 49 8d 5e 20
RSP: 0018:ffffc9000307f988 EFLAGS: 00010246
RAX: b99ebc47a3964000 RBX: ffff88802fb9e048 RCX: ffff88801def9c40
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 1ffffffff1519c68 R08: ffffffff8164f2f2 R09: ffffed10173a3f1c
R10: ffffed10173a3f1c R11: 0000000000000000 R12: ffff88802fb9e018
R13: dffffc0000000000 R14: ffffffff8a8ce300 R15: ffff888013f9b488
FS: 0000000000000000(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007efda09df018 CR3: 0000000025e72000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
device_del+0x2ed/0xc10 drivers/base/core.c:3398
cdev_device_del+0x22/0xe0 fs/char_dev.c:573
put_i2c_dev drivers/i2c/i2c-dev.c:93 [inline]
i2cdev_detach_adapter+0x24f/0x2c0 drivers/i2c/i2c-dev.c:689
i2cdev_notifier_call+0x38/0x60 drivers/i2c/i2c-dev.c:704
notifier_call_chain kernel/notifier.c:83 [inline]
blocking_notifier_call_chain+0x108/0x1b0 kernel/notifier.c:337
device_del+0x2de/0xc10 drivers/base/core.c:3395
device_unregister+0x1a/0xc0 drivers/base/core.c:3454
i2c_del_adapter+0x370/0x7f0 drivers/i2c/i2c-core-base.c:1693
pvr2_i2c_core_done+0x55/0xb0 drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c:652
pvr2_hdw_destroy+0x150/0x2b0 drivers/media/usb/pvrusb2/pvrusb2-hdw.c:2679
pvr2_context_destroy+0x7a/0x3c0 drivers/media/usb/pvrusb2/pvrusb2-context.c:70
pvr2_context_check drivers/media/usb/pvrusb2/pvrusb2-context.c:137 [inline]
pvr2_context_thread_func+0x41d/0xb30 drivers/media/usb/pvrusb2/pvrusb2-context.c:158
kthread+0x39a/0x3c0 kernel/kthread.c:292
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in pvr2_i2c_core_done

------------[ cut here ]------------
sysfs group 'power' not found for kobject '1-0044'
WARNING: CPU: 0 PID: 3956 at fs/sysfs/group.c:281 sysfs_remove_group+0x16e/0x280 fs/sysfs/group.c:279
Modules linked in:
CPU: 0 PID: 3956 Comm: pvrusb2-context Not tainted 5.13.0-rc2-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:sysfs_remove_group+0x16e/0x280 fs/sysfs/group.c:279

Code: 89 e0 48 c1 e8 03 42 80 3c 28 00 74 08 4c 89 e7 e8 37 2a c8 ff 49 8b 14 24 48 c7 c7 00 7a 22 8a 4c 89 f6 31 c0 e8 f2 a4 4c ff <0f> 0b 5b 41 5c 41 5d 41 5e 41 5f 5d c3 e8 f0 54 80 ff 49 8d 5e 20
RSP: 0018:ffffc90002f7fa68 EFLAGS: 00010246
RAX: 00747b04ec89d300 RBX: ffff888025b32050 RCX: ffff88801e259c40

RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000

RBP: 1ffffffff151c098 R08: ffffffff81654e02 R09: ffffed1017385f90
R10: ffffed1017385f90 R11: 0000000000000000 R12: ffff888025b32020
R13: dffffc0000000000 R14: ffffffff8a8e0480 R15: ffff8880240b62b8
FS: 0000000000000000(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 000055d38dc07188 CR3: 0000000013dd5000 CR4: 00000000001506f0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:

device_del+0x2ed/0xc10 drivers/base/core.c:3485
device_unregister+0x1a/0xc0 drivers/base/core.c:3541
__unregister_client+0x6d/0x90 drivers/i2c/i2c-core-base.c:1637
device_for_each_child+0xeb/0x160 drivers/base/core.c:3641
i2c_del_adapter+0x216/0x690 drivers/i2c/i2c-core-base.c:1700

pvr2_i2c_core_done+0x55/0xb0 drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c:652
pvr2_hdw_destroy+0x150/0x2b0 drivers/media/usb/pvrusb2/pvrusb2-hdw.c:2679
pvr2_context_destroy+0x7a/0x3c0 drivers/media/usb/pvrusb2/pvrusb2-context.c:70
pvr2_context_check drivers/media/usb/pvrusb2/pvrusb2-context.c:137 [inline]
pvr2_context_thread_func+0x41d/0xb30 drivers/media/usb/pvrusb2/pvrusb2-context.c:158

kthread+0x39a/0x3c0 kernel/kthread.c:313
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294


Tested on:

commit: d07f6ca9 Linux 5.13-rc2
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=122e463bd00000
kernel config: https://syzkaller.appspot.com/x/.config?x=898d7e913dce3360

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+8c9d56...@syzkaller.appspotmail.com

Tested on:

commit: c3d0e3fd Merge tag 'fs.idmapped.mount_setattr.v5.13-rc3' o..
git tree: upstream

kernel config: https://syzkaller.appspot.com/x/.config?x=898d7e913dce3360
dashboard link: https://syzkaller.appspot.com/bug?extid=8c9d567bbd8a4ed98b55
compiler: Debian clang version 11.0.1-2

patch: https://syzkaller.appspot.com/x/patch.diff?x=17cbc8a3d00000

Note: testing is done by a robot and is best-effort only.

[syzbot]

Auto-closing this bug as obsolete.
No recent activity, existing reproducers are no longer triggering the issue.