[syzbot] [ntfs3?] WARNING in ntfs_fill_super (2)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: f7d2388eeec2 Add linux-next specific files for 20251028
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=15edde7c580000
kernel config: https://syzkaller.appspot.com/x/.config?x=ecdce5bceba74f
dashboard link: https://syzkaller.appspot.com/bug?extid=2e6c1eda2eff0745b028
compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=116e6704580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11198fe2580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/8aa0aaa475d1/disk-f7d2388e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/fc97cba5a8b0/vmlinux-f7d2388e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/30e4617d837c/bzImage-f7d2388e.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/7f2ed67d49f3/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+2e6c1e...@syzkaller.appspotmail.com

loop0: detected capacity change from 0 to 4096
ntfs3(loop0): Different NTFS sector size (4096) and media sector size (512).
ntfs3(loop0): $Secure::$SII is corrupted.
ntfs3(loop0): Failed to initialize $Secure (-22).
------------[ cut here ]------------
WARNING: mm/slub.c:6752 at free_large_kmalloc+0x15c/0x1f0 mm/slub.c:6752, CPU#1: syz.0.17/5997
Modules linked in:
CPU: 1 UID: 0 PID: 5997 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
RIP: 0010:free_large_kmalloc+0x15c/0x1f0 mm/slub.c:6752
Code: 44 89 f6 e8 16 d1 fc ff 65 48 8b 05 1e c3 57 10 48 3b 44 24 08 75 57 48 83 c4 10 5b 41 5c 41 5e 41 5f 5d e9 86 7b 3b 09 cc 90 <0f> 0b 90 65 48 8b 05 f9 c2 57 10 48 3b 44 24 08 75 32 48 89 df 48
RSP: 0018:ffffc90003a3f880 EFLAGS: 00010206
RAX: 00000000ff000000 RBX: ffffea0000389000 RCX: ffffea0000389008
RDX: 0000000000000000 RSI: ffffffff8e240de0 RDI: ffffea0000389000
RBP: ffffc90003a3fbb0 R08: ffffc90003a3f4a7 R09: 1ffff92000747e94
R10: dffffc0000000000 R11: fffff52000747e95 R12: 0000000000000000
R13: 00000000ffffffea R14: dffffc0000000000 R15: ffff88807b48e9b0
FS: 0000555574161500(0000) GS:ffff888125feb000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fe9d639d000 CR3: 000000007fa22000 CR4: 00000000003526f0
Call Trace:
<TASK>
ntfs_fill_super+0x656/0x43d0 fs/ntfs3/super.c:1674
get_tree_bdev_flags+0x40e/0x4d0 fs/super.c:1691
vfs_get_tree+0x92/0x2b0 fs/super.c:1751
fc_mount fs/namespace.c:1208 [inline]
do_new_mount_fc fs/namespace.c:3651 [inline]
do_new_mount+0x302/0xa10 fs/namespace.c:3727
do_mount fs/namespace.c:4050 [inline]
__do_sys_mount fs/namespace.c:4238 [inline]
__se_sys_mount+0x313/0x410 fs/namespace.c:4215
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f9eef39076a
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd8b15b1b8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffd8b15b240 RCX: 00007f9eef39076a
RDX: 0000200000000100 RSI: 0000200000000140 RDI: 00007ffd8b15b200
RBP: 0000200000000100 R08: 00007ffd8b15b240 R09: 0000000002200010
R10: 0000000002200010 R11: 0000000000000246 R12: 0000200000000140
R13: 00007ffd8b15b200 R14: 000000000001f2b6 R15: 0000200000000780
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has bisected this issue to:

commit 02f312754c873efe076888a2fdca982e56617929
Author: YangWen <anmux...@gmail.com>
Date: Wed Sep 10 15:17:08 2025 +0000

ntfs3: fix use-after-free of sbi->options in cmp_fnames

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11825f34580000
start commit: f7d2388eeec2 Add linux-next specific files for 20251028
git tree: linux-next
final oops: https://syzkaller.appspot.com/x/report.txt?x=13825f34580000
console output: https://syzkaller.appspot.com/x/log.txt?x=15825f34580000

kernel config: https://syzkaller.appspot.com/x/.config?x=ecdce5bceba74f
dashboard link: https://syzkaller.appspot.com/bug?extid=2e6c1eda2eff0745b028

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=116e6704580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11198fe2580000

Reported-by: syzbot+2e6c1e...@syzkaller.appspotmail.com
Fixes: 02f312754c87 ("ntfs3: fix use-after-free of sbi->options in cmp_fnames")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[syzbot]

For archival purposes, forwarding an incoming command email to
linux-...@vger.kernel.org, syzkall...@googlegroups.com.

***

Subject:
Author: jkoo...@xs4all.nl

#syz test

---

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index aae1f32f4dab..f193912d8632 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -704,8 +704,8 @@ static void ntfs_put_super(struct super_block *sb)
ntfs_set_state(sbi, NTFS_DIRTY_CLEAR);

if (sbi->options) {
+ kfree(sbi->options->nls_name);
unload_nls(sbi->options->nls);
- kfree(sbi->options->nls);
kfree(sbi->options);
sbi->options = NULL;
}
@@ -1670,8 +1670,8 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
iput(inode);
out:
if (sbi && sbi->options) {
+ kfree(sbi->options->nls_name);
unload_nls(sbi->options->nls);
- kfree(sbi->options->nls);
kfree(sbi->options);
sbi->options = NULL;
}

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in get_data

loop0: detected capacity change from 0 to 4096
ntfs3(loop0): Different NTFS sector size (4096) and media sector size (512).

------------[ cut here ]------------
WARNING: kernel/printk/printk_ringbuffer.c:1278 at get_data+0x48a/0x840 kernel/printk/printk_ringbuffer.c:1278, CPU#1: syz.0.359/7136
Modules linked in:
CPU: 1 UID: 0 PID: 7136 Comm: syz.0.359 Not tainted syzkaller #0 PREEMPT(full)

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025

RIP: 0010:get_data+0x48a/0x840 kernel/printk/printk_ringbuffer.c:1278
Code: 83 c4 f8 48 b8 00 00 00 00 00 fc ff df 41 0f b6 04 07 84 c0 0f 85 ee 01 00 00 44 89 65 00 49 83 c5 08 eb 13 e8 b7 d6 1e 00 90 <0f> 0b 90 eb 05 e8 ac d6 1e 00 45 31 ed 4c 89 e8 48 83 c4 28 5b 41
RSP: 0018:ffffc9000bc46e00 EFLAGS: 00010293
RAX: ffffffff81a1af09 RBX: 00003fffffffffff RCX: ffff88801d389e40
RDX: 0000000000000000 RSI: 00003fffffffffff RDI: 0000000000000000
RBP: 0000000000000012 R08: 0000000000000f1e R09: 00000029b9da0681
R10: 00000029b9da0681 R11: 00001be062000029 R12: 0000000000000012
R13: 0000000000000000 R14: ffffc9000bc46f48 R15: 1ffffffff1bcab06
FS: 00007f01589546c0(0000) GS:ffff888125fe2000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007f6b9ec23000 CR3: 000000003328e000 CR4: 00000000003526f0
Call Trace:
<TASK>
copy_data kernel/printk/printk_ringbuffer.c:1857 [inline]
prb_read kernel/printk/printk_ringbuffer.c:1966 [inline]
_prb_read_valid+0x672/0xa90 kernel/printk/printk_ringbuffer.c:2143
prb_read_valid+0x3c/0x60 kernel/printk/printk_ringbuffer.c:2215
printk_get_next_message+0x15c/0x7b0 kernel/printk/printk.c:2978
console_emit_next_record kernel/printk/printk.c:3062 [inline]
console_flush_one_record kernel/printk/printk.c:3194 [inline]
console_flush_all+0x4cc/0xb10 kernel/printk/printk.c:3268
__console_flush_and_unlock kernel/printk/printk.c:3298 [inline]
console_unlock+0xbb/0x190 kernel/printk/printk.c:3338
vprintk_emit+0x4c5/0x590 kernel/printk/printk.c:2423
_printk+0xcf/0x120 kernel/printk/printk.c:2448
ntfs_printk+0x3b3/0x440 fs/ntfs3/super.c:100
ntfs_security_init+0x644/0xc40 fs/ntfs3/fsntfs.c:1910
ntfs_fill_super+0x3f35/0x43d0 fs/ntfs3/super.c:1586
get_tree_bdev_flags+0x40e/0x4d0 fs/super.c:1692
vfs_get_tree+0x92/0x2b0 fs/super.c:1752
fc_mount fs/namespace.c:1198 [inline]
do_new_mount_fc fs/namespace.c:3641 [inline]
do_new_mount+0x302/0xa10 fs/namespace.c:3717
do_mount fs/namespace.c:4040 [inline]
__do_sys_mount fs/namespace.c:4228 [inline]
__se_sys_mount+0x313/0x410 fs/namespace.c:4205

do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f

RIP: 0033:0x7f0157b9076a

Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48

RSP: 002b:00007f0158953e68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f0158953ef0 RCX: 00007f0157b9076a
RDX: 0000200000000100 RSI: 0000200000000140 RDI: 00007f0158953eb0
RBP: 0000200000000100 R08: 00007f0158953ef0 R09: 0000000002200010

R10: 0000000002200010 R11: 0000000000000246 R12: 0000200000000140

R13: 00007f0158953eb0 R14: 000000000001f2b6 R15: 0000200000000780
</TASK>


Tested on:

commit: 98bd8b16 Add linux-next specific files for 20251031
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1653a342580000
kernel config: https://syzkaller.appspot.com/x/.config?x=63d09725c93bcc1c

dashboard link: https://syzkaller.appspot.com/bug?extid=2e6c1eda2eff0745b028
compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8

patch: https://syzkaller.appspot.com/x/patch.diff?x=1226a012580000

[syzbot]

For archival purposes, forwarding an incoming command email to
linux-...@vger.kernel.org, syzkall...@googlegroups.com.

***

Subject:
Author: jkoo...@xs4all.nl

#syz dup: WARNING in ntfs_put_super