[syzbot] WARNING in ieee80211_free_ack_frame (2)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 89d714ab6043 Merge tag 'linux-watchdog-5.16-rc1' of git://..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=108e7c3eb00000
kernel config: https://syzkaller.appspot.com/x/.config?x=dcce4e862d74e466
dashboard link: https://syzkaller.appspot.com/bug?extid=ac648b0525be1feba506
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ac648b...@syzkaller.appspotmail.com

netdevsim netdevsim1 netdevsim2 (unregistering): unset [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim1 netdevsim1 (unregistering): unset [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim1 netdevsim0 (unregistering): unset [1, 0] type 2 family 0 port 6081 - 0
------------[ cut here ]------------
Have pending ack frames!
WARNING: CPU: 0 PID: 10 at net/mac80211/main.c:1419 ieee80211_free_ack_frame+0x48/0x50 net/mac80211/main.c:1419
Modules linked in:
CPU: 0 PID: 10 Comm: kworker/u4:1 Not tainted 5.15.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: netns cleanup_net
RIP: 0010:ieee80211_free_ack_frame+0x48/0x50 net/mac80211/main.c:1419
Code: e8 0d dc f3 f8 48 89 ef e8 d5 c6 97 fe 31 c0 5b 5d c3 e8 fb db f3 f8 48 c7 c7 00 9b ab 8a c6 05 b3 00 d8 04 01 e8 89 e9 72 00 <0f> 0b eb d2 0f 1f 40 00 41 57 41 56 49 89 f6 41 55 41 54 49 89 d4
RSP: 0018:ffffc90000f0f9d8 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff888011c3c280 RSI: ffffffff815e6b88 RDI: fffff520001e1f2d
RBP: ffff8880781a6000 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff815e095e R11: 0000000000000000 R12: dffffc0000000000
R13: ffffffff888320f0 R14: 0000000000000000 R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055c247c48cf0 CR3: 0000000021d96000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
idr_for_each+0x113/0x220 lib/idr.c:208
ieee80211_free_hw+0x9b/0x2b0 net/mac80211/main.c:1435
mac80211_hwsim_del_radio drivers/net/wireless/mac80211_hwsim.c:3586 [inline]
hwsim_exit_net+0x55f/0xca0 drivers/net/wireless/mac80211_hwsim.c:4346
ops_exit_list+0xb0/0x160 net/core/net_namespace.c:168
cleanup_net+0x4ea/0xb00 net/core/net_namespace.c:593
process_one_work+0x9b2/0x1690 kernel/workqueue.c:2298
worker_thread+0x658/0x11f0 kernel/workqueue.c:2445
kthread+0x405/0x4f0 kernel/kthread.c:327
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 33189f0a94b9 r8169: fix RTL8168H and RTL8107E rx crc error
git tree: net
console+strace: https://syzkaller.appspot.com/x/log.txt?x=12857025c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=ea09b0836073ee4

dashboard link: https://syzkaller.appspot.com/bug?extid=ac648b0525be1feba506
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15346b1ec80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=162e3b89c80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/62cbf0a881e9/disk-33189f0a.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/57e9b6d3facf/vmlinux-33189f0a.xz
kernel image: https://storage.googleapis.com/syzbot-assets/3bd33096e2d8/bzImage-33189f0a.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ac648b...@syzkaller.appspotmail.com

WARNING: CPU: 1 PID: 75 at net/mac80211/main.c:1509 ieee80211_free_ack_frame+0x51/0x60 net/mac80211/main.c:1509
Modules linked in:
CPU: 1 PID: 75 Comm: kworker/u4:4 Not tainted 6.3.0-rc3-syzkaller-00156-g33189f0a94b9 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Workqueue: netns cleanup_net
RIP: 0010:ieee80211_free_ack_frame+0x51/0x60 net/mac80211/main.c:1509
Code: 48 89 ef be 02 00 00 00 e8 cc 42 88 fe 31 c0 5b 5d c3 e8 12 27 0b f8 48 c7 c7 80 cb 7c 8b c6 05 eb 8a ea 04 01 e8 af a0 d3 f7 <0f> 0b eb cd 66 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 41 57 41
RSP: 0018:ffffc900015879d8 EFLAGS: 00010286

RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000

RDX: ffff888018999d40 RSI: ffffffff814b6037 RDI: 0000000000000001
RBP: ffff88807258c280 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000000 R12: dffffc0000000000
R13: ffffffff8977bdb0 R14: 0000000000000000 R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 000056122f357fc8 CR3: 000000001de5f000 CR4: 00000000003506e0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>

idr_for_each+0x117/0x230 lib/idr.c:208
ieee80211_free_hw+0xa1/0x2f0 net/mac80211/main.c:1527
mac80211_hwsim_del_radio drivers/net/wireless/mac80211_hwsim.c:4687 [inline]
hwsim_exit_net+0x463/0x840 drivers/net/wireless/mac80211_hwsim.c:5470
ops_exit_list+0xb0/0x170 net/core/net_namespace.c:169
cleanup_net+0x4ee/0xb10 net/core/net_namespace.c:613
process_one_work+0x991/0x15c0 kernel/workqueue.c:2390
worker_thread+0x669/0x1090 kernel/workqueue.c:2537
kthread+0x2e8/0x3a0 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
</TASK>

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 1661372c912d1966e21e0cb5463559984df8249b
Author: Paul Moore <pa...@paul-moore.com>
Date: Tue Feb 7 22:06:51 2023 +0000

lsm: move the program execution hook comments to security/security.c

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1024a074a80000
start commit: 33189f0a94b9 r8169: fix RTL8168H and RTL8107E rx crc error
git tree: net

kernel config: https://syzkaller.appspot.com/x/.config?x=ea09b0836073ee4
dashboard link: https://syzkaller.appspot.com/bug?extid=ac648b0525be1feba506

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15346b1ec80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=162e3b89c80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: lsm: move the program execution hook comments to security/security.c

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Aleksandr Nogikh]

On Thu, Jul 13, 2023 at 7:49 PM syzbot
<syzbot+ac648b...@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit 1661372c912d1966e21e0cb5463559984df8249b
> Author: Paul Moore <pa...@paul-moore.com>
> Date: Tue Feb 7 22:06:51 2023 +0000
>
> lsm: move the program execution hook comments to security/security.c
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1024a074a80000
> start commit: 33189f0a94b9 r8169: fix RTL8168H and RTL8107E rx crc error
> git tree: net
> kernel config: https://syzkaller.appspot.com/x/.config?x=ea09b0836073ee4
> dashboard link: https://syzkaller.appspot.com/bug?extid=ac648b0525be1feba506
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15346b1ec80000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=162e3b89c80000
>
> If the result looks correct, please mark the issue as fixed by replying with:

No, this one is invalid.

>
> #syz fix: lsm: move the program execution hook comments to security/security.c
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>

> --

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in ieee80211_free_ack_frame

netdevsim netdevsim3 netdevsim2 (unregistering): unset [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim3 netdevsim1 (unregistering): unset [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim3 netdevsim0 (unregistering): unset [1, 0] type 2 family 0 port 6081 - 0

------------[ cut here ]------------
Have pending ack frames!

WARNING: CPU: 1 PID: 9 at net/mac80211/main.c:1509 ieee80211_free_ack_frame+0x52/0x60 net/mac80211/main.c:1509
Modules linked in:
CPU: 1 PID: 9 Comm: kworker/u4:0 Not tainted 6.3.0-syzkaller-00076-g08e30833f86b #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/03/2023
Workqueue: netns cleanup_net
RIP: 0010:ieee80211_free_ack_frame+0x52/0x60 net/mac80211/main.c:1509
Code: 48 89 df be 02 00 00 00 e8 bb 95 86 fe 31 c0 5b 5d c3 e8 51 59 06 f8 48 c7 c7 c0 0d 7e 8b c6 05 c1 13 e6 04 01 e8 ae 99 ce f7 <0f> 0b eb cd 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 41 57 41 56
RSP: 0018:ffffc900000e7a20 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff888021037a00 RCX: 0000000000000000
RDX: ffff8880167b8000 RSI: ffffffff814be777 RDI: 0000000000000001
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: fffffffffffe2f80 R12: dffffc0000000000
R13: ffffffff897d4bf0 R14: 0000000080000000 R15: 0000000000000000

FS: 0000000000000000(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007f7e12bc31b0 CR3: 000000007d540000 CR4: 00000000003506e0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>

idr_for_each+0x11d/0x240 lib/idr.c:208
ieee80211_free_hw+0xb2/0x2f0 net/mac80211/main.c:1527
mac80211_hwsim_del_radio drivers/net/wireless/mac80211_hwsim.c:4687 [inline]
hwsim_exit_net+0x3f9/0x7d0 drivers/net/wireless/mac80211_hwsim.c:5470
ops_exit_list+0xb0/0x170 net/core/net_namespace.c:169
cleanup_net+0x505/0xb20 net/core/net_namespace.c:613
process_one_work+0x9f0/0x15d0 kernel/workqueue.c:2390
worker_thread+0x67d/0x10e0 kernel/workqueue.c:2537
kthread+0x2e4/0x3a0 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
</TASK>


Tested on:

commit: 08e30833 Merge tag 'lsm-pr-20230420' of git://git.kern..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=169edfb4a80000
kernel config: https://syzkaller.appspot.com/x/.config?x=fcc880587d8b6204
dashboard link: https://syzkaller.appspot.com/bug?extid=ac648b0525be1feba506
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.