[syzbot] [bcachefs?] KMSAN: uninit-value in bch2_bkey_val_validate

10 views
Skip to first unread message

syzbot

unread,
Nov 29, 2024, 11:59:28 AM11/29/24
to kent.ov...@linux.dev, linux-b...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 9f16d5e6f220 Merge tag 'for-linus' of git://git.kernel.org..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1465dee8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=ce1e2eda2213557
dashboard link: https://syzkaller.appspot.com/bug?extid=09c915024af5057b77da
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2fcdec73c0f3/disk-9f16d5e6.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/d4dc8d1847e1/vmlinux-9f16d5e6.xz
kernel image: https://storage.googleapis.com/syzbot-assets/db0e04822d2c/bzImage-9f16d5e6.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+09c915...@syzkaller.appspotmail.com

done
bcachefs (loop2): going read-write
bcachefs (loop2): journal_replay...
=====================================================
BUG: KMSAN: uninit-value in bch2_backpointer_validate+0x63a/0x8f0 fs/bcachefs/backpointers.c:57
bch2_backpointer_validate+0x63a/0x8f0 fs/bcachefs/backpointers.c:57
bch2_bkey_val_validate+0x2b5/0x440 fs/bcachefs/bkey_methods.c:143
bset_key_validate fs/bcachefs/btree_io.c:841 [inline]
validate_bset_keys+0x1531/0x2080 fs/bcachefs/btree_io.c:910
validate_bset_for_write+0x142/0x290 fs/bcachefs/btree_io.c:1942
__bch2_btree_node_write+0x53df/0x6830 fs/bcachefs/btree_io.c:2152
bch2_btree_node_write+0xa5/0x2e0 fs/bcachefs/btree_io.c:2284
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush1+0x38/0x60 fs/bcachefs/btree_trans_commit.c:266
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
journal_flush_done+0x156/0x3f0 fs/bcachefs/journal_reclaim.c:822
bch2_journal_flush_pins+0x2a9/0x3b0 fs/bcachefs/journal_reclaim.c:852
bch2_journal_flush_all_pins fs/bcachefs/journal_reclaim.h:76 [inline]
bch2_journal_replay+0x4937/0x4d30 fs/bcachefs/recovery.c:383
bch2_run_recovery_pass fs/bcachefs/recovery_passes.c:191 [inline]
bch2_run_recovery_passes+0xaf9/0xf80 fs/bcachefs/recovery_passes.c:244
bch2_fs_recovery+0x447b/0x5b00 fs/bcachefs/recovery.c:861
bch2_fs_start+0x7b2/0xbd0 fs/bcachefs/super.c:1037
bch2_fs_get_tree+0x13ea/0x22d0 fs/bcachefs/fs.c:2170
vfs_get_tree+0xb1/0x5a0 fs/super.c:1814
do_new_mount+0x71f/0x15e0 fs/namespace.c:3507
path_mount+0x742/0x1f10 fs/namespace.c:3834
do_mount fs/namespace.c:3847 [inline]
__do_sys_mount fs/namespace.c:4057 [inline]
__se_sys_mount+0x722/0x810 fs/namespace.c:4034
__x64_sys_mount+0xe4/0x150 fs/namespace.c:4034
x64_sys_call+0x39bf/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:166
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

Uninit was stored to memory at:
memcpy_u64s_small fs/bcachefs/util.h:393 [inline]
bkey_p_copy fs/bcachefs/bkey.h:47 [inline]
bch2_sort_keys_keep_unwritten_whiteouts+0x12d5/0x19d0 fs/bcachefs/bkey_sort.c:187
__bch2_btree_node_write+0x3ae8/0x6830 fs/bcachefs/btree_io.c:2095
bch2_btree_node_write+0xa5/0x2e0 fs/bcachefs/btree_io.c:2284
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush1+0x38/0x60 fs/bcachefs/btree_trans_commit.c:266
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
journal_flush_done+0x156/0x3f0 fs/bcachefs/journal_reclaim.c:822
bch2_journal_flush_pins+0x2a9/0x3b0 fs/bcachefs/journal_reclaim.c:852
bch2_journal_flush_all_pins fs/bcachefs/journal_reclaim.h:76 [inline]
bch2_journal_replay+0x4937/0x4d30 fs/bcachefs/recovery.c:383
bch2_run_recovery_pass fs/bcachefs/recovery_passes.c:191 [inline]
bch2_run_recovery_passes+0xaf9/0xf80 fs/bcachefs/recovery_passes.c:244
bch2_fs_recovery+0x447b/0x5b00 fs/bcachefs/recovery.c:861
bch2_fs_start+0x7b2/0xbd0 fs/bcachefs/super.c:1037
bch2_fs_get_tree+0x13ea/0x22d0 fs/bcachefs/fs.c:2170
vfs_get_tree+0xb1/0x5a0 fs/super.c:1814
do_new_mount+0x71f/0x15e0 fs/namespace.c:3507
path_mount+0x742/0x1f10 fs/namespace.c:3834
do_mount fs/namespace.c:3847 [inline]
__do_sys_mount fs/namespace.c:4057 [inline]
__se_sys_mount+0x722/0x810 fs/namespace.c:4034
__x64_sys_mount+0xe4/0x150 fs/namespace.c:4034
x64_sys_call+0x39bf/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:166
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

Uninit was created at:
___kmalloc_large_node+0x22c/0x370 mm/slub.c:4219
__kmalloc_large_node_noprof+0x3f/0x1e0 mm/slub.c:4236
__do_kmalloc_node mm/slub.c:4252 [inline]
__kmalloc_node_noprof+0x9d6/0xf50 mm/slub.c:4270
__kvmalloc_node_noprof+0xc0/0x2d0 mm/util.c:658
btree_bounce_alloc fs/bcachefs/btree_io.c:124 [inline]
btree_node_sort+0x78a/0x1d30 fs/bcachefs/btree_io.c:323
bch2_btree_post_write_cleanup+0x1b0/0xf20 fs/bcachefs/btree_io.c:2248
bch2_btree_node_write+0x21c/0x2e0 fs/bcachefs/btree_io.c:2289
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush0+0x35/0x60 fs/bcachefs/btree_trans_commit.c:261
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
journal_flush_done+0x156/0x3f0 fs/bcachefs/journal_reclaim.c:822
bch2_journal_flush_pins+0x2a9/0x3b0 fs/bcachefs/journal_reclaim.c:852
bch2_journal_flush_all_pins fs/bcachefs/journal_reclaim.h:76 [inline]
bch2_journal_replay+0x4937/0x4d30 fs/bcachefs/recovery.c:383
bch2_run_recovery_pass fs/bcachefs/recovery_passes.c:191 [inline]
bch2_run_recovery_passes+0xaf9/0xf80 fs/bcachefs/recovery_passes.c:244
bch2_fs_recovery+0x447b/0x5b00 fs/bcachefs/recovery.c:861
bch2_fs_start+0x7b2/0xbd0 fs/bcachefs/super.c:1037
bch2_fs_get_tree+0x13ea/0x22d0 fs/bcachefs/fs.c:2170
vfs_get_tree+0xb1/0x5a0 fs/super.c:1814
do_new_mount+0x71f/0x15e0 fs/namespace.c:3507
path_mount+0x742/0x1f10 fs/namespace.c:3834
do_mount fs/namespace.c:3847 [inline]
__do_sys_mount fs/namespace.c:4057 [inline]
__se_sys_mount+0x722/0x810 fs/namespace.c:4034
__x64_sys_mount+0xe4/0x150 fs/namespace.c:4034
x64_sys_call+0x39bf/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:166
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

CPU: 1 UID: 0 PID: 6059 Comm: syz.2.30 Not tainted 6.12.0-syzkaller-09073-g9f16d5e6f220 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
=====================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

syzbot

unread,
Dec 5, 2024, 4:19:24 PM12/5/24
to kent.ov...@linux.dev, linux-b...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: feffde684ac2 Merge tag 'for-6.13-rc1-tag' of git://git.ker..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1625ade8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=96ee18b6611821ab
dashboard link: https://syzkaller.appspot.com/bug?extid=09c915024af5057b77da
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10a390f8580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1125ade8580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/b31883c9ce49/disk-feffde68.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/cd0fe66ddb61/vmlinux-feffde68.xz
kernel image: https://storage.googleapis.com/syzbot-assets/88e3455fb342/bzImage-feffde68.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/01cd3582aecd/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+09c915...@syzkaller.appspotmail.com

=====================================================
BUG: KMSAN: uninit-value in bch2_backpointer_validate+0x63a/0x8f0 fs/bcachefs/backpointers.c:57
bch2_backpointer_validate+0x63a/0x8f0 fs/bcachefs/backpointers.c:57
bch2_bkey_val_validate+0x2b5/0x440 fs/bcachefs/bkey_methods.c:143
bset_key_validate fs/bcachefs/btree_io.c:841 [inline]
validate_bset_keys+0x1531/0x2080 fs/bcachefs/btree_io.c:910
validate_bset_for_write+0x142/0x290 fs/bcachefs/btree_io.c:1942
__bch2_btree_node_write+0x53df/0x6830 fs/bcachefs/btree_io.c:2152
bch2_btree_node_write+0x256/0x2e0 fs/bcachefs/btree_io.c:2296
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush1+0x38/0x60 fs/bcachefs/btree_trans_commit.c:266
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
__bch2_journal_reclaim+0xda8/0x1670 fs/bcachefs/journal_reclaim.c:698
bch2_journal_reclaim_thread+0x18e/0x760 fs/bcachefs/journal_reclaim.c:740
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was stored to memory at:
memcpy_u64s_small fs/bcachefs/util.h:393 [inline]
bkey_p_copy fs/bcachefs/bkey.h:47 [inline]
bch2_sort_keys_keep_unwritten_whiteouts+0x12d5/0x19d0 fs/bcachefs/bkey_sort.c:187
__bch2_btree_node_write+0x3ae8/0x6830 fs/bcachefs/btree_io.c:2095
bch2_btree_node_write+0x256/0x2e0 fs/bcachefs/btree_io.c:2296
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush1+0x38/0x60 fs/bcachefs/btree_trans_commit.c:266
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
__bch2_journal_reclaim+0xda8/0x1670 fs/bcachefs/journal_reclaim.c:698
bch2_journal_reclaim_thread+0x18e/0x760 fs/bcachefs/journal_reclaim.c:740
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was created at:
___kmalloc_large_node+0x22c/0x370 mm/slub.c:4238
__kmalloc_large_node_noprof+0x3f/0x1e0 mm/slub.c:4255
__do_kmalloc_node mm/slub.c:4271 [inline]
__kmalloc_node_noprof+0xc96/0x1250 mm/slub.c:4289
__kvmalloc_node_noprof+0xc0/0x2d0 mm/util.c:650
btree_bounce_alloc fs/bcachefs/btree_io.c:124 [inline]
btree_node_sort+0x78a/0x1d30 fs/bcachefs/btree_io.c:323
bch2_btree_post_write_cleanup+0x1b0/0xf20 fs/bcachefs/btree_io.c:2248
bch2_btree_node_write+0x21c/0x2e0 fs/bcachefs/btree_io.c:2289
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush0+0x35/0x60 fs/bcachefs/btree_trans_commit.c:261
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
__bch2_journal_reclaim+0xda8/0x1670 fs/bcachefs/journal_reclaim.c:698
bch2_journal_reclaim_thread+0x18e/0x760 fs/bcachefs/journal_reclaim.c:740
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

CPU: 0 UID: 0 PID: 5790 Comm: bch-reclaim/loo Not tainted 6.13.0-rc1-syzkaller-00025-gfeffde684ac2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
=====================================================


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

syzbot

unread,
Apr 1, 2025, 12:02:37 AM4/1/25
to linux-...@vger.kernel.org, syzkall...@googlegroups.com
For archival purposes, forwarding an incoming command email to
linux-...@vger.kernel.org, syzkall...@googlegroups.com.

***

Subject:
Author: kent.ov...@linux.dev

#syz fix bcachefs: Disable asm memcpys when kmsan enabled
Reply all
Reply to author
Forward
0 new messages