Current stability of master (e2e) and JDK 11

11 views
Skip to first unread message

Maria Arias de Reyna Dominguez

unread,
Jun 30, 2020, 11:02:13 AM6/30/20
to Syndesis
Hi!

Maybe you have noticed that master has been failing the e2e nightly
tests for some days already. Bug registered:
https://github.com/syndesisio/syndesis/issues/8776 I am going to work
on this *before* the newest Camel migration.

This is also blocking automatic merges based on tests passing and approved PR.

Also, heads up on https://github.com/syndesisio/syndesis/pull/8269
that will be merged once the integration tests are fixed. This will
require an upgrade on your JDK beyond 8 *to compile* Syndesis.

Cheers!
María Arias de Reyna Domínguez
Senior Software Engineer
She / Her / Hers
ariasd...@redhat.com

Paul Richardson

unread,
Jun 30, 2020, 1:29:06 PM6/30/20
to Maria Arias de Reyna Dominguez, Syndesis
Kudos to your efforts on this Maria!

PGR

--
Paul Richardson

* p.g.ric...@redhat.com
* pgrich...@linux.com
* Ty-Carreg Barn, Penyrheol, Pontypool, Torfaen. NP4 5XZ
* (home) 01495 762483
* (mob) +44 (0)9780 869490

Maria Arias de Reyna Dominguez

unread,
Jul 1, 2020, 7:13:03 AM7/1/20
to Paul Richardson, Syndesis
Hi!

I am taking my time with this because I am highly confused on how our
pipeline worked on some PR without us detecting this. Circle CI
nightly integration tests task has been failing for almost a month
already. But the Jenkins e2e check for PR was fine? I'm very confused
:D Something must be leaking on our pipeline.

We have been accumulating errors for several weeks:
Starting here: https://circleci.com/gh/syndesisio/syndesis/347407
Full errors here: https://circleci.com/gh/syndesisio/syndesis/349103

I am working on fixing them, but I am wondering how we have been able
to merge stuff if e2e failed.

Maybe the merge was good because the PR was based on older master
branches with no conflicts, so they passed the tests and we could
merge them?
Which makes me wonder how good those tests are without a pull rebase first.

Or how else have we been able to merge, if nightly e2e with the latest
master fails? Jenkins e2e didn't fail and CircleCI did? Any ideas on
how this could have happened? Or better: how can we prevent this
further?

Maria Arias de Reyna Dominguez

unread,
Jul 1, 2020, 10:53:41 AM7/1/20
to Paul Richardson, Syndesis
Hi!

After some chatting I realized I was wrong, e2e tests were never run per PR.

So I added them as github actions:
https://github.com/syndesisio/syndesis/pull/8780 This way, we are not
adding more jobs to Circle CI and they run in parallel too.

Integration tests will haunt you from now on.

Cheers!
María.
Reply all
Reply to author
Forward
0 new messages