How to proceed when a typo is found?

86 views
Skip to first unread message

Luis Talavera

unread,
Mar 12, 2022, 10:40:04 PM3/12/22
to sympy
Hello community, I have a question about how to proceed when I find a typo. Should I raise an issue and wait for a response or directly make a pull request?  

Qijia Liu

unread,
Mar 12, 2022, 11:14:20 PM3/12/22
to sympy
Hi,
I'd recommend directly make a PR.
Qijia Liu

Luis Talavera

unread,
Mar 12, 2022, 11:23:34 PM3/12/22
to sy...@googlegroups.com
I will take your advice, thank you Qijia Liu.
Regards.

Aaron Meurer

unread,
Mar 14, 2022, 9:05:54 PM3/14/22
to sy...@googlegroups.com
If you have a change ready for something, whether it's a typo or a
bugfix or anything else, you don't need to open an issue first. The
only reason to do that is if you feel the change needs to be discussed
first before making a pull request, or if you don't actually have a
fix for it yet and just want to report the issue.

Aaron Meurer

On Sat, Mar 12, 2022 at 8:40 PM Luis Talavera
<luisfert...@gmail.com> wrote:
>
> Hello community, I have a question about how to proceed when I find a typo. Should I raise an issue and wait for a response or directly make a pull request?
>
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/327c75d7-c09c-41d8-bd8b-f74dcf07f995n%40googlegroups.com.

Luis Talavera

unread,
Mar 15, 2022, 7:02:49 PM3/15/22
to sy...@googlegroups.com
Thank you so much Aaron. I had doubts about when to open an issue but it's more clear for me now.

Reply all
Reply to author
Forward
0 new messages