I use bmatrix all the time for my matrices and I never use pmatrix, so an option
would be a good thing.
I see two possibilities. First, have a setting somewhere to choose the matrix
display type, or make it a parameter to be passed, probably with some default.
Cheers,
Tim.
---
Tim Lahey
PhD Candidate, Systems Design Engineering
University of Waterloo
http://www.linkedin.com/in/timlahey
On Mon, Jun 1, 2009 at 12:46 PM, Ryan Krauss <ryan...@gmail.com> wrote:
> So, I have something that I think is working. No idea if people who
> understand more of sympy's design than I do will think this is a good idea
> or not.
looks good. Could you please send it as a patch to sympy? We'll include it.
Thanks,
Ondrej
If it's just couple patches, do "git format-patch -1" (or -n for n
patches) and attach it to some issue manually. If it's more patches,
publish your branch on github (or anywhere else) and we'll pull it.
github actually allows to review and comment the branch online, which
is a nice feature.
Ondrej
git clone git://git.sympy.org/sympy.git
and how can I make my new github account play nicely with the fact that I already have these two changes after my clone?
Thanks,
Ryan
You can fork it from me, or you can just push everything at once, it
doesn't matter.
As to handling patches with git, you have two options. Either just
work in the master branch, then you just push everything to github,
but then when we merge it, or if some more changes are needed, or we
merge something else first into our main repository, your master
branch will then be very different to our official repository, thus
making it harder for you to work with.
Thus I recommend to work in branches, e.g. create a new branch:
git co -b ryan
work in there, commit some stuff, push to gihtub
git push github ryan
(assuming the "github" remote points to github, see "git remote -v"),
and keep you master branch always identical with our main sympy
repository.
That way you can easily work on your stuff, while you can also update
from our main repository and you can also easily rebase etc.
Ondrej