editing release notes pre-release

40 views
Skip to first unread message

Chris Smith

unread,
Feb 19, 2020, 11:06:23 PM2/19/20
to sympy
Is there a way to edit the release notes before they are finalized with a release? In other words, after commiting a PR can the release note for that PR be modified?

/c

Aaron Meurer

unread,
Feb 19, 2020, 11:28:57 PM2/19/20
to sympy
Yes, that is the whole point of putting them on the wiki. You can edit
them at any time after the bot puts them there (before or after the
release).

Aaron Meurer

On Wed, Feb 19, 2020 at 9:06 PM Chris Smith <smi...@gmail.com> wrote:
>
> Is there a way to edit the release notes before they are finalized with a release? In other words, after commiting a PR can the release note for that PR be modified?
>
> /c
>
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/8172eec5-f48d-4d46-989c-23a6459ab723%40googlegroups.com.

Chris Smith

unread,
Feb 20, 2020, 12:56:49 PM2/20/20
to sympy
That's what I figured, but I can't find a path to their location. I see "Release Notes" but that only has 1.5 as the most recent. And the change that I am looking for is not on that set of notes.

/c


On Wednesday, February 19, 2020 at 10:28:57 PM UTC-6, Aaron Meurer wrote:
Yes, that is the whole point of putting them on the wiki. You can edit
them at any time after the bot puts them there (before or after the
release).

Aaron Meurer

On Wed, Feb 19, 2020 at 9:06 PM Chris Smith <smi...@gmail.com> wrote:
>
> Is there a way to edit the release notes before they are finalized with a release? In other words, after commiting a PR can the release note for that PR be modified?
>
> /c
>
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sy...@googlegroups.com.

Oscar Benjamin

unread,
Feb 20, 2020, 1:01:10 PM2/20/20
to sympy
The release notes for 1.6 are here:
https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/8348d416-458f-4ee7-abb5-ff9769df0fc6%40googlegroups.com.

Chris Smith

unread,
Feb 20, 2020, 1:26:38 PM2/20/20
to sympy
Thanks, Oscar. I wonder if a link should be at the top of the Release Notes list (since "Release Notes" was easy to find). It could say "Release Notes (development)" and be changed to the correct number when the release is done and a new "development" Release note page made after the release.


On Thursday, February 20, 2020 at 12:01:10 PM UTC-6, Oscar wrote:
The release notes for 1.6 are here:
https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6

On Thu, 20 Feb 2020 at 17:56, Chris Smith <smi...@gmail.com> wrote:
>
> That's what I figured, but I can't find a path to their location. I see "Release Notes" but that only has 1.5 as the most recent. And the change that I am looking for is not on that set of notes.
>
> /c
>
> On Wednesday, February 19, 2020 at 10:28:57 PM UTC-6, Aaron Meurer wrote:
>>
>> Yes, that is the whole point of putting them on the wiki. You can edit
>> them at any time after the bot puts them there (before or after the
>> release).
>>
>> Aaron Meurer
>>
>> On Wed, Feb 19, 2020 at 9:06 PM Chris Smith <smi...@gmail.com> wrote:
>> >
>> > Is there a way to edit the release notes before they are finalized with a release? In other words, after commiting a PR can the release note for that PR be modified?
>> >
>> > /c
>> >
>> > --
>> > You received this message because you are subscribed to the Google Groups "sympy" group.
>> > To unsubscribe from this group and stop receiving emails from it, send an email to sy...@googlegroups.com.
>> > To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/8172eec5-f48d-4d46-989c-23a6459ab723%40googlegroups.com.
>
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sy...@googlegroups.com.

Aaron Meurer

unread,
Feb 20, 2020, 2:42:15 PM2/20/20
to sympy
It looks like the release notes page wasn't updated. I've fixed that.
We might also want to add a link to the main release notes page to
every release notes page.

The bot also posts a link to the release notes in every comment, so
you can easily find it from that.

Aaron Meurer
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/4b7d3bae-686d-42eb-b068-da7754efdbc3%40googlegroups.com.

Aaron Meurer

unread,
Feb 20, 2020, 2:49:21 PM2/20/20
to sympy
I added a link to the main release notes page on every release notes page.

Eventually we will make it so either the bot or the release notes
script will create the new release notes page automatically, so things
like forgetting to add it to the main release notes page happen in the
future.

Aaron Meurer

Chris Smith

unread,
Feb 21, 2020, 8:24:15 AM2/21/20
to sympy
Thanks. I updated a few of the entries in ntheory.

/c
Reply all
Reply to author
Forward
0 new messages