Use of flake8 seperately when we have ruff enabled

43 views
Skip to first unread message

Shishir Kushwaha

unread,
Feb 15, 2024, 8:50:51 AM2/15/24
to sympy
I was going through the pyproject.toml file and learned that we are using ruff which is also a test or part of a test that runs on github CLI . In the documentation as well as github CLI we are using ruff which can be used to replace flake8 from what I have read . 
In that case why do we use both of them when the work could just be done with ruff .

_____
Shishir Kushwaha

Aaron Meurer

unread,
Feb 15, 2024, 8:07:18 PM2/15/24
to sy...@googlegroups.com
I think maybe there were some checks that were done by flake8 that
weren't yet implemented by ruff. I don't know if that's still the
case. I agree we could probably just use ruff if it is doing
everything flake8 does.

Aaron Meurer
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/33ecc4b9-d500-4233-ad3b-2ff5df3e56dbn%40googlegroups.com.

Shishir Kushwaha

unread,
Feb 16, 2024, 6:15:40 AM2/16/24
to sympy
There is a PR open for config files for ruff for the issue of slotchecks ,
Would you please take a look into it , it might be related to this thread as well .
Almost all the things mentioned in the .flake8 file is also present in the ruff section . Kindly check if something is missing or if flake8 checks are being covered by ruff.

Shishir
Reply all
Reply to author
Forward
0 new messages