Use of flake8 seperately when we have ruff enabled
43 views
Skip to first unread message
Shishir Kushwaha
unread,
Feb 15, 2024, 8:50:51 AM2/15/24
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sympy
I was going through the pyproject.toml file and learned that we are using ruff which is also a test or part of a test that runs on github CLI . In the documentation as well as github CLI we are using ruff which can be used to replace flake8 from what I have read .
In that case why do we use both of them when the work could just be done with ruff .
_____
Shishir Kushwaha
Aaron Meurer
unread,
Feb 15, 2024, 8:07:18 PM2/15/24
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sy...@googlegroups.com
I think maybe there were some checks that were done by flake8 that
weren't yet implemented by ruff. I don't know if that's still the
case. I agree we could probably just use ruff if it is doing
everything flake8 does.
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sympy
There is a PR open for config files for ruff for the issue of slotchecks ,
Would you please take a look into it , it might be related to this thread as well .
Almost all the things mentioned in the .flake8 file is also present in the ruff section . Kindly check if something is missing or if flake8 checks are being covered by ruff.