Creation of a Group class (Group Theory)
72 views
Skip to first unread message
Orestis Vaggelis
Apr 12, 2022, 1:01:04 PM4/12/22
to sympy
Hello, my name is Orestis Vaggelis and I'm a senior undergraduate mathematics student in Greece. I noticed that the code related to group-theoretic methods is a bit messy. Therefore I'm thinking if creating a Group class containing all the related methods and subclasses would be beneficial.
I am more than happy to hear your thoughts about this!
I am more than happy to hear your thoughts about this!
Aaron Meurer
Apr 12, 2022, 4:04:17 PM4/12/22
to sy...@googlegroups.com
Can you be more specific about what you mean by messy, and what your
suggested class would contain? There is already a PermutationGroup
class that represents a group generated by a set of permutations.
Aaron Meurer
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/5dac6985-8a44-4507-9d86-f152da9ce660n%40googlegroups.com.
suggested class would contain? There is already a PermutationGroup
class that represents a group generated by a set of permutations.
Aaron Meurer
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/5dac6985-8a44-4507-9d86-f152da9ce660n%40googlegroups.com.
Orestis Vaggelis
Apr 12, 2022, 6:55:59 PM4/12/22
to sympy
The Group class would contain all the currently implemented classes as its subclasses. Right now, some methods are being reused both in FpGroup and the PermutationGroup class (for example the is_nilpotent() and is_abelian()). By creating a more general Group class we could avoid that and make the code more concrete.
Aaron Meurer
Apr 12, 2022, 7:56:57 PM4/12/22
to sy...@googlegroups.com
On Tue, Apr 12, 2022 at 4:56 PM Orestis Vaggelis
<orestis...@mail.com> wrote:
>
> The Group class would contain all the currently implemented classes as its subclasses. Right now, some methods are being reused both in FpGroup and the PermutationGroup class (for example the is_nilpotent() and is_abelian()). By creating a more general Group class we could avoid that and make the code more concrete.
Would there actually be any commonality between the implementations?
<orestis...@mail.com> wrote:
>
> The Group class would contain all the currently implemented classes as its subclasses. Right now, some methods are being reused both in FpGroup and the PermutationGroup class (for example the is_nilpotent() and is_abelian()). By creating a more general Group class we could avoid that and make the code more concrete.
I'm not really an expert on the group theory module, so I'm not sure.
Otherwise, what would Group be other than just a bunch of empty method
stubs?
Aaron Meurer
>
>
> On Tuesday, 12 April 2022 at 23:04:17 UTC+3 asme...@gmail.com wrote:
>>
>> Can you be more specific about what you mean by messy, and what your
>> suggested class would contain? There is already a PermutationGroup
>> class that represents a group generated by a set of permutations.
>>
>> Aaron Meurer
>>
>> On Tue, Apr 12, 2022 at 11:01 AM Orestis Vaggelis
>> <orestis...@mail.com> wrote:
>> >
>> > Hello, my name is Orestis Vaggelis and I'm a senior undergraduate mathematics student in Greece. I noticed that the code related to group-theoretic methods is a bit messy. Therefore I'm thinking if creating a Group class containing all the related methods and subclasses would be beneficial.
>> >
>> > I am more than happy to hear your thoughts about this!
>> >
>> > --
>> > You received this message because you are subscribed to the Google Groups "sympy" group.
>> > To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
>> > To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/5dac6985-8a44-4507-9d86-f152da9ce660n%40googlegroups.com.
>
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages