Asking for reviews/help on Prs

[Anderson Bhat]

Hello developers, 

As pointed out in the issues page by Oscar and others..... ( Add note about review procedure (no pinging on opening PR!) · Issue #23179 · sympy/sympy (github.com) ) pinging for reviews isn't helping too much (gets random sometimes and re-pinging the people who've already reviewed it once doesn't help sometimes as they've already expressed their opinions) and might not be the correct ways to ask for reviews . 

Hence it was suggested that if it's been over a month since the last review and the author of the pr has addressed all rquested/suggested changes then we could maybe ask for help here by sending a reminder here in the mailing list . Hence to implement this newly suggested workflow , i'll start it off !

I mainly deal with the series/concrete/functions/calculus module hence I would be glad if all interested contributors/maintainers/admins can jump in !

I'll place these by priority order to make it more easy for everyone . The higher I place it the more I feel it's good to go in !

1. Core/function : Fixes differentiation and series for Multivariate cases (more than 2 variable) by anutosh491 · Pull Request #22806 · sympy/sympy (github.com) (last reviewed 20 days ago)
   
2. Addresses multiple minor bugs/modifications in the series module (Docstring changes , adding tests etc) by anutosh491 · Pull Request #22422 · sympy/sympy (github.com)( last reviewed on Dec 11 2021)
   
3. Fixes Subs where the original and the substituted expression both have an Order term by anutosh491 · Pull Request #22339 · sympy/sympy (github.com)( last reviewed on Nov 25 2021)
   
4. Implemented function return_piecewise for evaluating limit when z0 is passed as Symbol by anutosh491 · Pull Request #22463 · sympy/sympy (github.com) (last reviewed on Dec 2 2021)
   
5. Fixes Ratio Test which wasn't checking whether the limit ratio was NaN or not leading into wrong results from basic Sums by anutosh491 · Pull Request #22200 · sympy/sympy (github.com) (last reviewed on Oct 6 2021)
   
6. Core: Fixed subs for expressions of the form Number*(Add Type) and Number*(Mul Type), Originally reported on SO by anutosh491 · Pull Request #22695 · sympy/sympy (github.com) (last reviewed on Dec 20 2021)
   
7. Series : Fixed taylor_term method for mutlivariate and other cases by anutosh491 · Pull Request #22804 · sympy/sympy (github.com) (No reviews yet)

Bonus one which I feel is a good one (was last reviewed 15 days back)

Series/limits :Added _eval_nseries and _eval_as_leading_term method for frac function by anutosh491 · Pull Request #23044 · sympy/sympy (github.com)

[Ondřej Čertík]

Hi Anderson,

I am sorry it takes so long to review PRs. I would say don't be afraid to ping people more often, perhaps after a week or so of no response.

Ondrej

On Thu, Mar 3, 2022, at 7:48 AM, Anderson Bhat wrote:
> Hello developers,
>
> As pointed out in the issues page by Oscar and others..... ( Add note
> about review procedure (no pinging on opening PR!) · Issue #23179 ·

> sympy/sympy (github.com) <https://github.com/sympy/sympy/issues/23179>

> ) pinging for reviews isn't helping too much (gets random sometimes and
> re-pinging the people who've already reviewed it once doesn't help
> sometimes as they've already expressed their opinions) and might not be
> the correct ways to ask for reviews .
>
> Hence it was suggested that if it's been over a month since the last
> review and the author of the pr has addressed all rquested/suggested
> changes then we could maybe ask for help here by sending a reminder
> here in the mailing list . Hence to implement this newly suggested
> workflow , i'll start it off !
>
> I mainly deal with the series/concrete/functions/calculus module hence
> I would be glad if all interested contributors/maintainers/admins can
> jump in !
> I'll place these by priority order to make it more easy for everyone .
> The higher I place it the more I feel it's good to go in !
>

> 1. Core/function : Fixes differentiation and series for Multivariate

> cases (more than 2 variable) by anutosh491 · Pull Request #22806 ·

> sympy/sympy (github.com) <https://github.com/sympy/sympy/pull/22806>

> (last reviewed 20 days ago)

> 2. Addresses multiple minor bugs/modifications in the series module

> (Docstring changes , adding tests etc) by anutosh491 · Pull Request
> #22422 · sympy/sympy (github.com)

> <https://github.com/sympy/sympy/pull/22422>( last reviewed on Dec 11
> 2021)
> 3. Fixes Subs where the original and the substituted expression both

> have an Order term by anutosh491 · Pull Request #22339 · sympy/sympy

> (github.com) <https://github.com/sympy/sympy/pull/22339>( last reviewed
> on Nov 25 2021)
> 4. Implemented function return_piecewise for evaluating limit when z0

> is passed as Symbol by anutosh491 · Pull Request #22463 · sympy/sympy

> (github.com) <https://github.com/sympy/sympy/pull/22463> (last reviewed
> on Dec 2 2021)
> 5. Fixes Ratio Test which wasn't checking whether the limit ratio was

> NaN or not leading into wrong results from basic Sums by anutosh491 ·
> Pull Request #22200 · sympy/sympy (github.com)

> <https://github.com/sympy/sympy/pull/22200> (last reviewed on Oct 6
> 2021)
> 6. Core: Fixed subs for expressions of the form Number*(Add Type) and

> Number*(Mul Type), Originally reported on SO by anutosh491 · Pull
> Request #22695 · sympy/sympy (github.com)

> <https://github.com/sympy/sympy/pull/22695> (last reviewed on Dec 20
> 2021)
> 7. Series : Fixed taylor_term method for mutlivariate and other cases

> by anutosh491 · Pull Request #22804 · sympy/sympy (github.com)

> <https://github.com/sympy/sympy/pull/22804> (No reviews yet)

> Bonus one which I feel is a good one (was last reviewed 15 days back)
> Series/limits :Added _eval_nseries and _eval_as_leading_term method for
> frac function by anutosh491 · Pull Request #23044 · sympy/sympy

> (github.com) <https://github.com/sympy/sympy/pull/23044>
>
> --
> You received this message because you are subscribed to the Google
> Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sympy/687cf29e-30fa-4f33-9229-f1c54b90bbb3n%40googlegroups.com
> <https://groups.google.com/d/msgid/sympy/687cf29e-30fa-4f33-9229-f1c54b90bbb3n%40googlegroups.com?utm_medium=email&utm_source=footer>.